LBRYCommunity/lbry-sdk
1
0
Fork 1
Code Issues Pull requests Projects Releases 282 Packages Wiki Activity

remove external ip from analytics

Browse source
This commit is contained in:
Victor Shyba 2021-06-28 00:25:33 -03:00
parent 6495694ac8
commit ac06b782a8
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
lbry/extras/daemon/analytics.py
View file

@ -40,7 +40,7 @@ def _event_properties(analytics_id: str, event_properties: typing.Optional[typin
return properties return properties
def _download_properties(conf: Config, external_ip: str, resolve_duration: float, def _download_properties(conf: Config, resolve_duration: float,
total_duration: typing.Optional[float], download_id: str, name: str, total_duration: typing.Optional[float], download_id: str, name: str,
outpoint: str, active_peer_count: typing.Optional[int], outpoint: str, active_peer_count: typing.Optional[int],
tried_peers_count: typing.Optional[int], connection_failures_count: typing.Optional[int], tried_peers_count: typing.Optional[int], connection_failures_count: typing.Optional[int],
@ -52,7 +52,6 @@ def _download_properties(conf: Config, external_ip: str, resolve_duration: float
error: typing.Optional[str] = None, error_msg: typing.Optional[str] = None, error: typing.Optional[str] = None, error_msg: typing.Optional[str] = None,
wallet_server: typing.Optional[str] = None) -> typing.Dict: wallet_server: typing.Optional[str] = None) -> typing.Dict:
return { return {
"external_ip": external_ip,
"download_id": download_id, "download_id": download_id,
"total_duration": round(total_duration, 4), "total_duration": round(total_duration, 4),
"resolve_duration": None if not resolve_duration else round(resolve_duration, 4), "resolve_duration": None if not resolve_duration else round(resolve_duration, 4),
@ -112,7 +111,6 @@ class AnalyticsManager:
self.context = _make_context(system_info.get_platform()) self.context = _make_context(system_info.get_platform())
self.analytics_id = utils.generate_id().hex() self.analytics_id = utils.generate_id().hex()
self.task: typing.Optional[asyncio.Task] = None self.task: typing.Optional[asyncio.Task] = None
self.external_ip: typing.Optional[str] = None
@property @property
def enabled(self): def enabled(self):
@ -129,7 +127,6 @@ class AnalyticsManager:
async def run(self): async def run(self):
while True: while True:
if self.enabled: if self.enabled:
self.external_ip, _ = await utils.get_external_ip(self.conf.lbryum_servers)
await self._send_heartbeat() await self._send_heartbeat()
await asyncio.sleep(1800) await asyncio.sleep(1800)
@ -191,7 +188,7 @@ class AnalyticsManager:
error_msg: typing.Optional[str] = None, error_msg: typing.Optional[str] = None,
wallet_server: typing.Optional[str] = None): wallet_server: typing.Optional[str] = None):
await self.track(self._event(TIME_TO_FIRST_BYTES, _download_properties( await self.track(self._event(TIME_TO_FIRST_BYTES, _download_properties(
self.conf, self.external_ip, resolve_duration, total_duration, download_id, name, outpoint, self.conf, resolve_duration, total_duration, download_id, name, outpoint,
found_peers_count, tried_peers_count, connection_failures_count, added_fixed_peers, fixed_peers_delay, found_peers_count, tried_peers_count, connection_failures_count, added_fixed_peers, fixed_peers_delay,
sd_hash, sd_download_duration, head_blob_hash, head_blob_length, head_blob_duration, error, error_msg, sd_hash, sd_download_duration, head_blob_hash, head_blob_length, head_blob_duration, error, error_msg,
wallet_server wallet_server