Adding Multi User & Role Tipping and Help/Warning Optimisation

ProfessorDey commented

2018-02-06 07:24:12 +01:00

(Migrated from github.com)

This includes my previous pull request. See individual commits for details

filipnyquist commented

2018-02-07 18:28:49 +01:00

(Migrated from github.com)

Looks good, i´ll test run this tomorrow on my sandbox server, i´ll assign myself this issue as nikoo catches up with life after studies :)

ProfessorDey commented

2018-02-12 14:53:26 +01:00

(Migrated from github.com)

Code has been updated to include some code fixes from MSFTblockchain and also adds some additional functionality, while cleaning things up code wise.

ProfessorDey commented

2018-02-12 23:47:50 +01:00

(Migrated from github.com)

And we are finally fully operational! Thanks a lot MSFTblockchain, you will be receiving half of whatever bounty or reward (personal or otherwise, Brazen likes his new custom features).

👍 1 🎉 1

ProfessorDey commented

2018-02-14 14:24:31 +01:00

(Migrated from github.com)

Unfortunately have no idea about the operation of the lbry backend because can't find any of that code anywhere. Also have no idea how new users are added as it's apparently supposed to be automatic when tipbot sends to a new address, meaning it should be in lbry.sendFrom(), which I don't have access to.

Unfortunately have no idea about the operation of the lbry backend because can't find any of that code anywhere. Also have no idea how new users are added as it's apparently supposed to be automatic when tipbot sends to a new address, meaning it _should_ be in lbry.sendFrom(), which I don't have access to.

MSFTserver commented

2018-02-15 02:14:09 +01:00

(Migrated from github.com)

NOTE: if you encounter some errors with sending transaction to too many people
i.e Error: Invalid params, response status code: 500
if you check the debug log in your wallet folder youll notice lines say:
request rejected becasue http work queue depth exceeded, it can be increased with the -rpcworkqueue= setting
simply add this to the wallet config

command		description
rpcthreads=X		Set the number of threads to service RPC calls (default: 4)
rpcworkqueue=XXX		Sets the depth of the work queue to service RPC calls (default is 16)
rpcclienttimeout=X		How many seconds bitcoin will wait for a complete RPC HTTP request

NOTE: if you encounter some errors with sending transaction to too many people i.e `Error: Invalid params, response status code: 500` if you check the debug log in your wallet folder youll notice lines say: `request rejected becasue http work queue depth exceeded, it can be increased with the -rpcworkqueue= setting` simply add this to the wallet config | command | | description | |:----------|-|:----------| | rpcthreads=X | | Set the number of threads to service RPC calls (default: 4) | | rpcworkqueue=XXX | | Sets the depth of the work queue to service RPC calls (default is 16) | | rpcclienttimeout=X | | How many seconds bitcoin will wait for a complete RPC HTTP request |

MSFTserver commented

2018-02-16 20:49:54 +01:00

(Migrated from github.com)

roletip and multitips private tipping mode isnt working

Sent from my Galaxy Note5 using FastHub

roletip and multitips private tipping mode isnt working _Sent from my Galaxy Note5 using [FastHub](https://play.google.com/store/apps/details?id=com.fastaccess.github)_

nikooo777 commented

2018-02-21 14:02:43 +01:00

(Migrated from github.com)

as discussed with @ProfessorDey there are still a few things to be committed before this can be merged so I'll wait for him to give me to GO.

ProfessorDey commented

2018-02-21 20:54:39 +01:00

(Migrated from github.com)

Ok @nikooo777 we're finally done, that should now be fully functional so long as you remember to install regex and set the rpc queue settings to higher values, since we have some large roles after all.

nikooo777 commented

2018-02-22 01:40:49 +01:00

(Migrated from github.com)

ok my changes have created conflicts. I'll see what i can do about it

nikooo777 commented

2018-02-22 02:29:05 +01:00

(Migrated from github.com)

Alright It took me a while but I think i managed to clean it up. Pushed to your fork so you can now test it again before I merge it.

ProfessorDey commented

2018-02-28 02:55:51 +01:00

(Migrated from github.com)

As I've said, I can confirm this works fine on my end, so feel free to merge whenever.