LBRYCommunity/lbry.tech
1
0
Fork 0
Code Issues 13 Pull requests 8 Projects Releases Packages Wiki Activity

Package.json updates: Windows & yarn #240

Merged
Wick merged 7 commits from package.json-updates into master 2019-01-28 15:52:55 +01:00
Conversation 3 Commits 7 Files changed 3 +7469 -4
Wick commented 2019-01-25 21:08:59 +01:00 (Migrated from github.com)
Copy link

Some improvements (mostly) for Windows developers:

Expanded list of supported engines to include versions up to the latest version of node (gives better support for yarn package manager as a bonus).

Escape quotes in the npm run format command. This will make the command run without error in Windows environments (should be fine for other OSes as well I think?) .

Added lockfile for yarn to get consistent installs across machines. Reference: https://yarnpkg.com/lang/en/docs/yarn-lock/

Some improvements (mostly) for Windows developers: Expanded list of supported engines to include versions up to the latest version of node (gives better support for yarn package manager as a bonus). Escape quotes in the ```npm run format``` command. This will make the command run without error in Windows environments (should be fine for other OSes as well I think?) . Added lockfile for yarn to get consistent installs across machines. Reference: https://yarnpkg.com/lang/en/docs/yarn-lock/
NetOpWibby commented 2019-01-25 22:39:48 +01:00 (Migrated from github.com)
Copy link

@Wick Could you update the Installation section of the README with yarn instructions? I don't personally use it.

@Wick Could you update the Installation section of the README with yarn instructions? I don't personally use it.
NetOpWibby (Migrated from github.com) reviewed 2019-01-25 22:40:04 +01:00
package.json
@ -71,3 +71,3 @@
"engines": {
"node": "10.2.x"
"node": ">=10.2 <10.15.1"
},
NetOpWibby (Migrated from github.com) commented 2019-01-25 22:40:04 +01:00
Copy link

This looks confusing, what does it do?

This looks confusing, what does it do?
NetOpWibby (Migrated from github.com) reviewed 2019-01-25 22:40:28 +01:00
package.json
NetOpWibby (Migrated from github.com) commented 2019-01-25 22:40:28 +01:00
Copy link

Does the second command in this line need to escaped too?

Does the second command in this line need to escaped too?
Wick (Migrated from github.com) reviewed 2019-01-26 13:44:14 +01:00
package.json
Wick (Migrated from github.com) commented 2019-01-26 13:44:14 +01:00
Copy link

Not needed, runs just fine after escaping only the eslint command. :)

Not needed, runs just fine after escaping only the eslint command. :)
Wick (Migrated from github.com) reviewed 2019-01-26 15:35:39 +01:00
package.json
@ -71,3 +71,3 @@
"engines": {
"node": "10.2.x"
"node": ">=10.2 <10.15.1"
},
Wick (Migrated from github.com) commented 2019-01-26 15:35:39 +01:00
Copy link

For regular users using npm this is just an indicator on which versions of node that can run this project fine.
If you use an alternative dependency manager, like Yarn, you'll get an error if your node version doesn't match the ones listed under "engines".
My change only extends the list of working node versions to include the versions of node between the last set version(10.2.x) and the latest recommended version listed on https://nodejs.org/en/ (which I use and it works without problems).

Not really an important change, want me to revert it?

For regular users using npm this is just an indicator on which versions of node that can run this project fine. If you use an alternative dependency manager, like Yarn, you'll get an error if your node version doesn't match the ones listed under "engines". My change only extends the list of working node versions to include the versions of node between the last set version(10.2.x) and the latest recommended version listed on https://nodejs.org/en/ (which I use and it works without problems). Not really an important change, want me to revert it?
NetOpWibby (Migrated from github.com) reviewed 2019-01-26 17:27:31 +01:00
package.json
@ -71,3 +71,3 @@
"engines": {
"node": "10.2.x"
"node": ">=10.2 <10.15.1"
},
NetOpWibby (Migrated from github.com) commented 2019-01-26 17:27:31 +01:00
Copy link

No it's fine, since yarn is being added anyway.

No it's fine, since yarn is being added anyway.
Wick commented 2019-01-28 03:00:53 +01:00 (Migrated from github.com)
Copy link

Updated the readme in my latest commit, let me know if I can improve it in any way. :)

I know npm supports lock-files as well nowadays, but noticed it is explicitly set to not generate one in .npmrc. So I only mentioned the lock-file for Yarn for now.

Updated the readme in my latest commit, let me know if I can improve it in any way. :) I know npm supports lock-files as well nowadays, but noticed it is explicitly set to not generate one in [.npmrc](https://github.com/lbryio/lbry.tech/blob/master/.npmrc). So I only mentioned the lock-file for Yarn for now.
NetOpWibby commented 2019-01-28 15:52:37 +01:00 (Migrated from github.com)
Copy link

That's cool. I've had more negative than positive experiences with lockfiles so I disabled them.

That's cool. I've had more negative than positive experiences with lockfiles so I disabled them.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
campaign-blocker

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
Content

   
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
campaign-blocker
consider soon
Content
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry.tech#240
No description provided.
Delete branch "package.json-updates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?