LBRYCommunity/lbry.tech
1
0
Fork 0
Code Issues 13 Pull requests 8 Projects Releases Packages Wiki Activity

Package.json updates: Windows & yarn #240

Merged
Wick merged 7 commits from package.json-updates into master 2019-01-28 15:52:55 +01:00
Conversation 3 Commits 7 Files changed 3 +7469 -4
3 changed files with 7469 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
README.md
View file

@ -32,8 +32,21 @@
- **This repo will not run locally if you do not also have the LBRY app/daemon and the [web-daemon](https://github.com/lbryio/web-daemon) running.**
- When running locally and completing the tipping example in Playground, the LBC donated to a creator comes from _your_ LBC balance. Otherwise, the example will fail. On production, the donated LBC comes from LBRY.
## Installation
`npm i`
## Local Installation
### npm
```bash
npm install
```
### Yarn
There is a yarn.lock file, you can thus use yarn to install a guaranteed working configuration of packages. This is generally a lot faster to install and more stable. Yarn as a CLI is not necessarily more stable than npm and as such, it's optional. Install yarn here: https://yarnpkg.com/en/docs/install
Then
```bash
yarn install
```
## Development
`npm run watch` and visit [localhost:8080](http://localhost:8080)

4
package.json
View file

@ -69,7 +69,7 @@
"updates": "^6.2.1"
},
"engines": {
"node": "10.2.x"
"node": ">=10.2 <10.15.1"
},
NetOpWibby commented 2019-01-25 22:40:04 +01:00 (Migrated from github.com)
Review
Copy link

This looks confusing, what does it do?

This looks confusing, what does it do?
Wick commented 2019-01-26 15:35:39 +01:00 (Migrated from github.com)
Review
Copy link

For regular users using npm this is just an indicator on which versions of node that can run this project fine.
If you use an alternative dependency manager, like Yarn, you'll get an error if your node version doesn't match the ones listed under "engines".
My change only extends the list of working node versions to include the versions of node between the last set version(10.2.x) and the latest recommended version listed on https://nodejs.org/en/ (which I use and it works without problems).

Not really an important change, want me to revert it?

For regular users using npm this is just an indicator on which versions of node that can run this project fine. If you use an alternative dependency manager, like Yarn, you'll get an error if your node version doesn't match the ones listed under "engines". My change only extends the list of working node versions to include the versions of node between the last set version(10.2.x) and the latest recommended version listed on https://nodejs.org/en/ (which I use and it works without problems). Not really an important change, want me to revert it?
NetOpWibby commented 2019-01-26 17:27:31 +01:00 (Migrated from github.com)
Review
Copy link

No it's fine, since yarn is being added anyway.

No it's fine, since yarn is being added anyway.
"husky": {
"hooks": {
@ -81,7 +81,7 @@
"private": true,
"scripts": {
"css": "sass --load-path=node_modules --update app/sass:app/dist --style compressed",
"format": "eslint '**/*.js' --fix --ignore-pattern '/app/dist/'",
"format": "eslint \"**/*.js\" --fix --ignore-pattern '/app/dist/'",
"start": "npm run css && npm i && NODE_ENV=production node index.js",
"test": "run-s test:*",
"test:dependencies": "updates --update ./ --exclude fastify,prismjs",

7452
yarn.lock Normal file
View file

File diff suppressed because it is too large Load diff