LBRYCommunity/lbry.tech
1
0
Fork 0
Code Issues 13 Pull requests 8 Projects Releases Packages Wiki Activity

Fix: make smoothscroll work with markdown links & update broken links (glossary) #234

Merged
Wick merged 5 commits from fix-glossary into master 2019-01-25 19:05:35 +01:00
Conversation 1 Commits 5 Files changed 2 +12 -17
Wick commented 2019-01-25 12:23:00 +01:00 (Migrated from github.com)
Copy link

Fixes #216
Use link format [SPV](#spv) instead of [[SPV]] since same page linking is case sensitive. This link format now also enables smooth scrolling with working browser history for same page links.

Fixes #216 Use link format ```[SPV](#spv)``` instead of ```[[SPV]]``` since same page linking is case sensitive. This link format now also enables smooth scrolling with working browser history for same page links.
tzarebczan commented 2019-01-25 12:35:35 +01:00 (Migrated from github.com)
Copy link

Thanks for the PR @Wick, we'll get a review on it!! Can we send you some appreciation for your effort?

Thanks for the PR @Wick, we'll get a review on it!! Can we send you [some appreciation](https://LBRY.io/faq/appreciation) for your effort?
NetOpWibby (Migrated from github.com) requested changes 2019-01-25 18:02:06 +01:00
app/dist/scripts/app.js
@ -43,4 +41,1 @@
event.target.parentElement.className === "api__toc__item" ||
event.target.parentElement.parentElement.className === "component--glossary-toc"
) history.replaceState({}, "", `#${element}`);
});
NetOpWibby (Migrated from github.com) commented 2019-01-25 18:00:59 +01:00
Copy link

Does removing this block affect other pages? For example, if I click a glossary link from the Overview page, will the smooth scroll and anchoring happen?

Does removing this block affect other pages? For example, if I click a glossary link from the Overview page, will the smooth scroll and anchoring happen?
NetOpWibby (Migrated from github.com) commented 2019-01-25 18:01:40 +01:00
Copy link

I'm not sure how to checkout your branch to test myself.

I'm not sure how to checkout your branch to test myself.
NetOpWibby (Migrated from github.com) reviewed 2019-01-25 19:01:15 +01:00
app/dist/scripts/app.js
@ -43,4 +41,1 @@
event.target.parentElement.className === "api__toc__item" ||
event.target.parentElement.parentElement.className === "component--glossary-toc"
) history.replaceState({}, "", `#${element}`);
});
NetOpWibby (Migrated from github.com) commented 2019-01-25 19:01:15 +01:00
Copy link

@Wick ^

@Wick ^
Wick (Migrated from github.com) reviewed 2019-01-25 19:04:46 +01:00
app/dist/scripts/app.js
@ -43,4 +41,1 @@
event.target.parentElement.className === "api__toc__item" ||
event.target.parentElement.parentElement.className === "component--glossary-toc"
) history.replaceState({}, "", `#${element}`);
});
Wick (Migrated from github.com) commented 2019-01-25 19:04:46 +01:00
Copy link

Tested on the overview page + api page and it smooth scrolls as it should and updates the URL. My reasoning behind the change was that if it manages to successfully find an element to scroll to it can safely be added to browser history.

I noticed a related issue though: that when smooth-scrolling occurs it wont get properly placed in browser history, on current site as well (navigate with the sidebar then click back in the browser).
My latest commit will fix this by changing from history.replaceState to history.pushState for updating browser history.

Let me know if you need anything more :)

Tested on the overview page + api page and it smooth scrolls as it should and updates the URL. My reasoning behind the change was that if it manages to successfully find an element to scroll to it can safely be added to browser history. I noticed a related issue though: that when smooth-scrolling occurs it wont get properly placed in browser history, on current site as well (navigate with the sidebar then click back in the browser). My latest commit will fix this by changing from history.replaceState to history.pushState for updating browser history. Let me know if you need anything more :)
NetOpWibby (Migrated from github.com) reviewed 2019-01-25 19:05:22 +01:00
app/dist/scripts/app.js
@ -43,4 +41,1 @@
event.target.parentElement.className === "api__toc__item" ||
event.target.parentElement.parentElement.className === "component--glossary-toc"
) history.replaceState({}, "", `#${element}`);
});
NetOpWibby (Migrated from github.com) commented 2019-01-25 19:05:22 +01:00
Copy link

Sweet, sounds good to me. Thanks!

Sweet, sounds good to me. Thanks!
NetOpWibby (Migrated from github.com) approved these changes 2019-01-25 19:05:28 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
NetOpWibby
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
campaign-blocker

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
Content

   
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
campaign-blocker
consider soon
Content
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry.tech#234
No description provided.
Delete branch "fix-glossary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?