LBRYCommunity/lbry.tech
1
0
Fork 0
Code Issues 13 Pull requests 8 Projects Releases Packages Wiki Activity

Package.json updates: Windows & yarn #240

Merged
Wick merged 7 commits from package.json-updates into master 2019-01-28 15:52:55 +01:00
Conversation 3 Commits 7 Files changed 3 +1 -1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 73ed71df98 - Show all commits

2
package.json
View file

@ -69,7 +69,7 @@
"updates": "^6.0.3"
},
"engines": {
"node": "10.2.x"
"node": ">=10.2 <10.15.1"
},
NetOpWibby commented 2019-01-25 22:40:04 +01:00 (Migrated from github.com)
Review
Copy link

This looks confusing, what does it do?

This looks confusing, what does it do?
Wick commented 2019-01-26 15:35:39 +01:00 (Migrated from github.com)
Review
Copy link

For regular users using npm this is just an indicator on which versions of node that can run this project fine.
If you use an alternative dependency manager, like Yarn, you'll get an error if your node version doesn't match the ones listed under "engines".
My change only extends the list of working node versions to include the versions of node between the last set version(10.2.x) and the latest recommended version listed on https://nodejs.org/en/ (which I use and it works without problems).

Not really an important change, want me to revert it?

For regular users using npm this is just an indicator on which versions of node that can run this project fine. If you use an alternative dependency manager, like Yarn, you'll get an error if your node version doesn't match the ones listed under "engines". My change only extends the list of working node versions to include the versions of node between the last set version(10.2.x) and the latest recommended version listed on https://nodejs.org/en/ (which I use and it works without problems). Not really an important change, want me to revert it?
NetOpWibby commented 2019-01-26 17:27:31 +01:00 (Migrated from github.com)
Review
Copy link

No it's fine, since yarn is being added anyway.

No it's fine, since yarn is being added anyway.
"husky": {
"hooks": {