Merge #12283: Fix typos
1340eda3b7
Fix typos (practicalswift)
Pull request description:
Fix typos.
Tree-SHA512: 533a136831387ef26e9a74ba078437496bee38cc026da73fa9e6f6e7f4d5665eccac24cf3ef05e6d3af1329a1214f5ce71b039ddb8378b074e6d4408b8701f95
This commit is contained in:
commit
1b06ed136f
9 changed files with 11 additions and 11 deletions
|
@ -934,8 +934,8 @@ if test x$use_pkgconfig = xyes; then
|
||||||
m4_ifdef(
|
m4_ifdef(
|
||||||
[PKG_CHECK_MODULES],
|
[PKG_CHECK_MODULES],
|
||||||
[
|
[
|
||||||
PKG_CHECK_MODULES([SSL], [libssl],, [AC_MSG_ERROR(openssl not found.)])
|
PKG_CHECK_MODULES([SSL], [libssl],, [AC_MSG_ERROR(openssl not found.)])
|
||||||
PKG_CHECK_MODULES([CRYPTO], [libcrypto],,[AC_MSG_ERROR(libcrypto not found.)])
|
PKG_CHECK_MODULES([CRYPTO], [libcrypto],,[AC_MSG_ERROR(libcrypto not found.)])
|
||||||
BITCOIN_QT_CHECK([PKG_CHECK_MODULES([PROTOBUF], [protobuf], [have_protobuf=yes], [BITCOIN_QT_FAIL(libprotobuf not found)])])
|
BITCOIN_QT_CHECK([PKG_CHECK_MODULES([PROTOBUF], [protobuf], [have_protobuf=yes], [BITCOIN_QT_FAIL(libprotobuf not found)])])
|
||||||
if test x$use_qr != xno; then
|
if test x$use_qr != xno; then
|
||||||
BITCOIN_QT_CHECK([PKG_CHECK_MODULES([QR], [libqrencode], [have_qrencode=yes], [have_qrencode=no])])
|
BITCOIN_QT_CHECK([PKG_CHECK_MODULES([QR], [libqrencode], [have_qrencode=yes], [have_qrencode=no])])
|
||||||
|
|
|
@ -13,7 +13,7 @@ Before every minor and major release:
|
||||||
* Update version in `configure.ac` (don't forget to set `CLIENT_VERSION_IS_RELEASE` to `true`)
|
* Update version in `configure.ac` (don't forget to set `CLIENT_VERSION_IS_RELEASE` to `true`)
|
||||||
* Write release notes (see below)
|
* Write release notes (see below)
|
||||||
* Update `src/chainparams.cpp` nMinimumChainWork with information from the getblockchaininfo rpc.
|
* Update `src/chainparams.cpp` nMinimumChainWork with information from the getblockchaininfo rpc.
|
||||||
* Update `src/chainparams.cpp` defaultAssumeValid with information from the getblockhash rpc.
|
* Update `src/chainparams.cpp` defaultAssumeValid with information from the getblockhash rpc.
|
||||||
- The selected value must not be orphaned so it may be useful to set the value two blocks back from the tip.
|
- The selected value must not be orphaned so it may be useful to set the value two blocks back from the tip.
|
||||||
- Testnet should be set some tens of thousands back from the tip due to reorgs there.
|
- Testnet should be set some tens of thousands back from the tip due to reorgs there.
|
||||||
- This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect
|
- This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect
|
||||||
|
|
|
@ -126,7 +126,7 @@ public:
|
||||||
|
|
||||||
// Note that of those which support the service bits prefix, most only support a subset of
|
// Note that of those which support the service bits prefix, most only support a subset of
|
||||||
// possible options.
|
// possible options.
|
||||||
// This is fine at runtime as we'll fall back to using them as a oneshot if they dont support the
|
// This is fine at runtime as we'll fall back to using them as a oneshot if they don't support the
|
||||||
// service bits we want, but we should get them updated to support all service bits wanted by any
|
// service bits we want, but we should get them updated to support all service bits wanted by any
|
||||||
// release ASAP to avoid it where possible.
|
// release ASAP to avoid it where possible.
|
||||||
vSeeds.emplace_back("seed.bitcoin.sipa.be"); // Pieter Wuille, only supports x1, x5, x9, and xd
|
vSeeds.emplace_back("seed.bitcoin.sipa.be"); // Pieter Wuille, only supports x1, x5, x9, and xd
|
||||||
|
|
|
@ -294,7 +294,7 @@ enum ServiceFlags : uint64_t {
|
||||||
* Thus, generally, avoid calling with peerServices == NODE_NONE, unless
|
* Thus, generally, avoid calling with peerServices == NODE_NONE, unless
|
||||||
* state-specific flags must absolutely be avoided. When called with
|
* state-specific flags must absolutely be avoided. When called with
|
||||||
* peerServices == NODE_NONE, the returned desirable service flags are
|
* peerServices == NODE_NONE, the returned desirable service flags are
|
||||||
* guaranteed to not change dependant on state - ie they are suitable for
|
* guaranteed to not change dependent on state - ie they are suitable for
|
||||||
* use when describing peers which we know to be desirable, but for which
|
* use when describing peers which we know to be desirable, but for which
|
||||||
* we do not have a confirmed set of service flags.
|
* we do not have a confirmed set of service flags.
|
||||||
*
|
*
|
||||||
|
|
|
@ -82,7 +82,7 @@ class CVectorWriter
|
||||||
* @param[in] nVersionIn Serialization Version (including any flags)
|
* @param[in] nVersionIn Serialization Version (including any flags)
|
||||||
* @param[in] vchDataIn Referenced byte vector to overwrite/append
|
* @param[in] vchDataIn Referenced byte vector to overwrite/append
|
||||||
* @param[in] nPosIn Starting position. Vector index where writes should start. The vector will initially
|
* @param[in] nPosIn Starting position. Vector index where writes should start. The vector will initially
|
||||||
* grow as necessary to max(nPosIn, vec.size()). So to append, use vec.size().
|
* grow as necessary to max(nPosIn, vec.size()). So to append, use vec.size().
|
||||||
*/
|
*/
|
||||||
CVectorWriter(int nTypeIn, int nVersionIn, std::vector<unsigned char>& vchDataIn, size_t nPosIn) : nType(nTypeIn), nVersion(nVersionIn), vchData(vchDataIn), nPos(nPosIn)
|
CVectorWriter(int nTypeIn, int nVersionIn, std::vector<unsigned char>& vchDataIn, size_t nPosIn) : nType(nTypeIn), nVersion(nVersionIn), vchData(vchDataIn), nPos(nPosIn)
|
||||||
{
|
{
|
||||||
|
|
|
@ -25,8 +25,8 @@ void PrintLockContention(const char* pszName, const char* pszFile, int nLine)
|
||||||
//
|
//
|
||||||
// Early deadlock detection.
|
// Early deadlock detection.
|
||||||
// Problem being solved:
|
// Problem being solved:
|
||||||
// Thread 1 locks A, then B, then C
|
// Thread 1 locks A, then B, then C
|
||||||
// Thread 2 locks D, then C, then A
|
// Thread 2 locks D, then C, then A
|
||||||
// --> may result in deadlock between the two threads, depending on when they run.
|
// --> may result in deadlock between the two threads, depending on when they run.
|
||||||
// Solution implemented here:
|
// Solution implemented here:
|
||||||
// Keep track of pairs of locks: (A before B), (A before C), etc.
|
// Keep track of pairs of locks: (A before B), (A before C), etc.
|
||||||
|
|
|
@ -2577,7 +2577,7 @@ bool CChainState::ActivateBestChain(CValidationState &state, const CChainParams&
|
||||||
if (GetMainSignals().CallbacksPending() > 10) {
|
if (GetMainSignals().CallbacksPending() > 10) {
|
||||||
// Block until the validation queue drains. This should largely
|
// Block until the validation queue drains. This should largely
|
||||||
// never happen in normal operation, however may happen during
|
// never happen in normal operation, however may happen during
|
||||||
// reindex, causing memory blowup if we run too far ahead.
|
// reindex, causing memory blowup if we run too far ahead.
|
||||||
SyncWithValidationInterfaceQueue();
|
SyncWithValidationInterfaceQueue();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -103,7 +103,7 @@ BOOST_AUTO_TEST_CASE(coin_selection_tests)
|
||||||
// we can't make 3 cents of mature coins
|
// we can't make 3 cents of mature coins
|
||||||
BOOST_CHECK(!testWallet.SelectCoinsMinConf( 3 * CENT, 1, 6, 0, vCoins, setCoinsRet, nValueRet));
|
BOOST_CHECK(!testWallet.SelectCoinsMinConf( 3 * CENT, 1, 6, 0, vCoins, setCoinsRet, nValueRet));
|
||||||
|
|
||||||
// we can make 3 cents of new coins
|
// we can make 3 cents of new coins
|
||||||
BOOST_CHECK( testWallet.SelectCoinsMinConf( 3 * CENT, 1, 1, 0, vCoins, setCoinsRet, nValueRet));
|
BOOST_CHECK( testWallet.SelectCoinsMinConf( 3 * CENT, 1, 1, 0, vCoins, setCoinsRet, nValueRet));
|
||||||
BOOST_CHECK_EQUAL(nValueRet, 3 * CENT);
|
BOOST_CHECK_EQUAL(nValueRet, 3 * CENT);
|
||||||
|
|
||||||
|
|
|
@ -6,7 +6,7 @@
|
||||||
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
||||||
"""Bitcoin P2P network half-a-node.
|
"""Bitcoin P2P network half-a-node.
|
||||||
|
|
||||||
This python code was modified from ArtForz' public domain half-a-node, as
|
This python code was modified from ArtForz' public domain half-a-node, as
|
||||||
found in the mini-node branch of http://github.com/jgarzik/pynode.
|
found in the mini-node branch of http://github.com/jgarzik/pynode.
|
||||||
|
|
||||||
P2PConnection: A low-level connection object to a node's P2P interface
|
P2PConnection: A low-level connection object to a node's P2P interface
|
||||||
|
|
Loading…
Reference in a new issue