Pieter Wuille
0a83c0fcef
Fix tests after recent refactors
2012-04-17 20:37:47 +02:00
Pieter Wuille
c23617fef3
Merge remote-tracking branch 'jgarzik/mempool'
2012-04-17 20:12:48 +02:00
Pieter Wuille
caeddc5d37
Merge pull request #1117 from sipa/deadlockfix
...
Fix potential deadlock
2012-04-17 11:05:02 -07:00
Pieter Wuille
1ffeb89a52
Merge pull request #1112 from sipa/saneserial
...
Further reduce header dependencies
2012-04-17 11:04:29 -07:00
Pieter Wuille
6b6aaa1698
Further reduce header dependencies
...
This commit removes the dependency of serialize.h on PROTOCOL_VERSION,
and makes this parameter required instead of implicit. This is much saner,
as it makes the places where changing a version number can have an
influence obvious.
2012-04-17 20:03:42 +02:00
Jeff Garzik
ccd65d4261
Move proto version to version.h. Reduce header deps a bit more.
2012-04-17 20:02:38 +02:00
Jeff Garzik
9eace6b113
Move CWalletDB code to new walletdb module.
...
In addition to standard code separation, this change opens the door
to fixing several include inter-dependencies.
2012-04-17 20:00:55 +02:00
Pieter Wuille
ed6d0b5f85
Remove headers.h
2012-04-17 20:00:55 +02:00
Gavin Andresen
b97d54355e
Merge pull request #1106 from jgarzik/sign-compare
...
Fix many sign-comparison warnings found in bitcoin codebase
2012-04-17 10:55:56 -07:00
Gavin Andresen
e873dc654c
Merge pull request #1115 from laanwj/2012_04_cleanupmisc
...
Delete unused, unreachable and commented code, add missing initializer
2012-04-17 10:12:33 -07:00
Pieter Wuille
c581cc16bb
Fix potential deadlock
...
Conflict:
* cs_main in ProcessMessages() (before calling ProcessMessages)
* cs_vSend in CNode::BeginMessage
versus:
* cs_vSend in ThreadMessageHandler2 (before calling SendMessages)
* cs_main in SendMessages
Even though cs_vSend is a try_lock, if it succeeds simultaneously with
the locking of cs_main in ProcessMessages(), it could cause a deadlock.
2012-04-17 18:50:52 +02:00
Jeff Garzik
ce8c93498a
main.cpp: replace tabs with spaces
...
Sometimes they sneak in through the 'vi' door
2012-04-17 12:31:51 -04:00
Jeff Garzik
8bff8ac079
AlreadyHave(): only hold lock during mapTransactions access
2012-04-17 12:30:00 -04:00
Wladimir J. van der Laan
7fa3ad83a9
Remove unused and unreachable code
2012-04-17 18:28:02 +02:00
Wladimir J. van der Laan
4941aad657
Add forgotten initializer
2012-04-17 18:27:55 +02:00
Jeff Garzik
dd21ce5f1b
Merge pull request #1094 from jgarzik/already-have-locking
...
Locking fix for AlreadyHave()
2012-04-17 09:23:49 -07:00
Jeff Garzik
ea9627979e
Bump PROTOCOL_VERSION to 60001, thereby enabling BIP31
2012-04-17 12:16:46 -04:00
Jeff Garzik
865a0c1674
Merge pull request #1081 from jgarzik/pong
...
BIP 0031: pong message
2012-04-17 08:51:17 -07:00
Wladimir J. van der Laan
7a5452ffb3
Merge pull request #1092 from laanwj/2012_04_sendcoins_setlabelfix
...
When sending coins, set label when selecting address that already has a label
2012-04-16 05:41:39 -07:00
Wladimir J. van der Laan
088a13331b
Merge pull request #1091 from Diapolo/GUI-BlockDL
...
revert to default OS theme for progressbar (fix #1071 )
2012-04-16 00:55:37 -07:00
Jeff Garzik
9fb89c26f3
Fix misc. minor sign-comparison warnings
2012-04-15 17:00:20 -04:00
Jeff Garzik
0dd710acb6
CNode's nHeaderStart may be negative, so change its type
2012-04-15 16:59:48 -04:00
Jeff Garzik
c3fad8350b
serialize.h: CAutoFile's read and write may take size_t nSize
2012-04-15 16:59:09 -04:00
Jeff Garzik
3a78f82a78
Fix sign-compare warnings: netbase's Lookup* max-solutions may be unsigned
2012-04-15 16:58:32 -04:00
Jeff Garzik
c376ac359e
Fix loop index var types, fixing many minor sign comparison warnings
...
foo.size() typically returns an unsigned integral type; make loop variables
match those types' signedness.
2012-04-15 16:52:09 -04:00
Jeff Garzik
ab9dc75a18
The string class returns string::npos, when find() fails.
...
Noticed when sign-comparison warnings were enabled.
2012-04-15 16:47:24 -04:00
Jeff Garzik
ca4c4c53a8
CTxMemPool: add helper methods, to reduce global mempool.mapTx accesses
2012-04-15 14:43:19 -04:00
Jeff Garzik
d01903e751
CTxMemPool: encapsulate AcceptToMemoryPool
2012-04-15 14:43:19 -04:00
Jeff Garzik
8e45ed66dd
CTxMemPool: encapsulate AddToMemoryPoolUnchecked(), RemoveFromMemoryPool(),
...
and nPooledTx
2012-04-15 14:42:52 -04:00
Jeff Garzik
235507ae48
New class CTxMemPool, encapsulating TX memory pool data members
2012-04-15 14:41:27 -04:00
Jeff Garzik
5a701eb7ea
Merge pull request #1104 from laanwj/2012_04_clang
...
Enable and fix most compilation warnings
2012-04-15 11:39:15 -07:00
Jeff Garzik
fced2231f8
Merge pull request #1084 from dooglus/validate_secret
...
importprivkey doesn't check that it is given a private key
2012-04-15 09:25:29 -07:00
Wladimir J. van der Laan
9ea8e60a0c
Merge pull request #1097 from laanwj/2012_04_runawayexception
...
Show a message box when runaway exception happens
2012-04-15 09:22:26 -07:00
Jeff Garzik
c99ddfaa22
Merge pull request #1100 from luke-jr/qrcode_errchk
...
Bugfix: Check that QRcode_encodeString didn't return NULL (error)
2012-04-15 08:31:22 -07:00
Wladimir J. van der Laan
da7bbd9dfd
fix warnings: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
2012-04-15 13:40:14 +02:00
Wladimir J. van der Laan
6642ffb761
fix warnings: '&&' within '||' [-Wlogical-op-parentheses]
2012-04-15 13:40:14 +02:00
Wladimir J. van der Laan
2e120f28e0
fix warnings: delete called on 'XX' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
2012-04-15 13:40:14 +02:00
Wladimir J. van der Laan
11cd416525
fix warnings: unused variable 'XX' [-Wunused-variable]
2012-04-15 13:40:14 +02:00
Wladimir J. van der Laan
76d8170ce8
fix warnings: enumeration values 'XX' not handled in switch [-Wswitch-enum]
2012-04-15 13:40:14 +02:00
Wladimir J. van der Laan
87207a2e08
fix warnings: 'XX' defined as a struct here but previously declared as a class [-Wmismatched-tags]
2012-04-15 13:40:14 +02:00
Wladimir J. van der Laan
8add7822ce
fix warnings: array subscript is of type 'char' [-Wchar-subscripts]
2012-04-15 13:40:14 +02:00
Wladimir J. van der Laan
1f29d399f4
work around issue in boost::program_options that prevents from compiling in clang
2012-04-15 13:40:14 +02:00
Wladimir J. van der Laan
f9f625fb32
enable all warnings except invalid-offsetof, sign-compare, unused-parameter
2012-04-15 13:40:14 +02:00
Luke Dashjr
2eb665c634
Bugfix: Check that QRcode_encodeString didn't return NULL (error)
...
Without this, any error will segfault Bitcoin-Qt
2012-04-14 21:00:27 -04:00
Wladimir J. van der Laan
a7a0c7a1bf
Show a message box when runaway exception happens
...
This is more clear to users than when the program simply disappears (usually during initialization). It still logs the message to the console and debug log as well.
2012-04-14 18:35:42 +02:00
Wladimir J. van der Laan
6f6f524f1a
Rename make_windows_icon.py to .sh as it is a shell script ( fixes #1099 )
2012-04-14 18:33:19 +02:00
Jeff Garzik
22014c31e5
Merge pull request #1093 from jgarzik/tx-opt
...
Database micro-optimization for "tx" network message
2012-04-14 08:50:43 -07:00
Wladimir J. van der Laan
46ba858817
Merge pull request #1089 from laanwj/2012_04_translationupdate
...
Update translations for bitcoin core
2012-04-13 23:47:50 -07:00
Wladimir J. van der Laan
3fddc8effc
Update translations for bitcoin core
...
- Move scripts/qt to share/qt, to clean up toplevel directories
- Update english ts file which is used to source messages for Transifex
- In extract_strings_qt.py use a glob *.h *.cpp, this is safe now that the Wx UI files are removed
2012-04-14 08:46:16 +02:00
Wladimir J. van der Laan
c1d0547cf6
Merge pull request #1096 from laanwj/2012_04_tick
...
Do not show green tick unless all known blocks are downloaded (fixes #921 )
2012-04-13 23:27:23 -07:00