Giel van Schijndel
507fd9d15b
Start moving protocol-specific code to protocol.[ch]pp
...
Move CMessageHeader from net.h to protocol.[ch]pp, with the
implementation in the .cpp compilation unit (compiling once is enough).
This commit does *not* and should not modify *any* code, it only moves
it from net.h and splits it across protocol.cpp and protocol.hpp.
Indentation changes aside the closest thing to a modification of code is
the addition of the 'TODO' comment (the execution of which requires code
modifications and thus doesn't belong in this commit).
Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-08-19 07:24:38 +02:00
Giel van Schijndel
82dc6426b4
Move func 'REF' from util.h to serialize.h
...
util.h doesn't use REF, serialize.h does, creating a dependency of
serialize.h on util.h, but util.h already depends on serialize.h. To
resolve this circular dependency the function 'REF' has now been moved
closer to one of its two points of use.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-08-19 07:24:38 +02:00
Giel van Schijndel
e49b83bb12
Cleanup makefiles such that diffs to them are smaller
...
Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-08-19 07:24:37 +02:00
Giel van Schijndel
99860de3c9
Make some global variables less-global (static)
...
Explicitly make these global variables less-global to reduce the maximum
scope of this global state.
In my experience global variables tend to be a major source of bugs. As
such the less accessible they are the less likely they are to be the
source of a bug.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
2011-08-19 07:24:37 +02:00
Gavin Andresen
865ed8a1e5
Compile with DEBUG_LOCKORDER to detect inconsistent lock orderings that can cause deadlocks
2011-08-17 10:22:28 -04:00
Michal Zima
dac48972d5
Updated czech translation
2011-08-17 11:45:13 +02:00
Wladimir J. van der Laan
872b1f3e4c
update README for issue #15
2011-08-16 17:37:01 +02:00
Wladimir J. van der Laan
317c733572
add russian translation by msva
2011-08-16 17:30:58 +02:00
Gavin Andresen
c7286112ef
Remove unused ScanMessageStart function
2011-08-16 11:20:56 -04:00
Jeff Garzik
b2fd0ca1cb
src/makefile.unix: remove -DFOURWAYSSE2
...
Spotted by Venkatesh Srinivas <me@endeavour.zapto.org>
2011-08-16 10:10:39 -04:00
Wladimir J. van der Laan
8c4738d5a7
fix issue #13
2011-08-16 11:18:27 +02:00
Wladimir J. van der Laan
b90c9ecb13
Merge branch 'master' of https://github.com/bitcoin/bitcoin
2011-08-16 10:28:24 +02:00
Fabian H jr.
d0d9486f44
Updated checkpoints, maybe Tx fee should be reduced to 0.0001 from 0.0005 and maximum minimum tx should be 0.0010.
2011-08-15 21:33:00 -03:00
Gavin Andresen
eb72eae304
Don't std::advance past beginning of transactions array. Fixes #465
2011-08-12 15:39:12 -04:00
Matt Corallo
59ed5cb398
Add specific wallet encryption details to doc/README
2011-08-11 19:41:21 +02:00
Matt Corallo
8acb491eef
Fix incorrect RPC error messages
2011-08-11 19:41:21 +02:00
Matt Corallo
2f8f51d1e4
Missed a 'password' should be 'passphrase'.
2011-08-11 19:41:21 +02:00
Gavin Andresen
498a2c9b16
Merge pull request #458 from TheBlueMatt/copyright
...
Unify copyright notices.
2011-08-11 10:34:29 -07:00
Wladimir J. van der Laan
0a76546ae9
Merge branch 'master' of https://github.com/bitcoin/bitcoin
2011-08-11 10:17:21 +02:00
Gavin Andresen
c648b589be
Merge pull request #459 from jgarzik/char-msgstart
...
Use 'unsigned char' rather than 'char' for pchMessageStart.
2011-08-10 20:01:37 -07:00
Gavin Andresen
72173ffaca
Merge pull request #460 from jgarzik/make-tuple
...
Qualify make_tuple with boost:: namespace.
2011-08-10 20:01:14 -07:00
Venkatesh Srinivas
25133bd74b
Use 'unsigned char' rather than 'char' for pchMessageStart.
...
Regarding https://bitcointalk.org/index.php?topic=28022.0
main.cpp has: "char pchMessageStart[4] = { 0xf9, 0xbe, 0xb4, 0xd9 };"
Per discussion on the thread linked, leaving the signedness of
pchMessageStart is unsafe for values > 0x80. This patch specifies
'unsigned char' in main.cpp and net.h.
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
2011-08-10 22:42:43 -04:00
Venkatesh Srinivas
7c3002bf27
Qualify make_tuple with boost:: namespace.
...
db.cpp has a number of uses of make_tuple and has 'using namespace
std' and 'using namespace boost'. Without qualifying make_tuple,
std::make_tuple is preferred, which is incorrect. This patch qualifies
make_tuple.
Signed-off-by: Jeff Garzik <jgarzik@exmulti.com>
2011-08-10 22:40:10 -04:00
Venkatesh Srinivas
ec93a0e219
Test for SO_NOSIGPIPE rather than assuming all BSDs support it.
...
Signed-off-by: Jeff Garzik <jgarzik@exmulti.com>
2011-08-10 22:36:20 -04:00
Gavin Andresen
9f0ac16942
Do-nothing MapPort() ifndef USE_UPNP. fixes #450
2011-08-09 12:38:17 -04:00
Matt Corallo
b2120e223a
Unify copyright notices.
...
To a variation on:
// Copyright (c) 2009-2010 Satoshi Nakamoto
// Copyright (c) 2011 The Bitcoin developers
2011-08-09 13:32:52 +02:00
Matt Corallo
2c3691d53d
Cleanup test suite output to be more useful.
2011-08-08 14:31:08 -04:00
Matt Corallo
3c8cecda1f
Add file for transaction tests.
2011-08-08 14:31:08 -04:00
Vegard Nossum
a8330e0049
Add a file for script tests
2011-08-08 14:31:08 -04:00
Vegard Nossum
5f6a654d3e
Add prototype for EvalScript() to script.h
...
This is needed for the script unit tests.
2011-08-08 14:31:08 -04:00
Vegard Nossum
e707d29dd6
Fix testing setup
...
There were some problems with the existing testing setup:
- Makefile rules for test-file compilation used CFLAGS instead of
CXXFLAGS in makefile.unix
2011-08-08 14:31:08 -04:00
Matt Corallo
02962ba848
Add missing include to serialize.h
2011-08-08 14:31:08 -04:00
Vegard Nossum
8a62fec3ee
Add missing includes to net.h
2011-08-08 14:31:08 -04:00
Vegard Nossum
437173f430
Add missing include to script.h
2011-08-08 14:31:08 -04:00
Vegard Nossum
fcedd45c3c
Add missing includes to key.h
2011-08-08 14:31:07 -04:00
Gavin Andresen
4e5d88ce26
Merge pull request #443 from TheBlueMatt/dupin
...
Check for duplicate txins in CheckTransaction.
2011-08-08 11:16:40 -07:00
Wladimir J. van der Laan
b0849613bf
QtUI code cleanup / comment improvements
2011-08-08 17:38:17 +02:00
Wladimir J. van der Laan
fb390d3505
add TODOs in parseBitcoinURL
2011-08-07 17:07:04 +02:00
Wladimir J. van der Laan
f839f96578
update readme
2011-08-07 16:21:09 +02:00
Wladimir J. van der Laan
c359ac9128
allow empty/missing amounts in URL
2011-08-07 16:17:02 +02:00
Wladimir J. van der Laan
856aacf388
don't include <QDebug>
2011-08-07 16:09:49 +02:00
Wladimir J. van der Laan
db7f023417
Accept "bitcoin:" URL drops from browsers
2011-08-07 16:04:48 +02:00
Wladimir J. van der Laan
330c190958
Merge branch 'master' of https://github.com/bitcoin/bitcoin
2011-08-06 18:45:15 +02:00
Wladimir J. van der Laan
e74e8a184a
reorganize transaction model data function, and transaction tooltip
2011-08-06 18:40:45 +02:00
Wladimir J. van der Laan
d4e3cb4c03
improve sync spinner
2011-08-05 20:32:26 +02:00
Wladimir J. van der Laan
00f4f8d54c
speling fix
2011-08-05 15:37:49 +02:00
Wladimir J. van der Laan
126185aaa7
improve tooltip over transactions
2011-08-05 15:35:52 +02:00
Wladimir J. van der Laan
ffccb56914
select new address immediately after creation
2011-08-04 21:36:14 +02:00
Jeff Garzik
bd1e54bc0b
Merge branch 'tmp2'
2011-08-04 15:22:05 -04:00
Jeff Garzik
eb20f3c8f5
Merge pull request #448 from sipa/cbitcoinaddress
...
avoid strAddress + validity checks
2011-08-04 11:47:15 -07:00