Anthony Fieroni
4a6b3b7bf2
Adjust fuctional tests
...
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
2020-03-26 15:40:44 +02:00
MarcoFalke
0050a7e979
qa: Avoid race in p2p_invalid_block by waiting for the block request
...
Github-Pull: #14700
Rebased-From: fa21568208
2020-03-26 15:39:50 +02:00
MarcoFalke
70998ac794
qa: Run all tests even if wallet is not compiled
...
Github-Pull: #14180
Rebased-From: fac9539836
2020-03-26 15:39:50 +02:00
Suhas Daftuar
826219f99c
[qa] backport: Test for duplicate inputs within a transaction
2020-03-26 15:39:50 +02:00
lucash-dev
0c62e3aa73
New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137.
...
CVE-2018-17144 and CVE-2012-2459 are only partially tested for regression.
- CVE-2018-17144 is not tested for the inflation bug.
- CVE-2012-2459 is only tested for the mutated block being rejected, not
for the original block being accepted afterwards.
This commit fixes that limitation.
Also added functional test for CVE-2010-5137.
2019-06-02 10:25:03 -07:00
lucash-dev
38bfca6bb2
Added comments referencing multiple CVEs in tests and production code.
...
This commit adds comments referencing multiple CVEs both in production and test code.
CVEs covered in this commit:
CVE-2010-5137
CVE-2010-5139
CVE-2010-5141
CVE-2012-1909
CVE-2012-2459
CVE-2012-3789
CVE-2018-17144
2019-06-02 10:25:03 -07:00
MarcoFalke
fa21568208
qa: Avoid race in p2p_invalid_block by waiting for the block request
2018-11-09 15:46:58 -05:00
Suhas Daftuar
9b4a36effc
[qa] Test for duplicate inputs within a transaction
2018-09-17 15:52:01 -04:00
sanket1729
0ca4c8b3c6
Changed functional tests which do not require wallets to run without
...
skipping .Addreses #14216 . Changed get_deterministic_priv_key() to a
named tuple
2018-09-17 08:25:10 -05:00
Wladimir J. van der Laan
288ddf4ff5
Merge #14180 : qa: Run all tests even if wallet is not compiled
...
fac9539836
qa: Run all tests even if wallet is not compiled (MarcoFalke)
faa669cbcd
qa: Premine to deterministic address with -disablewallet (MarcoFalke)
Pull request description:
Currently the test_runner would exit if the wallet was not compiled into the Bitcoin Core executable. However, a lot of the tests run without the wallet just fine and there is no need to globally require the wallet to run the tests.
Tree-SHA512: 63177260aa29126fd20f0be217a82b10b62288ab846f96f1cbcc3bd2c52702437703475d91eae3f8d821a3149fc62b725a4c5b2a7b3657b67ffcbc81532a03bb
2018-09-13 13:06:07 +02:00
MarcoFalke
fac9539836
qa: Run all tests even if wallet is not compiled
2018-09-10 17:53:21 -04:00
MarcoFalke
fac3e22b18
qa: Read reject reasons from debug log, not p2p messages
2018-08-31 10:27:19 -04:00
MarcoFalke
fa782a308d
qa: Use named args in some tests
2018-08-29 13:06:02 -04:00
MarcoFalke
f66e1c793e
Merge #13669 : Tests: Cleanup create_transaction implementations
...
44bbceeef1
[Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object (Conor Scott)
736f941424
[Tests] Cleanup extra instances of create_transaction (Conor Scott)
157651855f
[Tests] Rename create_tx and move to blocktools.py (Conor Scott)
Pull request description:
There currently exist seven ([1](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_cltv.py#L52-L60 ), [2](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_csv_activation.py#L88-L95 ) [3](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_dersig.py#L40-L48 ), [4](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_nulldummy.py#L100-L108 ), [5](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L529-L535 ), [6](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/blocktools.py#L120-L129 ), [7](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_block.py#L1218-L1220 )) implementations of a function called something similar to `create_transaction` in the functional tests, some of which are exact copies of each other.
This PR aims to clean this up into [three different cases implemented in blocktools.py](https://github.com/conscott/bitcoin/blob/create_tx_cleanup/test/functional/test_framework/blocktools.py#L121-L149 )
1. `create_tx_with_script`: Return transaction object spending generic tx output optionally specifying scriptSig and scriptPubKey
2. `create_transaction`: Return transaction object spending coinbase tx
2. `create_raw_transaction`: Return raw transaction (hex string) spending coinbase tx
I am not committed to any of these function names, so I'll gladly take suggestions on there.
Additionally there are some related cleanups to feature_block.py tests, specifically removing the [PreviousSpendableOutput](https://github.com/conscott/bitcoin/blob/master/test/functional/feature_block.py#L51-L54 ) object, which seems like an unnecessary layer given that every instance spends the 0 output.
Tree-SHA512: 63c6233b6f0942c81ba1ca67ea6770809b8c9409314c6d4cf8e5a3991cb9ee92b22bebe88c0dde45cd71e754eb351230c4c404b70ff118f5f43c034452ada65c
2018-08-09 12:09:37 -04:00
MarcoFalke
8ac7125d59
Merge #13916 : qa: wait_for_verack by default
...
fa5587fe71
qa: wait_for_verack by default (MarcoFalke)
Pull request description:
This removes the need to do so manually every time a connection is added.
Tree-SHA512: a46c92cb4df41e30778b42b9fd3dcbd8d2d82aa7503d1213cb1c1165034f648d8caee01c292e2d87d05b0f71696996eef5be8a753f35ab49e5f66b0e3bf29f21
2018-08-09 08:07:28 -04:00
Conor Scott
736f941424
[Tests] Cleanup extra instances of create_transaction
2018-08-09 12:58:36 +02:00
MarcoFalke
fa5587fe71
qa: wait_for_verack by default
2018-08-08 17:22:35 -04:00
DrahtBot
eb7daf4d60
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
MarcoFalke
fa87da2f17
qa: Avoid start/stop of the network thread mid-test
2018-06-25 14:06:41 -04:00
John Newbery
e97b113b04
[tests] Change invalidblockrequest to use BitcoinTestFramework
...
[tests] update tests from changes to mininode in #11771 - added by @conscott
[tests] trivial update to hex conversion for readability - added by @conscott
2018-02-13 19:04:35 -05:00
John Newbery
2b7064eda7
[tests] Fix flake8 warnings in invalidblockrequest
2018-02-13 19:04:35 -05:00
Anthony Towns
61b8f7f273
[tests] Rename p2p_* functional tests.
2018-01-25 09:44:29 +10:00