LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity
13072 commits 22 branches 42 tags 99 MiB
Commit graph

13072 commits

This branch
This branch
All branches
Author SHA1 Message Date
practicalswift
343ba8fef5 [wallet] Remove redundant initialization 
Prior to this commit pindexRescan was initialized to a chainActive.Tip().
However, the value of pindexRescan set at time of initialization was never
read before pindexRescan was being set to either chainActive.Genesis()
(case 1), FindForkInGlobalIndex(chainActive, locator) (case 2) or
chainActive.Genesis() (case 3). Thus, the initialization was redundant.

This commit a.) removes the redundant initialization and b.) simplifies
this logic so that pindexRescan is initialized to chainActive.Genesis()
(case 1 and 3), and set to FindForkInGlobalIndex(chainActive, locator)
(case 2) as needed.
 2017-02-28 16:54:43 +01:00
Wladimir J. van der Laan
7e2a2212ec
Merge #9829: Fix importmulti returning rescan errors for wrong keys 
306bd72 Fix importmulti returning rescan errors for wrong keys (Russell Yanofsky)

Tree-SHA512: ae9998236cbd3ff749d6b5c716bd76c9cec386b0708583e4912e4e05bf4584545258e1d0543aa5445024d2b5decf859a64f40c6503029773366a0f9a9ddf9b88
 2017-02-28 13:52:50 +01:00
Wladimir J. van der Laan
b7547fa93e
Merge #9822: Remove block file location upgrade code 
4b183d3 Remove block file location upgrade code (Marko Bencun)

Tree-SHA512: fac1fce95341e0df645c08c7e794195b22b54df08826aa8728f2f97aede1e42f724f8133781b97f836d4a392d044d08c846bce471a6b478582014f8be501a712
 2017-02-28 12:31:33 +01:00
Wladimir J. van der Laan
c322fa472e
Merge #9732: [Trivial] Remove nonsense #undef foreach 
467df39 Remove nonsense #undef foreach (John Newbery)

Tree-SHA512: b8c3c6654eb8a9e5008a1923bee46f7ef9f8216c8f4f1b4662d82c26410ca8d8afe41e24e48a3e2e8b2a25c81c33795a4073dabfe357caf0aa820519d4fffc71
 2017-02-28 12:29:43 +01:00
Wladimir J. van der Laan
f5ef8e9dd2
Merge #9867: Replace remaining sprintf with snprintf 
19cafc6 test: Replace remaining sprintf with snprintf (Wladimir J. van der Laan)
0a17714 uint256: replace sprintf with HexStr and reverse-iterator (Wladimir J. van der Laan)

Tree-SHA512: 2ba1dd4d25e1cbfff4d67b2f483448aa7c34ab5c799cddd48ba5826e5fa6df425abe35e244aaf4c52db9fccfb4d2a25a14bb4597bf9d1fce95991f270da6bb26
 2017-02-28 12:02:44 +01:00
Wladimir J. van der Laan
30bdcfca2b
Merge #9865: Change bitcoin address in RPC help message 
83ac719 Change bitcoin address in RPC helpaddress to an invalid address, so people don't accidentally send coins there (like I did). (Marijn Stollenga)

Tree-SHA512: ca1163466a149d567b97efbfcfa8fdfe2d474245b4dd5a1a92555b4e87f8e99df5fee4cd79ef1ce6a98db2337846af78f37c2e6b31d02008b11fa0e151ce6590
 2017-02-28 11:59:34 +01:00
Wladimir J. van der Laan
d75e8cb44d
Merge #9879: [doc] Update doc/bips.md for BIP90 implementation 
fe71661 [doc] Update doc/bips.md for BIP90 implementation (Suhas Daftuar)

Tree-SHA512: cfa72662e5e8ecedb7869b64c2064cc29d8736bcd9baacd59ea420dc2f93265c8d950e469863e77e8fa9348fbf1b39a1e2397253a2fd94b63adc909cc8c14873
 2017-02-28 11:44:11 +01:00
Wladimir J. van der Laan
65fdc37ac3
Merge #9856: Terminate immediately when allocation fails 
d4ee7ba prevector: assert successful allocation (Cory Fields)
c5f008a don't throw std::bad_alloc when out of memory. Instead, terminate immediately (Cory Fields)

Tree-SHA512: 699ce8df5b1775a99c71d3cfc952b45da1c0091e1a4b6adfac52d5be6144c3d98f88ac3af90e5c73fff2f74666a499feb4a34434683ce5979814e869c0aeddc3
 2017-02-28 11:37:36 +01:00
MarcoFalke
88c2ae3ed2
Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json 
988ce2d Adding 'amount' label to tx_valid/tx_invalid.json files (Chris Stewart)

Tree-SHA512: 11c216c6565ecaa5ff4eb6122f87d3b28f89db52d1e473c0678f61c240e133698adb05e717bfb9d3db36409dfb230b902dca4029a58633be36c9f85e0db3d973
 2017-02-27 22:33:55 +01:00
Cory Fields
d4ee7baef7 prevector: assert successful allocation 2017-02-27 14:52:15 -05:00
Suhas Daftuar
fe71661ae1 [doc] Update doc/bips.md for BIP90 implementation 2017-02-27 12:21:40 -05:00
Russell Yanofsky
306bd72157 Fix importmulti returning rescan errors for wrong keys 
Bug was a missing ++i line in a new range for loop added in commit e2e2f4c
"Return errors from importmulti if complete rescans are not successful"
 2017-02-27 07:38:51 -05:00
Wladimir J. van der Laan
94e5ba9ba2
Merge #9875: tests: Fix dangling pwalletMain pointer in wallet tests 
75a1093 tests: Fix dangling pwalletMain pointer in wallet tests (Wladimir J. van der Laan)

Tree-SHA512: 7fb6e8385fe7d542f9ecb113a08d675ca9e84907a1939b3a6ad41318fda55bc999b9bc8ffc3f56cd8610ca49d0db982d3c793df7bbcb7eb9638f4483030db6a8
 2017-02-27 13:38:51 +01:00
Wladimir J. van der Laan
75a109338f tests: Fix dangling pwalletMain pointer in wallet tests 2017-02-27 13:15:39 +01:00
Wladimir J. van der Laan
19cafc6239 test: Replace remaining sprintf with snprintf 
Use of `sprintf` is seen as a red flag as many of its uses are insecure.
OpenBSD warns about it while compiling, and some modern platforms, e.g.
[cloudlibc from cloudabi](https://github.com/NuxiNL/cloudlibc) don't
even provide it anymore.

Although our uses of these functions are secure, it can't hurt to
replace them anyway. There are only 3 occurences left, all in the
tests.
 2017-02-27 10:03:20 +01:00
Wladimir J. van der Laan
0a177148e7 uint256: replace sprintf with HexStr and reverse-iterator 
Instead of calling sprintf for every byte, format the hex bytes
ourselves by help of HexStr and a reverse_iterator.
 2017-02-27 10:02:45 +01:00
Wladimir J. van der Laan
c7e57ce981
Merge #9839: [qa] Make import-rescan.py watchonly check reliable 
864890a [qa] Make import-rescan.py watchonly check reliable (Russell Yanofsky)

Tree-SHA512: ea0e2b1d4fc8f35174c3d575fb751b428daf6ad3aa944fad4e3ddcc9195e4f17051473acabc54203b1d27cca64cf911b737ab92e986c40ef384410652e2dbea1
 2017-02-27 08:46:19 +01:00
Marijn Stollenga
83ac719d34 Change bitcoin address in RPC helpaddress to an invalid address, so people don't accidentally send coins there (like I did). 2017-02-26 14:01:05 +01:00
Wladimir J. van der Laan
6206252e50
Merge #9847: Extra test vector for BIP32 
30aedcb BIP32 extra test vector (Pieter Wuille)
 2017-02-25 10:43:29 +01:00
Cory Fields
c5f008a416 don't throw std::bad_alloc when out of memory. Instead, terminate immediately 2017-02-25 01:09:11 -05:00
Wladimir J. van der Laan
f19afdbfb4
Merge #9612: [trivial] Rephrase the definition of difficulty. 
dc222f8 Trivial: Rephrase the definition of difficulty in the code. (Karl-Johan Alm)
 2017-02-24 12:48:56 +01:00
Wladimir J. van der Laan
dd6e0d6301
Merge #9833: Trivial: fix comments referencing AppInit2 
ef9f495 Trivial: fix comments referencing AppInit2 (Marko Bencun)
 2017-02-24 10:53:32 +01:00
Wladimir J. van der Laan
00285cece8
Merge #9840: Update sendfrom RPC help to correct coin selection misconception 
f81f0d0 Update sendfrom RPC help to correct coin selection misconception (Russell Yanofsky)
 2017-02-24 10:22:04 +01:00
Karl-Johan Alm
dc222f8f63
Trivial: Rephrase the definition of difficulty in the code. 2017-02-23 22:06:37 -08:00
Pieter Wuille
30aedcbdb4 BIP32 extra test vector 2017-02-23 17:59:52 -08:00
Marko Bencun
ef9f495e93 Trivial: fix comments referencing AppInit2 
It was refactored into multiple functions in
0cc8b6bc44.
 2017-02-24 09:19:29 +09:00
Russell Yanofsky
864890adf5 [qa] Make import-rescan.py watchonly check reliable 
Send payments during the test from a different node than the node generating
keys to be imported, so the spending node doesn't create transactions that
inadvertently involve (spend funds from) the imported keys.

Fixes #9826
 2017-02-23 14:09:43 -05:00
Russell Yanofsky
f81f0d0030 Update sendfrom RPC help to correct coin selection misconception 2017-02-23 13:44:12 -05:00
Wladimir J. van der Laan
692c9eddba
Merge #9831: build: force a c++ standard to be specified 
9829c54 build: force a c++ standard to be specified (Cory Fields)
 2017-02-23 19:03:14 +01:00
MarcoFalke
a13a417cdc
Merge #9823: qa: Set correct path for binaries in rpc tests 
3333ad0 qa: Set correct path for binaries in rpc tests (MarcoFalke)
 2017-02-23 17:36:02 +01:00
MarcoFalke
d6064a89ac
Merge #9577: Fix docstrings in qa tests 
3f95a80 Fix docstrings in qa tests (John Newbery)
 2017-02-23 16:39:22 +01:00
MarcoFalke
7146d96de3
Merge #9766: Add --exclude option to rpc-tests.py 
c578408 Add exclude option to rpc-tests.py (John Newbery)
 2017-02-23 16:34:07 +01:00
John Newbery
3f95a806b1 Fix docstrings in qa tests 
This commit fixes the module-level docstrings for the tests and helper
modules in qa. Many of these tests were uncommented previously - this
commit ensures that every test case has at least a minimum level of
commenting.
 2017-02-23 10:31:04 -05:00
Wladimir J. van der Laan
e68c266f3d
Merge #9789: build: add --enable-werror and warn on vla's 
205830a build: add --enable-werror option (Cory Fields)
b602fe0 build: warn about variable length arrays (Cory Fields)
 2017-02-23 10:48:46 +01:00
Wladimir J. van der Laan
1d2a57e9fd
Merge #9824: qa: Check return code when stopping nodes 
fa4cd2e qa: Check return code when stopping nodes (MarcoFalke)
 2017-02-23 10:40:47 +01:00
Wladimir J. van der Laan
d14555de3d
Merge #9820: Fix pruning test broken by 2 hour manual prune window 
874c736 Fix pruning test broken by 2 hour manual prune window (Russell Yanofsky)
 2017-02-23 10:38:26 +01:00
Cory Fields
205830a37b build: add --enable-werror option 
This turns some compiler warnings into errors. Useful for c-i.
 2017-02-23 01:06:04 -05:00
MarcoFalke
fa4cd2e998 qa: Check return code when stopping nodes 
This includes work by jnewbery
 2017-02-23 03:05:43 +01:00
Cory Fields
9829c54de2 build: force a c++ standard to be specified 
Newer compilers may switch to newer standards by default. For example, gcc6
uses std=gnu++14 by default.
 2017-02-22 13:37:35 -05:00
Wladimir J. van der Laan
bed5b30a56
Merge #9711: [Trivial] Remove incorrect help message from gettxoutproof() 
9949ebf [Trivial] Remove incorrect help message from gettxoutproof() (John Newbery)
 2017-02-22 13:03:42 +01:00
Wladimir J. van der Laan
1efc99c4dc
Merge #9819: Remove harmless read of unusued priority estimates 
bc8fd12 Remove harmless read of unusued priority estimates (Alex Morcos)
 2017-02-22 13:02:10 +01:00
Wladimir J. van der Laan
ba7220b5e8
Merge #9773: Return errors from importmulti if complete rescans are not successful 
e2e2f4c Return errors from importmulti if complete rescans are not successful (Russell Yanofsky)
 2017-02-22 12:43:11 +01:00
Marko Bencun
4b183d33f3 Remove block file location upgrade code 
An effort to reduce the size of AppInitMain().

The removed code upgrades the location of the block files when
upgrading to 0.8. 0.8 seems to be the oldest version still in use.
 2017-02-22 20:32:47 +09:00
Wladimir J. van der Laan
a8c5751038
Merge #9801: Removed redundant parameter from mempool.PrioritiseTransaction 
eaea2bb Removed redundant parameter from mempool.PrioritiseTransaction (gubatron)
 2017-02-22 12:18:38 +01:00
Wladimir J. van der Laan
5b583efaa7
Merge #9805: Add seed.btc.petertodd.org to mainnet DNS seeds 
3b4dd2a Add seed.btc.petertodd.org to mainnet DNS seeds (Peter Todd)
 2017-02-22 12:14:37 +01:00
Wladimir J. van der Laan
92dd6c8dfd
Merge #9815: Trivial: use EXIT_ codes instead of magic numbers 
a87d02a use EXIT_ codes instead of magic numbers (Marko Bencun)
 2017-02-22 11:48:45 +01:00
MarcoFalke
3333ad0b63 qa: Set correct path for binaries in rpc tests 2017-02-22 10:49:02 +01:00
gubatron
eaea2bbb41 Removed redundant parameter from mempool.PrioritiseTransaction 
(Also made the `const uint256 hash` parameter a `const uint256& hash` as suggested by @sdaftuar)
 2017-02-21 20:44:23 -07:00
MarcoFalke
5628c70f2a
Merge #9807: RPC doc fix-ups. 
851f6a3 [qa][doc] Correct rpc test options in readme (fanquake)
41e7219 [trivial] Add tests_config.ini to .gitignore (fanquake)
 2017-02-22 00:05:22 +01:00
Russell Yanofsky
874c7363d7 Fix pruning test broken by 2 hour manual prune window 
Regression happened in 91fb506 Add two hour buffer to manual pruning.
 2017-02-21 12:57:30 -05:00