Peter Todd
28bf06236d
Fix off-by-one error w/ nLockTime in the wallet
...
Previously due to an off-by-one error the wallet ignored
nLockTime-by-height transactions that would be valid in the next block
even though they are accepted into the mempool. The transactions
wouldn't show up until confirmed, nor would they be included in the
unconfirmed balance. Similar to the mempool behavior fix in 665bdd3b
,
the wallet code was calling IsFinalTx() directly without taking into
account the fact that doing so tells you if the transaction could have
been mined in the *current* block, rather than the next block.
To fix this we strip IsFinalTx() of non-consensus-critical
functionality, removing the default arguments, and add CheckFinalTx() to
check if a transaction will be final in the next block.
2015-05-27 05:51:33 -04:00
Wladimir J. van der Laan
68aff60e4a
Merge pull request #6190
...
1fe4c4f
gitian-downloader: Update luke-jr's key (Luke Dashjr)
2015-05-27 11:51:00 +02:00
Jonas Schnelli
64b8027c5c
rest.cpp: strip whitespace
2015-05-27 09:41:14 +02:00
Wladimir J. van der Laan
0bcf04f046
Merge pull request #6153
...
8c35b6f
Parameter interaction: disable upnp if -proxy set (Wladimir J. van der Laan)
2015-05-27 09:33:01 +02:00
Wladimir J. van der Laan
df992b9c18
Merge pull request #6174
...
213f257
doc: add translation strings policy (Wladimir J. van der Laan)
2015-05-27 09:31:26 +02:00
Wladimir J. van der Laan
182686cdbd
Merge pull request #6186
...
b45c50c
Fix two problems in CSubNet parsing (Wladimir J. van der Laan)
19e8d7b
Simplify code for CSubnet (Wladimir J. van der Laan)
2015-05-27 09:08:39 +02:00
Luke Dashjr
1fe4c4fcff
gitian-downloader: Update luke-jr's key
2015-05-26 20:47:31 +00:00
mrbandrews
44e1aad500
Autoprune release notes included
2015-05-26 15:56:17 -04:00
Wladimir J. van der Laan
165e323d85
qt: Periodic translation update
2015-05-26 14:36:47 +02:00
Wladimir J. van der Laan
e3ed6a9785
doc: Add preliminary changelog for 0.11 to release notes
2015-05-26 14:35:48 +02:00
Wladimir J. van der Laan
9f7809f6c3
Merge pull request #5976
...
8ba7f84
Reduce download timeouts as blocks arrive (Suhas Daftuar)
2015-05-26 13:02:40 +02:00
Wladimir J. van der Laan
847be04449
Merge pull request #6187
...
8697ff3
Remove duplicate chainparams.h include from alert_tests (Michael Ford)
2015-05-26 12:02:36 +02:00
Michael Ford
8697ff33ed
Remove duplicate chainparams.h include from alert_tests
2015-05-26 17:16:21 +08:00
Wladimir J. van der Laan
e9af4e65b5
Merge pull request #5947
...
36cba8f
Alert if it is very likely we are getting a bad chain (Gavin Andresen)
2015-05-26 10:41:17 +02:00
Wladimir J. van der Laan
b45c50ce51
Fix two problems in CSubNet parsing
...
Fix two CSubNet constructor problems:
- The use of `/x` where 8 does not divide x was broken, due to a
bit-order issue
- The use of e.g. `1.2.3.4/24` where the netmasked bits in the network
are not 0 was broken. Fix this by explicitly normalizing the netwok
according to the bitmask.
Also add tests for these cases.
Fixes #6179 . Thanks to @jonasschnelli for reporting and initial fix.
2015-05-26 08:59:59 +02:00
Wladimir J. van der Laan
19e8d7be42
Simplify code for CSubnet
...
Simplify the code by using CAddress.ip directly, instead of the reversed
GetByte() semantics.
2015-05-26 08:59:13 +02:00
Wladimir J. van der Laan
e1412d3e96
Merge pull request #6159
...
ffdda4e
Catch errors on datadir lock and pidfile delete (Adam Weiss)
2015-05-24 10:57:22 +02:00
Wladimir J. van der Laan
2d84241d26
doc: Add historical release notes 0.9.5
2015-05-24 09:49:18 +02:00
Wladimir J. van der Laan
213f257a03
doc: add translation strings policy
2015-05-23 11:30:27 +02:00
Adam Weiss
ffdda4e8a7
Catch errors on datadir lock and pidfile delete
...
Prevents bad permissions (or other fs related problems) from resulting
in hard crashes with cryptic messages on startup and shutdown.
2015-05-22 14:15:22 -04:00
Wladimir J. van der Laan
7708fcde36
Merge pull request #6098
...
cc24610
Update Windows resource files (and add one for bitcoin-tx) (Luke Dashjr)
2015-05-22 08:35:38 +02:00
Wladimir J. van der Laan
b3024f077b
Merge pull request #6168
...
7f68c7d
contrib/linearize: Support linearization of testnet blocks (Jeff Garzik)
2015-05-22 08:17:08 +02:00
Luke Dashjr
cc24610fdb
Update Windows resource files (and add one for bitcoin-tx)
2015-05-22 02:56:55 +00:00
Wladimir J. van der Laan
4bf83b27b2
Merge pull request #6171
...
bdcf5de
Fix intermittent hang issue in scheduler_tests (Wladimir J. van der Laan)
2015-05-21 22:00:07 +02:00
Jonas Schnelli
7b7f258396
rpc-tests: remove python-bitcoinrpc directory
...
place authproxy.py at same level as other utility classes
2015-05-21 21:22:22 +02:00
Jimmy Kiselak
71a28f8d8f
store ncc trie insertion queues on disk, so that eventually removal queues can be stored on disk the same way
2015-05-21 13:50:40 -04:00
Wladimir J. van der Laan
bdcf5dea7c
Fix intermittent hang issue in scheduler_tests
...
Don't clear `stopRequested` and `stopWhenEmpty` at the top of
`serviceQueue`, as this results in a race condition: on systems under
heavy load, some of the threads only get scheduled on the CPU when the
other threads have already finished their work. This causes the flags to
be cleared post-hoc and thus those threads to wait forever.
The potential drawback of this change is that the scheduler cannot be
restarted after being stopped (an explicit reset would be needed), but
we don't use this functionality anyway.
2015-05-21 19:07:10 +02:00
Jeff Garzik
7f68c7dc05
contrib/linearize: Support linearization of testnet blocks
2015-05-20 15:27:51 -07:00
Jimmy Kiselak
6bca5ead23
merge in changes from upstream
2015-05-20 10:26:14 -04:00
Wladimir J. van der Laan
0d862c2739
Merge pull request #6160
...
16d9cb7
[QT] overviewpage: make sure warning icons gets colored (Jonas Schnelli)
2015-05-20 13:21:01 +02:00
Wladimir J. van der Laan
180c164e4f
Merge pull request #6161
...
fb21862
[QT] mainwindow toolbar must not be movable (Jonas Schnelli)
2015-05-20 13:19:42 +02:00
Wladimir J. van der Laan
30dc3c1b38
Merge pull request #6116
...
d1a3866
build: Cope with spaces in filenames when creating/applying OSX sigs (Cory Fields)
7cef321
[Mac only] rename Bitcoin-Qt.app to "Bitcoin Core.app" (Jonas Schnelli)
2015-05-20 13:08:51 +02:00
lpescher
aa41bc84b1
Update help message to match the #4219 change
2015-05-19 22:35:11 -06:00
lpescher
f60bb5ee6d
Update documentation to match the #4219 change
2015-05-19 22:29:59 -06:00
lpescher
cb87386241
Make command line option to show all debugging consistent with similar options
...
Most people expect a value of 1 to enable all for command line arguments.
However to do this for the -debug option you must type "-debug=".
This has been changed to allow "-debug=1" as well as "-debug=" to
enable all debug logging
2015-05-19 22:14:35 -06:00
Jonas Schnelli
fb21862b92
[QT] mainwindow toolbar must not be movable
2015-05-19 20:28:20 +02:00
Jonas Schnelli
a85b2e221b
pull-tester/rpc-tests.sh: disable script_test.py test
2015-05-19 16:41:17 +02:00
Jonas Schnelli
16d9cb7e29
[QT] overviewpage: make sure warning icons gets colored
2015-05-19 16:37:13 +02:00
Wladimir J. van der Laan
377711ff3f
Merge pull request #5996
...
935bd0a
Chainparams: Refactor: Decouple main::GetBlockValue() from Params() [renamed GetBlockSubsidy] (Jorge Timón)
2015-05-19 11:42:47 +02:00
Wladimir J. van der Laan
e2e7f9513f
qt: fix unused function warning in scicon.cpp
...
Enclose MakeSingleColorImage in an anonymous namespace to avoid a
unused function warning on Windows and MacOSX.
Github-Pull: #6143
2015-05-19 11:27:54 +02:00
Cory Fields
d1a3866e0b
build: Cope with spaces in filenames when creating/applying OSX sigs
2015-05-19 11:03:54 +02:00
Jonas Schnelli
7cef321e65
[Mac only] rename Bitcoin-Qt.app to "Bitcoin Core.app"
2015-05-19 11:03:49 +02:00
Wladimir J. van der Laan
be31ff7d8d
doc: Add historical release notes for 0.10.1 0.10.2 0.9.4
2015-05-18 20:48:09 +02:00
Wladimir J. van der Laan
a5a521e842
Merge pull request #6154
...
b448002
[Docs] fix and improve REST documentation (Jonas Schnelli)
2015-05-18 20:18:52 +02:00
Jonas Schnelli
b448002772
[Docs] fix and improve REST documentation
...
- fix bad formatting of getutxos
- added getztxos example
- fix different command syntax
2015-05-18 16:52:01 +02:00
Jonas Schnelli
3e875b1bef
pull-tester/rpc-tests.sh: allow passing throug of arguments
2015-05-18 15:29:20 +02:00
Jonas Schnelli
00706a5436
update rpc-tests readme.md
2015-05-18 15:25:45 +02:00
Jonas Schnelli
344e08ed16
extend rpc-tests.sh control script with non-travis tests
2015-05-18 15:25:45 +02:00
Jonas Schnelli
64937fe51a
[QA] restructure rpc tests directory
...
* move non-test classes to subdir `test-framework`
2015-05-18 15:25:45 +02:00
Wladimir J. van der Laan
8c35b6f3be
Parameter interaction: disable upnp if -proxy set
...
To protect privacy, do not use UPNP when a proxy is set. The user may
still specify -listen=1 to listen locally (for a hidden service), so
don't rely on this happening through -listen.
Fixes #2927 .
2015-05-18 11:22:39 +02:00