Jonas Schnelli
7d5e31a82b
[Qt] remove trailing output-index from transaction-id
...
The trailing output-index leads to cases where the user can't look-up the transaction ID in various systems.
2016-03-29 11:23:44 +02:00
Wladimir J. van der Laan
b35a591793
Merge #7558 : [RPC] Add import/removeprunedfunds rpc call
...
f1bb13c7eb7029
2016-03-29 11:15:02 +02:00
Wladimir J. van der Laan
2676e12016
Merge #7742 : [Wallet][RPC] add missing abandon status documentation
...
cef8bdf
2016-03-29 11:10:57 +02:00
Jonas Schnelli
cef8bdf5d7
[Wallet][RPC] add missing abandon status documentation
2016-03-29 08:43:08 +02:00
Wladimir J. van der Laan
0b98dd7939
Merge #7732 : [Qt] Debug window: replace "Build date" with "Datadir"
...
fc737d14856f1d
2016-03-25 11:21:53 +01:00
Jonas Schnelli
fc737d127f
[Qt] remove unused formatBuildDate method
2016-03-24 21:48:45 +01:00
Wladimir J. van der Laan
b88e0b0c61
Merge #7506 : Use CCoinControl selection in CWallet::FundTransaction
...
d6cc6a1
2016-03-24 14:59:51 +01:00
João Barbosa
df9e9233dc
Fix lockunspents help message
2016-03-23 15:44:41 +00:00
Jonas Schnelli
263de3d1c8
[Wallet][RPC] add abandoned status to listtransactions
2016-03-23 15:49:53 +01:00
instagibbs
f1bb13c93d
Added companion removeprunedfunds call.
2016-03-23 10:40:38 -04:00
instagibbs
7eb702954e
Add importprunedfunds rpc call
2016-03-23 10:40:38 -04:00
Wladimir J. van der Laan
3bdc583b3f
Merge #7715 : Fix calculation of balances and available coins.
...
68d4282
2016-03-23 15:09:02 +01:00
Wladimir J. van der Laan
e2ebd259fb
Merge #7671 : [RPC] Add generatetoaddress rpc to mine to an address
...
d5c5c71fe00ca7
2016-03-23 13:24:53 +01:00
João Barbosa
bb16c8894b
Prevent multiple calls to CWallet::AvailableCoins
2016-03-22 08:43:37 +00:00
Jonas Schnelli
4856f1d671
[Qt] Debug window: replace "Build date" with "Datadir"
...
The build date does only makes sense for custom/self-compiled bitcoin-core versions because we are using static build-dates for our deterministic release builds.
Having a quick option to get the current datadir is much more valuable for debug purposes.
2016-03-22 08:40:10 +01:00
Jonas Schnelli
25340b7cd5
[Wallet] refactor wallet/init interaction
2016-03-22 08:20:59 +01:00
Alex Morcos
9e072a6e66
Implement "feefilter" P2P message.
...
The "feefilter" p2p message is used to inform other nodes of your mempool min fee which is the feerate that any new transaction must meet to be accepted to your mempool. This will allow them to filter invs to you according to this feerate.
2016-03-21 10:46:25 -04:00
Andrew C
fe00ca758a
Create generatetoaddress rpc
...
Creates the generatetoaddress rpc which is virtually identical to the generate rpc except that it takes an argument for the address to mine to. It does not rely on wallet functionality.
The mining code shared by generate and generatetoaddress has been moved to another method to reduce duplication.
2016-03-21 09:58:40 -04:00
Wladimir J. van der Laan
29b2be6ad7
Merge #7692 : Remove p2p alert system
...
cfd519e6601ce5ad721041b7747101fdfef9206634bbb9d1d
2016-03-21 13:41:05 +01:00
Wladimir J. van der Laan
9af69fa7e7
Merge #7726 : Correct importaddress help reference to importpubkey
...
c5825d2
2016-03-21 12:51:32 +01:00
Wladimir J. van der Laan
3c27067dd2
Merge #7712 : Improve COutPoint less operator
...
0f17692
2016-03-21 12:50:47 +01:00
Wladimir J. van der Laan
9426632cb5
Merge #7708 : De-neuter NODE_BLOOM
...
c90036f
2016-03-21 12:44:19 +01:00
Wladimir J. van der Laan
ddfd79659e
Merge #7705 : [amount] Add tests and make GetFee() monotonic
...
fad13b1faf756afab6880
2016-03-21 12:40:31 +01:00
Wladimir J. van der Laan
7b832d286b
Merge #7656 : Improve EncodeBase58 performance
...
3252208
2016-03-21 12:03:59 +01:00
Denis Lukianov
c5825d2d73
Correct importaddress help reference to importpubkey
2016-03-21 03:16:19 +00:00
MarcoFalke
fad13b1612
[amount] Preempt issues with negative fee rates
2016-03-19 15:15:56 +01:00
Patrick Strateman
c90036f664
Always disconnect old nodes which request filtered connections.
2016-03-18 21:26:49 -07:00
Thomas Kerin
6601ce508e
protocol.h/cpp: Removes NetMsgType::ALERT
2016-03-18 19:55:16 +00:00
BtcDrak
ad7210408c
Formatting
2016-03-18 19:55:16 +00:00
BtcDrak
1b77471bd6
Remove alert keys
2016-03-18 19:55:16 +00:00
BtcDrak
01fdfeffc4
Remove -alerts option
2016-03-18 19:33:59 +00:00
BtcDrak
92066344fd
Update alert notification and GUI
2016-03-18 19:33:59 +00:00
BtcDrak
bbb9d1d123
Remove p2p alert handling
2016-03-18 19:33:59 +00:00
Alex Morcos
68d4282774
Fix calculation of balances and available coins.
...
No longer consider coins which aren't in our mempool.
Add test for regression in abandonconflict.py
2016-03-18 09:56:30 -04:00
BtcDrak
12c89c9185
Policy: allow transaction version 2 relay policy.
...
This commit introduces a way to gracefully bump the default
transaction version in a two step process.
2016-03-18 08:09:06 +00:00
BtcDrak
02c2435802
Soft fork logic for BIP68
2016-03-18 08:09:06 +00:00
BtcDrak
478fba6d52
Soft fork logic for BIP113
2016-03-18 08:09:06 +00:00
Pieter Wuille
65751a3cf2
Add CHECKSEQUENCEVERIFY softfork through BIP9
2016-03-18 08:09:06 +00:00
João Barbosa
0f176927f8
Improve COutPoint less operator
2016-03-18 08:03:55 +00:00
Wladimir J. van der Laan
73b7eb501e
Merge #7575 : Minimal BIP9 implementation
...
8c74ced7870deb532cbb2d23f6c6732e7746851107
2016-03-18 08:50:43 +01:00
MarcoFalke
faf756ae4e
[amount] Make GetFee() monotonic
...
This reverts the hard-to-read and buggy code introduced in
d88af56011
2016-03-17 17:00:45 +01:00
MarcoFalke
fab6880494
[qa] Add amount tests
2016-03-17 16:59:37 +01:00
Wladimir J. van der Laan
f034bced26
Merge #7686 : [qt] Remove 0-fee from send dialog
...
fae8467fa48bb3
2016-03-17 16:21:56 +01:00
MarcoFalke
fae8467d41
[qt] Remove unneeded "fSendFreeTransactions" check
2016-03-17 14:48:12 +01:00
Wladimir J. van der Laan
01f4267623
Merge #7594 : Mempool: Add tracking of ancestor packages
...
ce019bfe2eeb5d72abd2c76a76325de2baa7659438
2016-03-17 13:33:54 +01:00
Wladimir J. van der Laan
14d6324a24
Merge #7187 : Keep reorgs fast for SequenceLocks checks
...
982670c
2016-03-16 21:20:04 +01:00
Alex Morcos
982670c333
Add LockPoints
...
Obtain LockPoints to store in CTxMemPoolEntry and during a reorg, evaluate whether they are still valid and if not, recalculate them.
2016-03-16 16:11:46 -04:00
Wladimir J. van der Laan
3d0dfdbf9f
Merge #7684 : [qa] Extend tests
...
fad8cfbfa8cd46fad7dc8fa3a81a
2016-03-16 17:32:05 +01:00
Suhas Daftuar
7870debceb
Test versionbits deployments
2016-03-15 16:54:39 +01:00
Suhas Daftuar
532cbb22b5
Add testing of ComputeBlockVersion
2016-03-15 16:54:39 +01:00
Pieter Wuille
d23f6c6a0d
Softfork status report in RPC
2016-03-15 16:54:38 +01:00
Pieter Wuille
732e774c06
Versionbits tests
2016-03-15 16:54:38 +01:00
Pieter Wuille
6851107b3a
BIP9 Implementation
...
Inspired by former implementations by Eric Lombrozo and Rusty Russell, and
based on code by Jorge Timon.
2016-03-15 16:54:38 +01:00
Wladimir J. van der Laan
a6a860796a
Merge #7621 : Fixes ZMQ startup with bad arguments.
...
0040118
2016-03-15 09:29:58 +01:00
Pieter Wuille
c3932b3270
List solvability in listunspent output and improve help
2016-03-14 19:22:11 +01:00
MarcoFalke
fa48bb3148
[qt] Remove 0-fee from send dialog
2016-03-14 18:32:09 +01:00
Suhas Daftuar
ce019bf90f
Check all ancestor state in CTxMemPool::check()
2016-03-14 12:13:34 -04:00
Suhas Daftuar
e2eeb5dda7
Add ancestor feerate index to mempool
2016-03-14 12:13:34 -04:00
Suhas Daftuar
72abd2ce3c
Add ancestor tracking to mempool
...
This implements caching of ancestor state to each mempool entry, similar to
descendant tracking, but also including caching sigops-with-ancestors (as that
metric will be helpful to future code that implements better transaction
selection in CreatenewBlock).
2016-03-14 12:13:33 -04:00
Suhas Daftuar
76a76321d2
Remove work limit in UpdateForDescendants()
...
The work limit served to prevent the descendant walking algorithm from doing
too much work by marking the parent transaction as dirty. However to implement
ancestor tracking, it's not possible to similarly mark those descendant
transactions as dirty without having to calculate them to begin with.
This commit removes the work limit altogether. With appropriate
chain limits (-limitdescendantcount) the concern about doing too much
work inside this function should be mitigated.
2016-03-14 12:13:31 -04:00
Suhas Daftuar
5de2baa138
Rename CTxMemPool::remove -> removeRecursive
...
remove is no longer called non-recursively, so simplify the logic
and eliminate an unnecessary parameter
2016-03-14 12:11:09 -04:00
Suhas Daftuar
7659438a63
CTxMemPool::removeForBlock now uses RemoveStaged
2016-03-14 12:11:08 -04:00
Jonas Schnelli
3d7e97376a
Fix torcontrol.cpp unused private field warning
2016-03-14 16:07:42 +01:00
MarcoFalke
fa3a81af18
[tests] Extend util_ParseMoney test case
2016-03-14 15:49:33 +01:00
Wladimir J. van der Laan
0735c0ca7c
Merge #7608 : [wallet] Move hardcoded file name out of log messages
...
fa19b18
2016-03-14 13:56:23 +01:00
MarcoFalke
fa19b18c63
[wallet] Move hardcoded file name out of log messages
2016-03-14 13:54:05 +01:00
Wladimir J. van der Laan
322a7a2fe0
qt: Remove reflection from about icon
...
While trying to find a black/white version of the Bitcoin
logo for the organization I noticed the about.png is not
entirely black - it has some reflection. Remove this to make
it the same as other icons.
Also ran the icons through `contrib/devtools/optimize-pngs.py`,
so `chevron.png` was optimized too.
2016-03-14 12:46:59 +01:00
Wladimir J. van der Laan
c9a1265754
Merge #7670 : use cached block hash in blockToJSON()
...
a6ee0ca
2016-03-14 12:22:40 +01:00
Wladimir J. van der Laan
c87f51e55b
Merge #7663 : Make the generate RPC call function for non-regtest
...
8a253b3
2016-03-14 11:36:20 +01:00
Wladimir J. van der Laan
11c769966a
Merge #7507 : Remove internal miner
...
8d1de43
2016-03-14 11:35:41 +01:00
Wladimir J. van der Laan
5b3b5a7d71
Merge #7577 : [Wallet] move "load wallet phase" to CWallet
...
15e6e13fc7c60d
2016-03-14 11:34:50 +01:00
Wladimir J. van der Laan
f1ca8915bb
Merge #7517 : test: script_error checking in script_invalid tests
...
0ecb3402317ad7b0ff857
2016-03-14 11:30:06 +01:00
Wladimir J. van der Laan
56d2c4e0fe
Merge #7667 : Move GetTempPath() to testutil
...
2fdaa25393b22e
2016-03-14 11:26:52 +01:00
Jonas Schnelli
15e6e13624
[Wallet] optimize return value of InitLoadWallet()
2016-03-14 09:33:27 +01:00
Jonas Schnelli
b24266c207
Merge #7668 : Fix history deletion bug after font size change
...
21e45a0
2016-03-14 09:24:39 +01:00
Jonas Schnelli
3798e5de33
Merge #7613 : Add autocomplete to bitcoin-qt's console window.
...
ce7413f
2016-03-14 09:20:29 +01:00
Pavel Vasin
a6ee0caa4e
use cached block hash in blockToJSON()
2016-03-12 17:11:59 +03:00
Luv Khemani
ce7413fcb7
Add autocomplete to bitcoin-qt's console window.
...
Removed externs
Added listCommands() to CRPCTable
Move autocomplete init to RPCConsole::setClientModel()
2016-03-12 13:04:23 +08:00
Andrew C
21e45a097e
Fix history deletion bug after font change
...
The history is no longer cleared after the font size is changed
2016-03-11 13:19:19 -05:00
Mustafa
2fdaa25529
Move GetTempPath() to testutil.
2016-03-11 15:04:05 +00:00
Jonas Schnelli
fc7c60d699
[Wallet] move "load wallet phase" to CWallet
2016-03-11 14:31:06 +01:00
Mustafa
393b22eacb
Add a source file for unit test utils.
2016-03-11 12:03:45 +00:00
Wladimir J. van der Laan
86a1ec5b2c
Merge #7576 : [Wallet] move wallet help string creation to CWallet
...
72c2651
2016-03-11 08:40:37 +01:00
Wladimir J. van der Laan
9f14e5ad91
Merge #7553 : Remove vfReachable and modify IsReachable to only use vfLimited.
...
110b62f
2016-03-11 08:25:28 +01:00
Wladimir J. van der Laan
26a2a7214f
Merge #7592 : mempool: Re-remove ERROR logging for mempool rejects
...
8fc81e0
2016-03-11 08:20:42 +01:00
Wladimir J. van der Laan
3da5d1bc2e
Merge #7637 : Fix memleak in TorController [rework]
...
e219503
2016-03-11 08:19:55 +01:00
Pieter Wuille
8a253b342c
Make the generate RPC call function for non-regtest
2016-03-09 22:30:15 +01:00
Pieter Wuille
c8d2473e6c
Merge #7642 : Avoid "Unknown command" messages when receiving getaddr on outbound c…
...
9988554
2016-03-09 21:52:17 +01:00
Pavel Vasin
7d2f84c72f
remove unused NOBLKS_VERSION_{START,END} constants
2016-03-09 19:29:23 +03:00
João Barbosa
3252208cb1
Improve EncodeBase58 performance
2016-03-09 10:10:36 +00:00
João Barbosa
d6cc6a1830
Use CCoinControl selection in CWallet::FundTransaction
2016-03-08 15:14:47 +00:00
Jonas Schnelli
87d6562299
Merge #7628 : QT: Add 'copy full transaction details' option
...
b51ed40
2016-03-08 10:15:22 +01:00
R E Broadley
9988554fc7
No "Unknown command" for getaddr command.
2016-03-08 08:49:42 +00:00
Eric Shaw
b51ed4036e
QT: Add 'copy full transaction details' option
...
Adds feature from issue #7484
modifies the ctrl-c binding to copy full transaction details in transaction view.
Added translation
2016-03-07 19:50:57 -05:00
Jonas Schnelli
72c2651581
[Wallet] move wallet help string creation to CWallet
2016-03-05 13:27:04 -05:00
Pieter Wuille
9f33dba05c
Merge #7539 : Add tags to mempool's mapTx indices
...
086da92
2016-03-05 06:56:33 +01:00
Wladimir J. van der Laan
3368895c3b
Merge #7521 : Don't resend wallet txs that aren't in our own mempool
...
5a2b1c0
2016-03-03 15:09:50 +01:00
Wladimir J. van der Laan
7f001bdf64
Merge #7605 : Remove openssl info from init/log and from Qt debug window
...
5ecfa36
2016-03-03 13:55:56 +01:00
Wladimir J. van der Laan
e219503711
Fix memleak in TorController [rework]
...
It looks like, TorController::disconnected_cb(TorControlConnection&
conn) gets called multiple times which results in multiple event_new().
Avoid this by creating the event only once in the constructore, and
deleting it only once in the destructor (thanks to Cory Fields for the
idea).
Replaces the fix by Jonas Schnelli in #7610 , see discussion there.
2016-03-03 13:31:26 +01:00
Wladimir J. van der Laan
e5121eb951
Merge #7617 : [doc/log] Fix markdown syntax and line terminate LogPrint
...
fa26652fa97f95fa06ce0
2016-03-01 18:39:21 +01:00
MarcoFalke
fa26652459
Make sure LogPrintf strings are line-terminated
2016-03-01 14:59:30 +01:00
mrbandrews
0040118959
Fixes ZMQ startup with bad arguments.
2016-02-29 13:34:09 -05:00
Wladimir J. van der Laan
78e81b0bc5
Merge #7537 : wallet: Warn on unexpected EOF while salvaging wallet
...
ca8fb59
2016-02-29 10:05:07 +01:00
MarcoFalke
fa06ce0949
Fix doxygen comment for payTxFee
2016-02-27 18:14:57 +01:00
Jonas Schnelli
5ecfa36fd0
Remove openssl info from init/log and from Qt debug window
2016-02-26 09:35:39 +01:00
Wladimir J. van der Laan
8fc81e0983
mempool: Reduce ERROR logging for mempool rejects
...
Continues "Make logging for validation optional" from #6519 .
The idea there was to remove all ERROR logging of rejected transaction,
and move it to one message in the class 'mempoolrej' which logs the
state message (and debug info). The superfluous ERRORs in the log
"terrify" users, see for example issue #5794 .
Unfortunately a lot of new logging was introduced in #6871 (RBF) and
#7287 (misc refactoring). This pull updates that new code.
2016-02-24 19:40:29 +01:00
Wladimir J. van der Laan
8b958ab15b
Merge #7550 : rpc: Input-from-stdin mode for bitcoin-cli
...
f22f14c92bcca3
2016-02-24 11:33:25 +01:00
Wladimir J. van der Laan
92bcca37ab
rpc: Input-from-stdin mode for bitcoin-cli
...
Implements #7442 by adding an option `-stdin` which reads
additional arguments from stdin, one per line.
For example
```bash
echo -e "mysecretcode\n120" | src/bitcoin-cli -stdin walletpassphrase
echo -e "walletpassphrase\nmysecretcode\n120" | src/bitcoin-cli -stdin
```
2016-02-24 10:12:25 +01:00
Matthew Zipkin
7eef1d0dad
Clarify description of blockindex
...
see issues:
https://github.com/bitcoin-dot-org/bitcoin.org/issues/1237
https://github.com/bitcoin/bitcoin/issues/7532
2016-02-18 12:42:59 -08:00
Patrick Strateman
110b62f069
Remove vfReachable and modify IsReachable to only use vfLimited.
...
We do not know that a class of Network is reachable, only that it is not.
2016-02-17 23:21:27 -08:00
Suhas Daftuar
086da92ea7
Add tags to mempool's mapTx indices
2016-02-16 12:35:16 -05:00
Wladimir J. van der Laan
8b70a64d62
Merge #7526 : fix spelling of advertise (shows up in the debug log)
...
37767fd
2016-02-16 12:37:03 +01:00
Wladimir J. van der Laan
93c85d458a
Merge #7524 : BIP-112: Mempool-only CHECKSEQUENCEVERIFY
...
a381076c3c375253e53a3
2016-02-16 10:46:34 +01:00
BtcDrak
a38107643f
Code style fix.
...
This if statement is a little obtuse and using braces here
improves readability.
2016-02-16 09:39:44 +00:00
Wladimir J. van der Laan
2d4f73f47e
Merge #7509 : Common argument defaults for NODE_BLOOM stuff and -wallet
...
1fb91b3
2016-02-16 10:00:21 +01:00
Wladimir J. van der Laan
ce5fc02e61
Merge #7536 : test: test leading spaces for ParseHex
...
f31b6b8
2016-02-16 09:26:53 +01:00
Wladimir J. van der Laan
19324cf09c
Merge #7504 : Crystal clean make clean
...
ae6eca0
2016-02-15 17:18:41 +01:00
Wladimir J. van der Laan
f31b6b8995
test: test leading space for ParseHex
...
BerkeleyDB dump files have key and value lines indented.
The salvage code passes these to ParseHex as-is.
Check this in the tests (should just pass with current code).
2016-02-15 17:14:30 +01:00
Wladimir J. van der Laan
ca8fb59ae1
wallet: Warn on unexpected EOF while salvaging wallet
...
Check for EOF before every getline, and warn when reading gets to EOF
before the end of the data.
Stricter error checking could shed more light on issues such as #7463
and #7379 .
2016-02-15 16:35:12 +01:00
BtcDrak
c3c375226e
Separate CheckLockTime() and CheckSequence() logic
...
For the sake of a little repetition, make code more readable.
2016-02-14 11:29:40 +00:00
Mark Friedenbach
53e53a33c9
BIP112: Implement CHECKSEQUENCEVERIFY
...
- Replace NOP3 with CHECKSEQUENCEVERIFY (BIP112)
<nSequence> CHECKSEQUENCEVERIFY -> <nSequence>
- Fails if txin.nSequence < nSequence, allowing funds of a txout to be locked for a number of blocks or a duration of time after its inclusion in a block.
- Pull most of CheckLockTime() out into VerifyLockTime(), a local function that will be reused for CheckSequence()
- Add bitwise AND operator to CScriptNum
- Enable CHECKSEQUENCEVERIFY as a standard script verify flag
- Transactions that fail CSV verification will be rejected from the mempool, making it easy to test the feature. However blocks containing "invalid" CSV-using transactions will still be accepted; this is *not* the soft-fork required to actually enable CSV for production use.
2016-02-14 11:29:38 +00:00
jloughry
37767fd46f
fix spelling of advertise in src and doc
2016-02-12 12:51:54 -07:00
instagibbs
c372572595
Fix and cleanup listreceivedbyX documentation
2016-02-12 14:06:59 -05:00
Wladimir J. van der Laan
80d1f2e483
Merge #7184 : Implement SequenceLocks functions for BIP 68
...
b043c4ba51c79bda6ad5fc6c2f0f
2016-02-12 17:03:46 +01:00
Wladimir J. van der Laan
621940e040
Merge #7520 : LibreSSL doesn't define OPENSSL_VERSION, use LIBRESSL_VERSION_TEXT instead
...
a0a17b3
2016-02-12 13:06:02 +01:00
Pavel Janík
a0a17b3e44
LibreSSL doesn't define OPENSSL_VERSION, use LIBRESSL_VERSION_TEXT instead
2016-02-12 07:01:33 +01:00
jmacwhyte
8aa722609d
Fix IsInitialBlockDownload to play nice with testnet
2016-02-11 18:02:46 -08:00
Alex Morcos
5a2b1c0c8b
Don't resend wallet txs that aren't in our own mempool
2016-02-11 17:34:55 -05:00
Alex Morcos
b043c4b746
fix sdaftuar's nits again
...
it boggles the mind why these nits can't be delivered on a more timely basis
2016-02-11 15:34:04 -05:00
Wladimir J. van der Laan
0ecb3401fe
test: Script_error checking in script_invalid tests
...
Check the returned script_error. Add expected script_error
for generated as well as custom tests.
The specific error is not part of consensus, however
it could avoid unclear reporting issues such as #6862 in the future.
Fixes #7513 .
2016-02-11 17:33:28 +01:00
Wladimir J. van der Laan
2317ad7c56
test: Re-introduce JSON pretty printing in test builder
2016-02-11 17:33:28 +01:00
Wladimir J. van der Laan
b0ff8572ae
test: Move non-generated script_invalid test to the correct place
...
This test was introduced in 9fadf1c874
2016-02-11 16:16:40 +01:00
Luke Dashjr
1fb91b3496
Common argument defaults for NODE_BLOOM stuff and -wallet
2016-02-11 06:38:04 +00:00
Leviathn
8d1de43f0c
Remove internal miner
...
This code removes the internal miner which is only useful on Testnet.
This leaves the internal miner that is useful on RegTest intact.
2016-02-10 18:29:13 -08:00
Alex Morcos
c6c2f0fd78
Implement SequenceLocks functions
...
SequenceLocks functions are used to evaluate sequence lock times or heights per BIP 68.
The majority of this code is copied from maaku in #6312
Further credit: btcdrak, sipa, NicolasDorier
2016-02-10 15:35:33 -05:00
Pavel Janík
ae6eca0f49
make clean should clean .a files
2016-02-10 21:03:51 +01:00
Wladimir J. van der Laan
2f3f4af4cc
Merge #7500 : Correctly report high-S violations
...
9d95187
2016-02-10 20:32:13 +01:00
Wladimir J. van der Laan
b93f078496
Merge #7502 : Update the wallet best block marker when pruning
...
e4eebb6
2016-02-10 19:39:54 +01:00
Wladimir J. van der Laan
c9da9c4bd8
Merge #7491 : wallet: Ignore MarkConflict if block hash is not known
...
40e7b61
2016-02-10 18:56:51 +01:00
Pieter Wuille
e4eebb604e
Update the wallet best block marker when pruning
2016-02-10 17:11:13 +01:00
Pieter Wuille
9d95187d5d
Correctly report high-S violations
2016-02-10 14:19:20 +01:00
Wladimir J. van der Laan
40e7b61835
wallet: Ignore MarkConflict if block hash is not known
...
If number of conflict confirms cannot be determined, this means
that the block is still unknown or not yet part of the main chain,
for example during a reindex. Do nothing in that case,
instead of crash with an assertion.
Fixes #7234 .
2016-02-09 20:38:31 +01:00
Wladimir J. van der Laan
acf5983502
tests: Remove May15 test
...
This test is no longer relevant.
It was introduced in 8c222dca4f#6320 that it still passes, however I think there is zero reason to
keep it.
Closes #6320 .
2016-02-09 16:23:52 +01:00
Wladimir J. van der Laan
b49a623799
Merge #7480 : Changed getnetworkhps value to double to avoid overflow.
...
993d089
2016-02-09 11:08:40 +01:00
Wladimir J. van der Laan
3ffe4b241e
Merge #7482 : [P2P] Ensure headers count is correct
...
301bc7b
2016-02-09 08:54:25 +01:00
Wladimir J. van der Laan
3db828f951
Merge #7472 : rpc: Add WWW-Authenticate header to 401 response
...
7c06fbd
2016-02-09 08:52:02 +01:00
Suhas Daftuar
301bc7bc7e
Update nQueuedValidatedHeaders after peer disconnection
2016-02-08 15:50:52 -05:00
instagibbs
993d089e82
Changed getnetworkhps value to double to avoid overflow.
2016-02-08 10:49:27 -05:00
Wladimir J. van der Laan
7c06fbd8f5
rpc: Add WWW-Authenticate header to 401 response
...
A WWW-Authenticate header must be present in the 401
response to make clients know that they can authenticate,
and how.
WWW-Authenticate: Basic realm="jsonrpc"
Fixes #7462 .
2016-02-08 09:16:29 +01:00
Wladimir J. van der Laan
e7ea5db0c1
Merge #7459 : Consensus: Decouple pow.o from util.o
...
f3757a0
2016-02-05 11:19:45 +01:00
Matt
0830552673
Fix spelling: misbeha{b,v}ing
2016-02-04 17:15:20 -06:00
Jorge Timón
f3757a0391
Consensus: Decouple pow.cpp from util.h
2016-02-04 19:21:55 +01:00
Wladimir J. van der Laan
152a8216cc
Merge #7349 : Build against system UniValue when available
...
42407edcdcad9f62f7f2e23565155d3b29bab227052adf7e2
2016-02-04 17:43:19 +01:00
Wladimir J. van der Laan
d2228384de
Merge #6480 : include the chaintip blockindex in the SyncTransaction signal, add signal UpdateTip()
...
7d0bf0b
2016-02-04 17:03:09 +01:00
Wladimir J. van der Laan
4f4dc5ef72
Merge #7070 : Move maxTxFee out of mempool
...
fad6244fa762d0fa79db2
2016-02-04 14:54:23 +01:00
Wladimir J. van der Laan
2cdbf28cf3
Merge #7192 : Unify product name to as few places as possible
...
027fdb8cc2095ecddffaf29598e478ec83d3cae1404d5a3dfe4ab5e5917b1d0c39a6ff902ccde82a2d98de619a3e611b6e63bcdc51a6c67cd5f4683
2016-02-04 13:42:24 +01:00
Wladimir J. van der Laan
898fedf42f
Merge #7458 : [Net] peers.dat, banlist.dat recreated when missing
...
c77c662
2016-02-04 08:54:21 +01:00
kirkalx
c77c6625f3
peers.dat, banlist.dat recreated when missing
2016-02-04 11:46:24 +13:00
Wladimir J. van der Laan
eb331794a2
Merge #7225 : Eliminate unnecessary call to CheckBlock
...
dbb89dc
2016-02-03 13:23:49 +01:00
MarcoFalke
fad6244879
ATMP: make nAbsurdFee const
2016-02-03 13:14:23 +01:00
MarcoFalke
fa762d0f00
[wallet.h] Remove main.h include
2016-02-03 12:44:43 +01:00
Wladimir J. van der Laan
4cdbd4255b
Merge #7444 : Improve block validity/ConnectBlock() comments
...
2f19905
2016-02-03 12:29:37 +01:00
Wladimir J. van der Laan
5fd95b4490
Merge #7431 : Rename permitrbf to mempoolreplacement and provide minimal string-list forward compatibility (needs 0.12 backport)
...
b922fbe3b66e54d65dee977b55a0
2016-02-03 10:27:32 +01:00
Luke Dashjr
a68bb9f5e7
Merge branch 'master' into single_prodname
2016-02-03 05:41:13 +00:00
Luke Dashjr
027fdb83b4
When/if the copyright line does not mention Bitcoin Core developers, add a second line to copyrights in -version, About dialog, and splash screen
2016-02-03 05:38:51 +00:00
Luke Dashjr
cc2095ecae
Rewrite FormatParagraph to handle newlines within input strings correctly
2016-02-03 05:38:43 +00:00
MarcoFalke
fa79db2641
Move maxTxFee out of mempool
...
Also, remove default values in CMerkleTx::AcceptToMemoryPool()
2016-02-02 20:08:51 +01:00
Wladimir J. van der Laan
fd13fe7ca0
Merge #7091 : Consensus build package
...
cf82d054feadeca3d5eec
2016-02-02 19:02:22 +01:00
Wladimir J. van der Laan
11d74f6a6b
Merge #7084 : mempool: Replace maxFeeRate of 10000*minRelayTxFee with maxTxFee
...
fa1193efa331db
2016-02-02 15:18:07 +01:00
Wladimir J. van der Laan
47ac04e8b1
Merge #7311 : MOVEONLY: Move non-consensus functions out of pow
...
e867561
2016-02-02 14:16:16 +01:00
MarcoFalke
fa1193e254
[doxygen] Actually display comment
2016-02-02 13:39:23 +01:00
Luke Dashjr
b922fbe063
Rename replacebyfee=opt-in to mempoolreplacement=fee
2016-02-01 19:30:37 +00:00
Suhas Daftuar
dbb89dc793
Eliminate unnecessary call to CheckBlock
...
ProcessNewBlock would return failure early if CheckBlock failed, before
calling AcceptBlock. AcceptBlock also calls CheckBlock, and upon failure
would update mapBlockIndex to indicate that a block was failed. By returning
early in ProcessNewBlock, we were not marking blocks that fail a check in
CheckBlock as permanently failed, and thus would continue to re-request and
reprocess them.
2016-02-01 14:29:45 -05:00
Gregory Maxwell
1e05727072
Decide eviction group ties based on time.
...
This corrects a bug the case of tying group size where the code may
fail to select the group with the newest member. Since newest time
is the final selection criteria, failing to break ties on it
on the step before can undermine the final selection.
Tied netgroups are very common.
(cherry picked from commit 8e09f914f8ec66301257358b250e9a61befadd95)
2016-02-01 15:31:21 +01:00
Gregory Maxwell
1e9613ac09
Do not absolutely protect local peers from eviction.
...
With automatic tor HS support in place we should probably not be providing
absolute protection for local peers, since HS inbound could be used to
attack pretty easily. Instead, this counts on the latency metric inside
AttemptToEvictConnection to privilege actually local peers.
(cherry picked from commit 46dbcd4833115401fecbb052365b4c7725874414)
2016-02-01 15:31:17 +01:00
Pieter Wuille
5d743099b5
Get rid of inaccurate ScriptSigArgsExpected
...
(cherry picked from commit 52b29dca7670c3f6d2ab918c0fff1d17c4e494ad)
2016-02-01 15:28:25 +01:00
Wladimir J. van der Laan
58a8574400
Merge #7439 : Add whitelistforcerelay to control forced relaying. [ #7099 redux]
...
89d113e325c725
2016-02-01 14:11:15 +01:00
Gregory Maxwell
89d113e02a
Blacklist -whitelistalwaysrelay; replaced by -whitelistrelay.
2016-02-01 12:32:57 +00:00
Wladimir J. van der Laan
31ec14b74b
Merge #7287 : Consensus: Remove calls to error() and FormatStateMessage()
...
93fc58c
2016-02-01 10:21:53 +01:00
Peter Todd
2f19905324
Improve block validity/ConnectBlock() comments
...
Previously didn't make clear that the ContextualCheckBlock* functions
meant the block headers as context - not the UTXO set itself - and that
ConnectBlock() also did UTXO-related validity checks (in the future we
may split that functionality into a separate UTXO-specific contextual
check block function).
Also, reordered to put validity checks first for better readability.
2016-01-31 00:40:23 -05:00
Luke Dashjr
cdcad9fc5f
LDADD dependency order shuffling
2016-01-31 02:32:55 +00:00
Luke Dashjr
62f7f2ee21
Bugfix: Always include univalue in DIST_SUBDIRS
2016-01-31 02:32:00 +00:00
MarcoFalke
fa331db68b
mempool: Replace maxFeeRate of 10000*minRelayTxFee with maxTxFee
2016-01-30 11:29:22 +01:00
Jorge Timón
93fc58c742
Consensus: Remove calls to error() and FormatStateMessage() from some consensus code in main
2016-01-29 18:38:39 +01:00
Wladimir J. van der Laan
019280617a
Merge #6842 : limitfreerelay edge case bugfix
...
2dfeaa1
2016-01-29 13:12:02 +01:00
Luke Dashjr
3b66e54457
Simplify check for replacebyfee=opt-in
2016-01-29 01:28:54 +00:00
Gregory Maxwell
325c725fb6
Add whitelistforcerelay to control forced relaying.
...
Also renames whitelistalwaysrelay.
Nodes relay all transactions from whitelisted peers, this
gets in the way of some useful reasons for whitelisting
peers-- for example, bypassing bandwidth limitations.
The purpose of this forced relaying is for specialized gateway
applications where a node is being used as a P2P connection
filter and multiplexer, but where you don't want it getting
in the way of (re-)broadcast.
This change makes it configurable with whitelistforcerelay.
2016-01-28 22:26:21 +00:00
Kefkius
8b3d8e3991
GUI: Disable tab navigation for peers tables.
...
Fix a bug in which the Peers tab of the debug window
does not allow navigation to other tabs via Ctrl[+Shift]+Tab.
2016-01-28 15:26:54 -05:00
Wladimir J. van der Laan
326ffed09b
Merge #7212 : Adds unittests for CAddrMan and CAddrinfo, removes source of non-determinism.
...
40c87b6
2016-01-28 13:14:07 +01:00
Wladimir J. van der Laan
62f2d769e4
Merge #7348 : MOVE ONLY: move rpc* to rpc/
...
d13f65ea0eaff8
2016-01-28 11:28:24 +01:00
Wladimir J. van der Laan
4a46bdc0fe
Merge #7415 : net: Hardcoded seeds update January 2016
...
4818dba
2016-01-28 10:54:14 +01:00
Jonas Schnelli
cdcbc59a42
Merge #7396 : [Qt] Add option to increase/decrease font size in the console window
...
43abb0256c9e663a3a927
2016-01-28 10:23:31 +01:00
Luke Dashjr
d65dee961e
Accept replacebyfee=opt-in for turning on opt-in RBF
...
Basic forward-compatibility with more flexible parameters like fss
2016-01-28 06:10:35 +00:00
Luke Dashjr
77b55a00ed
Rename permitrbf to replacebyfee
...
"permit" is currently used to configure transaction filtering, whereas replacement is more to do with the memory pool state than the transaction itself.
2016-01-28 05:11:06 +00:00
Luke Dashjr
78ec83ddfe
splashscreen: Resize text to fit exactly
2016-01-27 20:29:18 +00:00
Ethan Heilman
40c87b6e69
Increase test coverage for addrman and addrinfo
...
Adds several unittests for CAddrMan and CAddrInfo.
Increases the accuracy of addrman tests.
Removes non-determinism in tests by overriding the random number generator.
Extracts testing code from addrman class to test class.
2016-01-27 10:50:58 -05:00
Wladimir J. van der Laan
9189e30b12
Merge #7300 : [trivial] Add missing copyright headers
...
fabcee1fa60d05fa7e4c0
2016-01-27 12:06:31 +01:00
Cory Fields
f3d3eaf78e
release: add check-symbols and check-security make targets
...
These are not added to the default checks because some of them depend on
release-build configs.
2016-01-26 23:07:04 -05:00
Jonas Schnelli
43abb02aa2
[Qt] Add a new chevron/arrow icon for the console prompt line
2016-01-26 15:34:36 +01:00
Wladimir J. van der Laan
473ad1bb02
Merge #7391 : [init] Clarify help message
...
fae78fa
2016-01-25 17:44:58 +01:00
Wladimir J. van der Laan
4818dba900
net: Hardcoded seeds update January 2016
2016-01-25 16:14:14 +01:00
MarcoFalke
fae78fa818
[init] Clarify permitrbf help message
2016-01-23 22:46:24 +01:00
Jonas Schnelli
f281caac48
Merge #7384 : [qt] Peertable: Increase SUBVERSION_COLUMN_WIDTH
...
faa9011
2016-01-23 14:17:18 +01:00
Jonas Schnelli
56c9e66a6d
[Qt] keep scroll position in GUI console after changing font size
2016-01-23 00:05:14 +01:00
Jonas Schnelli
3a3a927325
[Qt] Add option to increase/decrease font size in the console window
2016-01-22 21:46:42 +01:00
Wladimir J. van der Laan
fc08994000
Merge #7262 : Reduce inefficiency of GetAccountAddress()
...
2409865
2016-01-22 15:31:11 +01:00
Wladimir J. van der Laan
6a07208388
Merge #7056 : Save last db read
...
8504867
2016-01-22 14:15:52 +01:00
Jonas Schnelli
f221fc1887
Merge #7364 : [qt] Windows: Make rpcconsole monospace font larger
...
fa6a59d
2016-01-22 09:47:51 +01:00
Wladimir J. van der Laan
b768108d9c
Add option -permitrbf to set transaction replacement policy
...
Add a configuration option `-permitrbf` to set transaction replacement policy
for the mempool.
Enabling it will enable (opt-in) RBF, disabling it will refuse all
conflicting transactions.
2016-01-21 11:24:31 +01:00
Jonas Schnelli
ae2db67fee
Merge #7383 : [Qt] rename "amount" to "requested amount" in receive coins table
...
df6e8e1
2016-01-21 09:00:53 +01:00
MarcoFalke
faa9011d09
[qt] Peertable: Increase SUBVERSION_COLUMN_WIDTH
2016-01-20 23:00:10 +01:00
Daniel Cousens
d13f65ebac
rpc: update inline comments to refer to new file paths
2016-01-21 08:39:04 +11:00
Daniel Cousens
a0eaff8a1d
move rpc* to rpc/
2016-01-21 08:36:55 +11:00
Jonas Schnelli
df6e8e17e4
[Qt] rename "amount" to "requested amount" in receive coins table
2016-01-20 17:30:06 +01:00
Wladimir J. van der Laan
b92ea98503
Merge #7183 : Improved readability of ApproximateBestSubset
...
96efcad
2016-01-20 15:55:03 +01:00
Wladimir J. van der Laan
9982710e88
Merge #7307 : [RPC, Wallet] Move RPC dispatch table registration to wallet/ code
...
dd2dc40
2016-01-20 15:15:51 +01:00
Jonas Schnelli
dd2dc400ee
[RPC, Wallet] Move RPC dispatch table registration to wallet/ code
...
Allow extending the rpc dispatch table by appending commands when server is not running.
2016-01-20 15:03:25 +01:00
Wladimir J. van der Laan
82429d0861
Merge #7222 : RPC: Indicate which transactions are signaling opt-in RBF
...
eaa8d27
2016-01-20 13:50:37 +01:00
Wladimir J. van der Laan
5578144413
Merge #7350 : Banlist updates
...
e8600c92977c24ce479aa57c77fe
2016-01-20 13:38:40 +01:00
MarcoFalke
fa6d4cc095
[walletdb] Fix syntax error in key parser
2016-01-20 09:44:53 +01:00
Suhas Daftuar
eaa8d2754b
RPC: indicate which transactions are replaceable
...
Add "bip125-replaceable" output field to listtransactions and gettransaction
which indicates if an unconfirmed transaction, or any unconfirmed parent, is
signaling opt-in RBF according to BIP 125.
2016-01-19 08:30:04 -05:00
Wladimir J. van der Laan
f9fd4c2884
Merge pull request #7281 : Improve CheckInputs() comment about sig verification
...
fd83615
2016-01-19 13:23:32 +01:00
Wladimir J. van der Laan
3b43cad9d0
Merge pull request #7164 : Do not download transactions during initial blockchain sync
...
39a525c
2016-01-19 12:58:15 +01:00
Luke Dashjr
3cae14056a
Bugfix: Actually use _COPYRIGHT_HOLDERS_SUBSTITUTION everywhere
2016-01-19 08:42:05 +00:00
Wladimir J. van der Laan
e4e77ee55d
Merge pull request #7194
...
135d6ec474563616d4fce
2016-01-18 12:24:01 +01:00
Wladimir J. van der Laan
ae20172941
Merge pull request #7232
...
94bdd71
2016-01-18 12:20:13 +01:00
Wladimir J. van der Laan
47c5ed19f3
Merge pull request #7208
...
64360f1
2016-01-18 11:55:59 +01:00
Wladimir J. van der Laan
c851d8d71b
Merge pull request #7290
...
fa461dffaa572afa6ab96fac11ea
2016-01-18 11:21:51 +01:00
Wladimir J. van der Laan
5e00147838
Merge pull request #7313
...
0331aa3
2016-01-18 10:45:25 +01:00
Wladimir J. van der Laan
a8bd616fea
Merge pull request #7329
...
9d263bd
2016-01-18 10:41:32 +01:00
Wladimir J. van der Laan
2350ab28fb
Merge pull request #7363
...
bd34174
2016-01-18 10:30:22 +01:00
MarcoFalke
fa6a59dd39
[qt] Windows: Make rpcconsole monospace font larger
2016-01-17 19:28:49 +01:00
Prayag Verma
bd34174ebc
Update license year range to 2016
2016-01-17 23:38:11 +05:30
Chris Wheeler
9d263bd17c
Typo fixes in comments
2016-01-17 11:03:56 +00:00
MarcoFalke
fabcee1972
Remove copyright header from autogenerated chainparamsseeds.h
2016-01-16 15:31:22 +01:00
Wladimir J. van der Laan
fd9356ba4e
Merge pull request #7322
...
c0cf48d
2016-01-16 10:49:46 +01:00
Luke Dashjr
5bc4fb7b60
Merge branch 'master' into 20150703_banlist_updates
2016-01-15 05:17:15 +00:00
Luke Dashjr
ab22705a7b
Build against system UniValue when available
2016-01-15 04:34:06 +00:00
Luke Dashjr
2adf7e2c90
Bugfix: The var is LIBUNIVALUE,not LIBBITCOIN_UNIVALUE
2016-01-15 04:34:02 +00:00
Wladimir J. van der Laan
e1060c56cc
Merge pull request #7334
...
fa989fb
2016-01-14 13:56:59 +01:00
Jonas Schnelli
c079d79c9a
Merge pull request #7327
...
30cdace
2016-01-13 21:24:43 +01:00
crowning-
30cdacea3c
[Wallet] Transaction View: LastMonth calculation fixed
2016-01-13 21:17:08 +01:00
MarcoFalke
fa989fbf57
[qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5)
2016-01-13 18:46:12 +01:00
Wladimir J. van der Laan
17ef279304
Merge pull request #7332
...
faf671b
2016-01-13 16:01:28 +01:00
Wladimir J. van der Laan
be6d5a617d
Merge pull request #7312
...
d11fc16df0e22201e06d19e69717
2016-01-13 15:47:45 +01:00
Jonas Schnelli
d11fc1695c
[Wallet] Call notification signal when a transaction is abandoned
2016-01-13 08:42:04 -05:00
Alex Morcos
01e06d1fa3
Add new rpc call: abandontransaction
...
Unconfirmed transactions that are not in your mempool either due to eviction or other means may be unlikely to be mined. abandontransaction gives the wallet a way to no longer consider as spent the coins that are inputs to such a transaction. All dependent transactions in the wallet will also be marked as abandoned.
2016-01-13 08:42:04 -05:00
MarcoFalke
faf671bca6
[wallet] Clarify rpc help message with regard to rounding
2016-01-13 12:06:24 +01:00
Wladimir J. van der Laan
2cd004b123
Merge pull request #7326
...
3a9dfe9
2016-01-13 11:50:38 +01:00
Wladimir J. van der Laan
c49551886a
Merge pull request #7296
...
bebe58be420a1b995b9f3
2016-01-13 11:04:31 +01:00
