lbrycrd

Author	SHA1	Message	Date
Wladimir J. van der Laan	0ee0474234	Merge #16521 : rpc: Use the default maxfeerate value as BTC/kB `2dfd6834ef` test: Add test for default maxfeerate in sendrawtransaction (Joonmo Yang) `261843e4be` wallet/rpc: Use the default maxfeerate value as BTC/kB (Joonmo Yang) Pull request description: Fixes https://github.com/bitcoin/bitcoin/issues/16382 This patch tries to treat `maxfeerate` in sendrawtransaction/testmempoolaccept RPC as a rate(BTC/kB) instead of an absolute value(BTC). The included test case checks if the new behavior works correctly, by using the transaction with an absolute fee of ~0.02BTC, where the fee rate is ~0.2BTC/kB. This test should be failing if the default `maxfeerate` is 0.1BTC, but pass if the default value is 0.1BTC/kB ACKs for top commit: laanwj: ACK `2dfd6834ef` (ACKs by Sjors and MarcoFalke above for trivially different code) Tree-SHA512: a1795bffe8a182acef8844797955db1f60bb0c0ded97148f3572dc265234d5219271a3a7aa0b6418a43f73b2b2720ef7412ba169c99bb1cdcac52051f537d6af	2019-09-18 16:49:18 +02:00
Wladimir J. van der Laan	feb162d500	Merge #14696 : qa: Add explicit references to related CVE's in p2p_invalid_block test. `0c62e3aa73` New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137. (lucash-dev) `38bfca6bb2` Added comments referencing multiple CVEs in tests and production code. (lucash-dev) Pull request description: This functional test includes two scenarios that test for regressions of vulnerabilities, but they are only briefly described. There are freely available documents explaining in detail the issues, but without explicit mentions, the developer trying to maintain the code needs an additional step of digging in commit history and PR conversations to figure it out. Added comments to explicitly mention CVE-2018-17144 and CVE-2012-2459, for more complete documentation. This improves developer experience by making understanding the tests easier. ACKs for top commit: laanwj: ACK `0c62e3aa73`, checked the CVE numbers, thanks for adding documentation Tree-SHA512: 3ee05351745193b8b959e4a25d50f25a693b2d24b0732ed53cf7d5882df40b5dd0f1877bd5c69cffb921d4a7acf9deb3cc1160b96dc730d9b5984151ad06b7c9	2019-09-18 16:00:54 +02:00
Joonmo Yang	261843e4be	wallet/rpc: Use the default maxfeerate value as BTC/kB	2019-08-18 22:58:04 +09:00
MarcoFalke	fa89badf88	test: Require standard txs in regtest	2019-06-21 16:45:16 -04:00
lucash-dev	38bfca6bb2	Added comments referencing multiple CVEs in tests and production code. This commit adds comments referencing multiple CVEs both in production and test code. CVEs covered in this commit: CVE-2010-5137 CVE-2010-5139 CVE-2010-5141 CVE-2012-1909 CVE-2012-2459 CVE-2012-3789 CVE-2018-17144	2019-06-02 10:25:03 -07:00
Karl-Johan Alm	6c0a6f73e3	wallet/rpc: add maxfeerate parameter to sendrawtransaction	2019-03-14 08:48:46 +09:00
MarcoFalke	faa7cdf764	scripted-diff: Update copyright in ./test -BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./test/ -END VERIFY SCRIPT-	2019-03-02 10:58:35 -05:00
MarcoFalke	fa6bf21f5e	scripted-diff: test: Use py3.5 bytes::hex() method -BEGIN VERIFY SCRIPT- sed -i -e "s/def bytes_to_hex_str/def b_2_x/g" $(git grep -l bytes_to_hex_str) export RE_B_0="[^()]" # match no bracket export RE_B_1="${RE_B_0}$${RE_B_0}$${RE_B_0}" # match exactly one () export RE_B_2="${RE_B_0}$${RE_B_1}$${RE_B_0}" # match wrapped (()) export RE_M="(b2x\|bytes_to_hex_str)$((${RE_B_0}\|${RE_B_1}\|${RE_B_2}))$" sed -i --regexp-extended -e "s/${RE_M}/\2.hex()/g" $(git grep -l -E '(b2x\|bytes_to_hex_str)') sed -i --regexp-extended -e "/ +bytes_to_hex_str( as b2x)?,/d" $(git grep -l bytes_to_hex_str) sed -i --regexp-extended -e "s/ +bytes_to_hex_str( as b2x)?,//g" $(git grep -l bytes_to_hex_str) sed -i --regexp-extended -e "s/, bytes_to_hex_str( as b2x)?//g" $(git grep -l bytes_to_hex_str) export RE_M="(binascii\.)?hexlify$((${RE_B_0}\|${RE_B_1}\|${RE_B_2}))$.decode$${RE_B_0}$" sed -i --regexp-extended -e "s/${RE_M}/\2.hex()/g" $(git grep -l hexlify -- ':(exclude)share') sed -i --regexp-extended -e "/from binascii import hexlify$/d" $(git grep -l hexlify -- ':(exclude)share') sed -i --regexp-extended -e "s/(from binascii import) .hexlify/\1 unhexlify/g" $(git grep -l hexlify -- ':(exclude)share') sed -i -e 's/ignore-names "/ignore-names "b_2_x,/g' ./test/lint/lint-python-dead-code.sh -END VERIFY SCRIPT-	2019-03-02 10:40:12 -05:00
MarcoFalke	1111aecbb5	qa: Always refresh stale cache to be out of ibd	2019-02-19 14:22:13 -05:00
DrahtBot	06ba77973e	Update copyright headers to 2018	2018-12-29 10:15:01 +01:00
MarcoFalke	faee59103d	test: Fix race in mempool_accept	2018-12-14 18:12:17 -05:00
MarcoFalke	aaaa8eb1ed	test: consensus: Check that final transactions are valid	2018-12-11 13:40:13 -05:00
MarcoFalke	9ebfe0e927	Merge #14819 : Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize `29aeed1734` Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize (Luke Dashjr) Pull request description: Simply integer dividing results in an acceptable size if the limit isn't an exact multiple of the input size. Use math.ceil to ensure the transaction is always oversize. (This issue can be triggered by changing the address style used.) Tree-SHA512: e45062b0e8a3e9cb08e9dac5275b68d86e4377b460f1b3b995944090a055b0542a6986826312ec0e223369838094e42e20d8614b5c2bab9975b9a6f749295b21	2018-11-28 10:40:33 -05:00
Luke Dashjr	29aeed1734	Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize Simply integer dividing results in an acceptable size if the limit isn't an exact multiple of the input size. Use math.ceil to ensure the transaction is always oversize.	2018-11-27 17:55:01 +00:00
MarcoFalke	fac9539836	qa: Run all tests even if wallet is not compiled	2018-09-10 17:53:21 -04:00
MarcoFalke	fa31ca0c22	qa: Remove redundant checkmempool/checkblockindex extra_args	2018-08-08 14:29:19 -04:00
MarcoFalke	b55555da3e	rpc: Add testmempoolaccept	2018-03-24 11:17:08 -04:00

17 commits