Wladimir J. van der Laan
8cbe1f4f58
tests: change main and wallet tests to BOOST_FIXTURE_TEST_SUITE
...
Avoid this travis error:
test_bitcoin: chainparams.cpp:330: const CChainParams& Params():
Assertion `pCurrentParams' failed.
unknown location(0): fatal error in "subsidy_limit_test": signal:
SIGABRT (application abort requested)
test/allocator_tests.cpp(116): last checkpoint
2015-03-09 15:04:59 +01:00
Wladimir J. van der Laan
cdae53e456
Merge pull request #5852
...
51598b2
Reinitialize state in between individual unit tests. (Pieter Wuille)
2015-03-09 12:51:07 +01:00
Wladimir J. van der Laan
c1b723c30a
Merge pull request #5442
...
dca799e
Ignore getaddr messages on Outbound connections. (Ivan Pustogarov)
2015-03-09 12:24:53 +01:00
Philip Kaufmann
8517e9709e
[Qt] rework setNumBlocks to have blockDate as parameter
...
- reduces some functional overhead and simplifies the code
2015-03-09 10:58:17 +01:00
Wladimir J. van der Laan
513e025239
Merge pull request #5858
...
9bbb880
[Qt] fix a issue where "command line options"-action overwrite "Preference"-action (on OSX) (Jonas Schnelli)
2015-03-09 10:45:12 +01:00
Wladimir J. van der Laan
d26f0b263c
Merge pull request #5793
...
6cb4a52
[Qt, Linux] honor current network when creating autostart link (Philip Kaufmann)
9673c35
[Qt, Win] honor current network when creating autostart link (Philip Kaufmann)
2015-03-09 09:55:49 +01:00
Pieter Wuille
2f10aa0fa1
Merge pull request #5151
...
eec3713
make CMessageHeader a dumb storage class (Cory Fields)
2015-03-07 05:38:34 -08:00
Wladimir J. van der Laan
a0ae79d775
Replace CBlockHeader::GetHash with call to SerializeHash
...
Removes variability between LE and BE.
As suggested by @sipa.
2015-03-06 17:21:59 +01:00
Wladimir J. van der Laan
62b30f09ac
Add serialize float/double tests
2015-03-06 17:21:59 +01:00
Wladimir J. van der Laan
9f4fac98c4
src/txmempool.cpp: make numEntries a uint32_t
...
Don't ever serialize a size_t or long, their sizes are platform
dependent.
2015-03-06 17:21:59 +01:00
Wladimir J. van der Laan
f4e6487219
src/arith_256.cpp: bigendian compatibility
2015-03-06 17:21:59 +01:00
Wladimir J. van der Laan
aac3205375
src/netbase.h: Fix endian in CNetAddr serialization
...
We've chosen to htons/ntohs explicitly on reading and writing
(I do not know why). But as READWRITE already does an endian swap
on big endian, this means the port number gets switched around,
which was what we were trying to avoid in the first place. So
to make this compatible, serialize it as FLATDATA.
2015-03-06 17:21:58 +01:00
Wladimir J. van der Laan
01f9c3449a
src/serialize.h: base serialization level endianness neutrality
...
Serialization type-safety and endianness compatibility.
2015-03-06 17:21:58 +01:00
Wladimir J. van der Laan
4e853aa163
src/script/script.h: endian compatibility for PUSHDATA sizes
2015-03-06 17:21:58 +01:00
Wladimir J. van der Laan
4f92773f92
src/primitives/transaction.h: endian compatibility in serialization
2015-03-06 17:21:58 +01:00
Wladimir J. van der Laan
81aeb28436
src/primitives/block.cpp: endian compatibility in GetHash
2015-03-06 17:21:58 +01:00
Wladimir J. van der Laan
dec84cae2a
src/net.cpp: endian compatibility in EndMessage
2015-03-06 17:21:58 +01:00
Wladimir J. van der Laan
556814ec4e
src/main.cpp: endian compatibility in packet checksum check
2015-03-06 17:21:55 +01:00
Wladimir J. van der Laan
3ca5852dc2
src/hash.cpp: endian compatibility
2015-03-06 15:54:53 +01:00
Wladimir J. van der Laan
4414f5ffe1
build: Endian compatibility
...
- Detect endian instead of stopping configure on big-endian
- Add `byteswap.h` and `endian.h` header for compatibility with
Windows and other operating systems that don't come with them
- Update `crypto/common.h` functions to use compat
endian header
2015-03-06 15:54:53 +01:00
Wladimir J. van der Laan
51377c2dbe
Merge pull request #5843
...
ba04c4a
Limit message sizes before transfer (Pieter Wuille)
2015-03-06 15:31:31 +01:00
Wladimir J. van der Laan
ee9f2bfa7b
Merge pull request #5813
...
34e5015
Add unit tests for next difficulty calculations (Ross Nicoll)
2015-03-06 15:27:00 +01:00
Pieter Wuille
ba04c4a780
Limit message sizes before transfer
...
This introduces a fixed limit for the size of p2p messages, and enforces it
before download.
2015-03-06 04:03:17 -08:00
Jonas Schnelli
9bbb880be4
[Qt] fix a issue where "command line options"-action overwrite "Preference"-action (on OSX)
...
- fixes #5800
2015-03-06 09:33:23 +01:00
Rob Van Mieghem
84a05b843b
QT: remove unused parameter
2015-03-05 12:20:49 -05:00
Wladimir J. van der Laan
215475aa00
Merge pull request #5830
...
6f1274c
qt: Don't save geometry for options and about/help window (Wladimir J. van der Laan)
2015-03-05 14:42:20 +01:00
Pieter Wuille
51598b2631
Reinitialize state in between individual unit tests.
...
This changes the TestingSetup fixture to be per-unit-test rather than global.
Most tests don't need it, so it's only invoked in a few.
2015-03-03 09:01:46 -08:00
Wladimir J. van der Laan
3dfcdf46c2
Merge pull request #5775
...
deda3e1
[Qt] remove unused getNumBlocksAtStartup() from ClientModel (Philip Kaufmann)
47ee8cf
[Qt] use qint64 in BitcoinGUI::setNumBlocks (Philip Kaufmann)
2015-03-03 16:57:30 +01:00
Wladimir J. van der Laan
f8e68f7bfb
Merge pull request #5819
...
d23b0a2
depends: always use static qt5 for linux (Cory Fields)
3448b13
build: fix typo in configure help (Cory Fields)
c95ac83
gitian: fix x86_64 build with static libstdc++ (Cory Fields)
0671516
build: change reduce exports/static libstdc++ options for gitian and travis (Cory Fields)
aa36730
build: remove libstdc++ backwards-compat (Cory Fields)
3ee028f
build: disable reduced exports by default (Cory Fields)
2015-03-03 16:27:50 +01:00
Pieter Wuille
86eb461c5b
Merge pull request #5839
...
16a58a8
keys: remove libsecp256k1 verification until it's actually supported (Cory Fields)
2015-03-03 04:08:15 -08:00
Cory Fields
16a58a8644
keys: remove libsecp256k1 verification until it's actually supported
...
This was added a while ago for testing purposes, but was never intended to be
used. Remove it until upstream libsecp256k1 decides that verification is
stable/ready.
2015-03-02 11:31:43 -05:00
Pieter Wuille
10a3ff07f5
Merge pull request #5832
...
9abbeea
Remove obsolete pubsub method definitions (Pieter Wuille)
2015-03-01 03:13:09 -08:00
Wladimir J. van der Laan
db4a1d598c
Merge pull request #5694
...
25cf6f3
minor rework of SendMoney in rpcwallet (Philip Kaufmann)
2015-02-26 17:20:29 +01:00
Wladimir J. van der Laan
59310f1c02
Merge pull request #5820
...
85da07a
Better fingerprinting protection for non-main-chain getdatas. (Pieter Wuille)
2015-02-26 17:13:13 +01:00
Pieter Wuille
9abbeeabd7
Remove obsolete pubsub method definitions
2015-02-26 05:30:59 -08:00
Wladimir J. van der Laan
482783b341
Merge pull request #5801
...
de5403f
[GUI] Move fee dialog minimise button away from "Transaction Fee" (Michael Ford)
2015-02-26 11:26:32 +01:00
Wladimir J. van der Laan
6f1274c8c9
qt: Don't save geometry for options and about/help window
...
These dialogs will be something that people occasionally open, not keep
open during their session, so just popping it up in a sensible place
is good enough. Remembering only creates potential issues, like spawning
it outside the current screen area.
On Ubuntu this causes the dialogs to be positioned in the
middle of the main dialog, so I didn't add code for that. YMMV.
Inspired by github pull #5777 by @L-Cranston-Shadow
2015-02-26 10:23:42 +01:00
Cory Fields
eec37136fd
make CMessageHeader a dumb storage class
...
It shouldn't know or care about bitcoind's chain param selection
2015-02-25 18:44:49 -05:00
21E14
32eaf8a3de
WIN32 Seed Cleanup: Move nLastPerfmon behind win32 ifdef.
...
Code to avoid calling Perfmon too often is only needed when perfmon is actually going to get called.
This is not intended to make any functional difference in the addition of entropy to the random pool.
2015-02-25 18:37:06 -05:00
Pieter Wuille
85da07a5a0
Better fingerprinting protection for non-main-chain getdatas.
...
With headers-first we can compare against the best header timestamp, rather
than using checkpoints which require code updates to maintain.
2015-02-24 04:35:13 -08:00
Cory Fields
aa3673064c
build: remove libstdc++ backwards-compat
...
Backwards-compatibility for libstdc++ is not limited to straightforward abi
changes. Symbol visibility also needs to be taken into consideration, and
that really can't be addressed simply.
Instead, just static-link libstdc++ for backwards-compat.
2015-02-23 17:56:15 -05:00
Ross Nicoll
34e5015cd2
Add unit tests for next difficulty calculations
...
Split GetNextWorkRequired() into two functions to allow the difficulty calculations to
be tested without requiring a full blockchain.
Add unit tests to cover basic difficulty calculation, plus each of the min/max actual
time, and maximum difficulty target conditions.
2015-02-21 13:14:19 +00:00
Michael Ford
de5403f878
[GUI] Move fee dialog minimise button away from "Transaction Fee"
...
Its original placement was causing confusion among some users.
2015-02-21 09:11:33 +08:00
Wladimir J. van der Laan
a026a56c4e
Merge #5706 : fix crash: RPC \
...
e5d9d77
fix crash: createmultisig and addmultisigaddress (fsb4000)
2015-02-20 09:51:38 +01:00
Wladimir J. van der Laan
07f4386b38
Merge #5689 : openssl: abstract out OPENSSL_cleanse
...
1630219
openssl: abstract out OPENSSL_cleanse (Cory Fields)
2015-02-19 12:09:26 +01:00
Philip Kaufmann
6cb4a52535
[Qt, Linux] honor current network when creating autostart link
2015-02-19 12:08:47 +01:00
Philip Kaufmann
9673c35daf
[Qt, Win] honor current network when creating autostart link
...
- creates a "Bitcoin (testnet).lnk" when on testnet or a "Bitcoin
(regtest).lnk, when on regtest
- fixes #5778
2015-02-19 12:06:49 +01:00
Wladimir J. van der Laan
47a79bb880
Merge #5366 : No longer check osx compatibility in RenameThread
...
850c570
No longer check osx compatibility in RenameThread (Michael Ford)
2015-02-18 17:36:39 +01:00
Wladimir J. van der Laan
8d0418720c
Merge #5799 : Rename Interval() to DifficultyAdjustmentInterval()
...
e5ece05
Rename Interval() to DifficultyAdjustmentInterval() (Shaul Kfir)
2015-02-18 17:29:28 +01:00
Wladimir J. van der Laan
e3a3cd7a28
Merge #5784 : Fix usage of NegateSignatureS in script_tests
...
78c6bed
Add test for DER-encoding edge case (Suhas Daftuar)
6f50dbd
Fix NegateSignatureS to not duplicate last byte of S (Suhas Daftuar)
2015-02-18 09:52:59 +01:00