Wladimir J. van der Laan
b45c50ce51
Fix two problems in CSubNet parsing
...
Fix two CSubNet constructor problems:
- The use of `/x` where 8 does not divide x was broken, due to a
bit-order issue
- The use of e.g. `1.2.3.4/24` where the netmasked bits in the network
are not 0 was broken. Fix this by explicitly normalizing the netwok
according to the bitmask.
Also add tests for these cases.
Fixes #6179 . Thanks to @jonasschnelli for reporting and initial fix.
2015-05-26 08:59:59 +02:00
Wladimir J. van der Laan
19e8d7be42
Simplify code for CSubnet
...
Simplify the code by using CAddress.ip directly, instead of the reversed
GetByte() semantics.
2015-05-26 08:59:13 +02:00
Wladimir J. van der Laan
e1412d3e96
Merge pull request #6159
...
ffdda4e
Catch errors on datadir lock and pidfile delete (Adam Weiss)
2015-05-24 10:57:22 +02:00
Wladimir J. van der Laan
2d84241d26
doc: Add historical release notes 0.9.5
2015-05-24 09:49:18 +02:00
Adam Weiss
ffdda4e8a7
Catch errors on datadir lock and pidfile delete
...
Prevents bad permissions (or other fs related problems) from resulting
in hard crashes with cryptic messages on startup and shutdown.
2015-05-22 14:15:22 -04:00
Wladimir J. van der Laan
7708fcde36
Merge pull request #6098
...
cc24610
Update Windows resource files (and add one for bitcoin-tx) (Luke Dashjr)
2015-05-22 08:35:38 +02:00
Wladimir J. van der Laan
b3024f077b
Merge pull request #6168
...
7f68c7d
contrib/linearize: Support linearization of testnet blocks (Jeff Garzik)
2015-05-22 08:17:08 +02:00
Luke Dashjr
cc24610fdb
Update Windows resource files (and add one for bitcoin-tx)
2015-05-22 02:56:55 +00:00
Wladimir J. van der Laan
4bf83b27b2
Merge pull request #6171
...
bdcf5de
Fix intermittent hang issue in scheduler_tests (Wladimir J. van der Laan)
2015-05-21 22:00:07 +02:00
Wladimir J. van der Laan
bdcf5dea7c
Fix intermittent hang issue in scheduler_tests
...
Don't clear `stopRequested` and `stopWhenEmpty` at the top of
`serviceQueue`, as this results in a race condition: on systems under
heavy load, some of the threads only get scheduled on the CPU when the
other threads have already finished their work. This causes the flags to
be cleared post-hoc and thus those threads to wait forever.
The potential drawback of this change is that the scheduler cannot be
restarted after being stopped (an explicit reset would be needed), but
we don't use this functionality anyway.
2015-05-21 19:07:10 +02:00
Jeff Garzik
7f68c7dc05
contrib/linearize: Support linearization of testnet blocks
2015-05-20 15:27:51 -07:00
Wladimir J. van der Laan
0d862c2739
Merge pull request #6160
...
16d9cb7
[QT] overviewpage: make sure warning icons gets colored (Jonas Schnelli)
2015-05-20 13:21:01 +02:00
Wladimir J. van der Laan
180c164e4f
Merge pull request #6161
...
fb21862
[QT] mainwindow toolbar must not be movable (Jonas Schnelli)
2015-05-20 13:19:42 +02:00
Wladimir J. van der Laan
30dc3c1b38
Merge pull request #6116
...
d1a3866
build: Cope with spaces in filenames when creating/applying OSX sigs (Cory Fields)
7cef321
[Mac only] rename Bitcoin-Qt.app to "Bitcoin Core.app" (Jonas Schnelli)
2015-05-20 13:08:51 +02:00
Jonas Schnelli
fb21862b92
[QT] mainwindow toolbar must not be movable
2015-05-19 20:28:20 +02:00
Jonas Schnelli
16d9cb7e29
[QT] overviewpage: make sure warning icons gets colored
2015-05-19 16:37:13 +02:00
Wladimir J. van der Laan
377711ff3f
Merge pull request #5996
...
935bd0a
Chainparams: Refactor: Decouple main::GetBlockValue() from Params() [renamed GetBlockSubsidy] (Jorge Timón)
2015-05-19 11:42:47 +02:00
Wladimir J. van der Laan
e2e7f9513f
qt: fix unused function warning in scicon.cpp
...
Enclose MakeSingleColorImage in an anonymous namespace to avoid a
unused function warning on Windows and MacOSX.
Github-Pull: #6143
2015-05-19 11:27:54 +02:00
Cory Fields
d1a3866e0b
build: Cope with spaces in filenames when creating/applying OSX sigs
2015-05-19 11:03:54 +02:00
Jonas Schnelli
7cef321e65
[Mac only] rename Bitcoin-Qt.app to "Bitcoin Core.app"
2015-05-19 11:03:49 +02:00
Wladimir J. van der Laan
be31ff7d8d
doc: Add historical release notes for 0.10.1 0.10.2 0.9.4
2015-05-18 20:48:09 +02:00
Wladimir J. van der Laan
a5a521e842
Merge pull request #6154
...
b448002
[Docs] fix and improve REST documentation (Jonas Schnelli)
2015-05-18 20:18:52 +02:00
Jonas Schnelli
b448002772
[Docs] fix and improve REST documentation
...
- fix bad formatting of getutxos
- added getztxos example
- fix different command syntax
2015-05-18 16:52:01 +02:00
Wladimir J. van der Laan
26e08a16a6
Merge pull request #6126
...
2457dc4
Change default nTxConfirmTarget to 2 (Alex Morcos)
77ed59d
wallet: Introduce constant for `-txconfirmtarget` default (Wladimir J. van der Laan)
2015-05-18 09:07:02 +02:00
Alex Morcos
2457dc43ac
Change default nTxConfirmTarget to 2
2015-05-18 09:01:30 +02:00
Wladimir J. van der Laan
77ed59df4d
wallet: Introduce constant for -txconfirmtarget
default
2015-05-18 09:00:24 +02:00
Wladimir J. van der Laan
a6d2e31e8b
Merge pull request #6144
...
881027a
Remove assertion from ~LockedPageManager (Wladimir J. van der Laan)
2015-05-18 07:53:09 +02:00
Wladimir J. van der Laan
ec81395a4c
Merge pull request #6150
...
3a6cc3c
Missing from Documentation Index (Shawn Wilkinson)
2015-05-18 07:52:19 +02:00
Gavin Andresen
3c60937ce6
Merge pull request #6146
...
f501054
More robust CScheduler unit test (Gavin Andresen)
2015-05-16 18:03:26 -04:00
Gavin Andresen
f50105486f
More robust CScheduler unit test
...
On a busy or slow system, the CScheduler unit test could fail because it
assumed all threads would be done after a couple of milliseconds.
Replace the hard-coded sleep with CScheduler stop() method that
will cleanly exit the servicing threads when all tasks are completely
finished.
2015-05-16 17:59:23 -04:00
Shawn Wilkinson
3a6cc3cbb6
Missing from Documentation Index
2015-05-16 12:00:50 -04:00
Wladimir J. van der Laan
ec82d8c99c
Merge pull request #6062
...
ff7fe8b
Fix for correctly including climits on certain platforms {DragonFlyBSD}. (sinetek)
2015-05-16 10:48:49 +02:00
Wladimir J. van der Laan
97ccfdca8a
Merge pull request #6137
...
a5baba5
minor: remove unneeded bool in CWalletDB::Recover (Philip Kaufmann)
2015-05-16 09:37:01 +02:00
Wladimir J. van der Laan
2a822987dd
Merge pull request #6129
...
c208040
Fix for clearing fCheckForPruning (Alex Morcos)
2015-05-15 17:32:54 +02:00
Jorge Timón
935bd0a447
Chainparams: Refactor: Decouple main::GetBlockValue() from Params() [renamed GetBlockSubsidy]
...
Remove redundant getter CChainParams::SubsidyHalvingInterval()
2015-05-15 16:12:30 +02:00
Wladimir J. van der Laan
ac75bafafd
qt: translations update
2015-05-15 14:00:56 +02:00
Wladimir J. van der Laan
e47c94e64c
Merge pull request #6135
...
f13dac9
Comment edits and cleanup (BitcoinPRReadingGroup)
ff734e9
Alphabetic order in makefile (Jorge Timón)
5207f33
fix header include groups (Philip Kaufmann)
59b149f
remove unneeded incude of wallet/db.h from rpcmining.cpp (Philip Kaufmann)
3703385
remove unused classes from db.h (Philip Kaufmann)
0a7bcb7
fix IDE/compiler warning "extra ';'" in validationinterface.h (Philip Kaufmann)
3b00e7c
[Trivial] Update COPYING (sandakersmann)
dd9e688
Trivial: Corrected owner of DNS seeder (ayeowch)
a60bfd8
[init] better message when no wallet support is compiled in (Philip Kaufmann)
78f44b6
Capitalized P2P (sandakersmann)
8e9248d
[Trivial] Cryptocurrency is one word (sandakersmann)
803f51e
Typo in GetRawMemPool RPC method help: "]" --> "}" (Chris Arnesen)
605a735
addrman: update comments (Pavel Vasin)
2015-05-15 13:59:07 +02:00
Alex Morcos
c208040354
Fix for clearing fCheckForPruning
...
Previously this was cleared only after UnlinkPrunedFiles, but it should really be cleared after FindFilesToPrune, regardless of whether there are any files to be pruned.
2015-05-15 07:58:41 -04:00
Wladimir J. van der Laan
f0043c2d6d
Merge pull request #5968
...
51aa249
Chainparams: Refactor: Decouple IsSuperMajority from Params() (Jorge Timón)
2015-05-15 13:52:54 +02:00
Wladimir J. van der Laan
6fb90d8983
Merge pull request #6102
...
86a5f4b
Relocate calls to CheckDiskSpace (Alex Morcos)
67708ac
Write block index more frequently than cache flushes (Pieter Wuille)
b3ed423
Cache tweak and logging improvements (Pieter Wuille)
fc684ad
Use accurate memory for flushing decisions (Pieter Wuille)
046392d
Keep track of memory usage in CCoinsViewCache (Pieter Wuille)
540629c
Add memusage.h (Pieter Wuille)
2015-05-15 13:43:02 +02:00
Wladimir J. van der Laan
63e7016566
Merge pull request #6140
...
8f0947b
Increase timeouts in pruning.py and modify warning language. (Alex Morcos)
b89f307
Fix incorrect variable name in FindFilesToPrune (Suhas Daftuar)
2015-05-15 13:37:31 +02:00
Wladimir J. van der Laan
16e8ea3dde
Merge pull request #6045
...
cc3db87
doc: Documentation in Markdown for Depends Dir (Shawn Wilkinson)
2015-05-15 12:35:58 +02:00
Shawn Wilkinson
cc3db874b5
doc: Documentation in Markdown for Depends Dir
...
Documentation more readable when viewed on Github.
Some extra changes by @laanwj:
- Make README.usage the default README. This is more convenient from a
user perspective. Link to other documentation in this default README
- Add list of popular targets for cross compilation, change default to
Win64 instead of Win32
2015-05-15 12:35:20 +02:00
Wladimir J. van der Laan
881027a79d
Remove assertion from ~LockedPageManager
...
This assertion will occur any time that the client quits without
shutting down properly due to an error condition. As the user will
report this error instead of the error that was the root cause, it is
better to remove it.
2015-05-15 11:44:58 +02:00
Gavin Andresen
b4c219b622
Merge pull request #5964
...
9a1dcea
Use CScheduler for net's DumpAddresses (Gavin Andresen)
ddd0acd
Create a scheduler thread for lightweight tasks (Gavin Andresen)
68d370b
CScheduler unit test (Gavin Andresen)
cfefe5b
scheduler: fix with boost <= 1.50 (Cory Fields)
ca66717
build: make libboost_chrono mandatory (Cory Fields)
928b950
CScheduler class for lightweight task scheduling (Gavin Andresen)
e656560
[Qt] add defaultConfirmTarget constant to sendcoinsdialog (Philip Kaufmann)
2015-05-14 14:27:07 -04:00
Gavin Andresen
9a1dcea2df
Use CScheduler for net's DumpAddresses
...
Instead of starting Yet Another Thread to dump addresses,
use CScheduler to do it.
2015-05-14 12:50:42 -04:00
Gavin Andresen
ddd0acd3db
Create a scheduler thread for lightweight tasks
2015-05-14 12:50:41 -04:00
Gavin Andresen
68d370bec4
CScheduler unit test
2015-05-14 12:50:41 -04:00
Wladimir J. van der Laan
339321522c
Merge pull request #6136
...
235b3a7
depends: sanity-check sources and cached builds (Cory Fields)
2015-05-14 17:51:00 +02:00
Cory Fields
cfefe5b88c
scheduler: fix with boost <= 1.50
2015-05-14 10:37:19 -04:00