MarcoFalke
0b738075bd
Merge #9297 : Various RPC help outputs updated
...
54ee3fc
RPC help updated (Michael Rotarius)
2017-01-12 02:11:04 +01:00
Pieter Wuille
db904db7e6
Deprecate non-txindex getrawtransaction and better warning
2017-01-11 15:34:13 -08:00
Matt Corallo
0df777db6d
Use a temp pindex to avoid a const_cast in ProcessNewBlockHeaders
2017-01-11 14:47:52 -08:00
Jeremy Rubin
aad4cb5059
Address ryanofsky feedback on CCheckQueue benchmarks. Eliminated magic numbers, fixed scoping of vectors (and memory movement component of benchmark).
2017-01-11 17:05:06 -05:00
Pieter Wuille
05950427d3
Merge #9507 : Fix use-after-free in CTxMemPool::removeConflicts()
...
fe7e593
Fix use-after-free in CTxMemPool::removeConflicts() (Suhas Daftuar)
2017-01-11 13:59:00 -08:00
Michael Rotarius
54ee3fcb8f
RPC help updated
2017-01-11 22:05:23 +01:00
Russell Yanofsky
918d1fb86b
Return height of last block pruned by pruneblockchain RPC
...
Change suggested by Jonas Schnelli <dev@jonasschnelli.ch> in
https://github.com/bitcoin/bitcoin/pull/7871#discussion_r95577623
2017-01-11 14:25:32 -05:00
Pieter Wuille
df3637177a
Update estimated transaction count data
2017-01-11 08:21:40 -08:00
Pieter Wuille
e356d9a758
Shorten variable names and switch to tx/s
2017-01-11 08:21:37 -08:00
Wladimir J. van der Laan
e2e624d9ce
Merge #7871 : Manual block file pruning.
...
afffeea
fixup! Add pruneblockchain RPC to enable manual block file pruning. (Russell Yanofsky)
1fc4ec7
Add pruneblockchain RPC to enable manual block file pruning. (mrbandrews)
2017-01-11 14:26:00 +01:00
Wladimir J. van der Laan
bbf193fef0
Merge #9513 : build: fix qt distdir builds (retry)
...
67ca130
build: fix for out-of-tree/distdir qt builds (Cory Fields)
2017-01-11 13:45:28 +01:00
Cory Fields
67ca130f73
build: fix for out-of-tree/distdir qt builds
2017-01-10 20:03:38 -05:00
Jeremy Rubin
45a5aaf147
Only call clear on prevector if it isn't trivially destructible and don't loop in clear
2017-01-10 18:23:10 -05:00
Jeremy Rubin
aaa02e7f24
Add prevector destructor benchmark
2017-01-10 18:23:00 -05:00
Alex Morcos
116419e58d
Don't overwrite validation state with corruption check
...
AcceptToMemoryPool has several classes of return false statements.
- return state.Invalid or state.DoS directly itself
- return false and set fMissingInputs (state is valid)
- return false and state is set by failed CheckTransaction
- return false and state is set by failed CheckInputs.
This commit patches the last case where the state variable was reused for additional calls to CheckInputs to identify witness stripping as cause of validation failure. After this commit, it should be the case that if !fMissingInputs, state is always Invalid if AcceptToMemoryPool returns false.
2017-01-10 16:53:10 -05:00
Suhas Daftuar
fe7e593b24
Fix use-after-free in CTxMemPool::removeConflicts()
2017-01-10 15:21:21 -05:00
Matt Corallo
863edb45b9
Consider all (<100k memusage) txn for compact-block-extra-txn cache
2017-01-10 14:48:42 -05:00
Matt Corallo
7f8c8cab1e
Consider all orphan txn for compact-block-extra-txn cache
2017-01-10 14:48:42 -05:00
Matt Corallo
93380c5247
Use replaced transactions in compact block reconstruction
2017-01-10 14:48:42 -05:00
Matt Corallo
1531652e02
Keep shared_ptrs to recently-replaced txn for compact blocks
2017-01-10 14:48:42 -05:00
Suhas Daftuar
766e8a40b4
[wallet] Add IsAllFromMe: true if all inputs are from wallet
2017-01-10 08:14:50 -05:00
Wladimir J. van der Laan
5754e0341b
Merge #8811 : rpc: Add support for JSON-RPC named arguments
...
4e7e2e1
Update RPC argument names (John Newbery)
481f289
rpc: Named argument support for bitcoin-cli (Wladimir J. van der Laan)
9adb4e1
rpc: Argument name consistency (Wladimir J. van der Laan)
8d713f7
rpc: Named arguments for rawtransaction calls (Wladimir J. van der Laan)
37a166f
rpc: Named arguments for wallet calls (Wladimir J. van der Laan)
78b684f
rpc: Named arguments for mining calls (Wladimir J. van der Laan)
b8ebc59
rpc: Named arguments for net calls (Wladimir J. van der Laan)
2ca9dcd
test: Add test for RPC named arguments (Wladimir J. van der Laan)
fba1a61
rpc: Named arguments for misc calls (Wladimir J. van der Laan)
286ec08
rpc: Add 'echo' call for testing (Wladimir J. van der Laan)
495eb44
rpc: Named arguments for blockchain calls (Wladimir J. van der Laan)
6f1c76a
rpc: Support named arguments (Wladimir J. van der Laan)
5865d41
authproxy: Add support for RPC named arguments (Wladimir J. van der Laan)
2017-01-10 14:14:50 +01:00
Russell Yanofsky
afffeea7d9
fixup! Add pruneblockchain RPC to enable manual block file pruning.
...
Extend pruneblockchain RPC to accept block timestamps as well as block indices.
2017-01-10 08:14:50 -05:00
mrbandrews
1fc4ec7bf2
Add pruneblockchain RPC to enable manual block file pruning.
2017-01-10 08:14:50 -05:00
Wladimir J. van der Laan
68eb56203b
qt: periodic translations update
2017-01-10 12:52:02 +01:00
John Newbery
4e7e2e16e4
Update RPC argument names
2017-01-10 12:04:54 +01:00
Wladimir J. van der Laan
481f289765
rpc: Named argument support for bitcoin-cli
...
Usage e.g.:
$ src/bitcoin-cli -testnet -named echo arg0="dfdf"
[
"dfdf"
]
Argument conversion also works, for arguments thus flagged in the table in
`src/rpc/client.cpp`.
$ src/bitcoin-cli -testnet -named echojson arg0="[1,2,3]"
[
[
1,
2,
3
]
]
Unknown parameter (detected server-side):
$ src/bitcoin-cli -testnet -named getinfo arg0="dfdf"
error code: -8
error message:
Unknown named parameter arg0
2017-01-10 12:04:54 +01:00
MarcoFalke
98c80e374b
Merge #9496 : Rename lambda argument name to prevent shadowing
...
7df5e38
Rename lambda argument name to prevent shadowing. (Pavel Janík)
2017-01-10 10:14:22 +01:00
Andrew Chow
6d8fe35b94
'help' rpc commands autocomplete
...
Adds autocompletion of the commands for when getting the help of a command by using `help <command>`
2017-01-09 21:23:16 -05:00
John Newbery
0c50909347
testcases: explicitly specify transaction version 1
2017-01-09 16:42:45 -05:00
Matt Corallo
edded808fc
Make ATMP optionally return the CTransactionRefs it replaced
2017-01-09 14:15:18 -05:00
Matt Corallo
c735540428
Move ORPHAN constants from validation.h to net_processing.h
2017-01-09 14:15:18 -05:00
Jeremy Rubin
9f03110f32
Add Basic CheckQueue Benchmark
2017-01-09 14:07:02 -05:00
Pavel Janík
7df5e382e5
Rename lambda argument name to prevent shadowing.
2017-01-09 19:31:19 +01:00
Pieter Wuille
07fd147b9f
Merge #9353 : Add data() method to CDataStream (and use it)
...
5113474
wallet: Use CDataStream.data() (Wladimir J. van der Laan)
e2300ff
bench: Use CDataStream.data() (Wladimir J. van der Laan)
adff950
dbwrapper: Use new .data() method of CDataStream (Wladimir J. van der Laan)
a2141e4
streams: Remove special cases for ancient MSVC (Wladimir J. van der Laan)
af4c44c
streams: Add data() method to CDataStream (Wladimir J. van der Laan)
2017-01-09 08:47:47 -08:00
Pieter Wuille
12e3112794
Merge #9404 : Smarter coordination of change and fee in CreateTransaction.
...
20449ef
Don't overpay fee if we have selected new coins that result in a smaller transaction. (Alex Morcos)
42f5ce4
Try to reduce change output to make needed fee in CreateTransaction (Alex Morcos)
2017-01-09 08:37:35 -08:00
Pieter Wuille
8c87f175d3
Merge #9310 : Assert FRESH validity in CCoinsViewCache::BatchWrite
...
dd44ea3
Check FRESH validity in CCoinsViewCache::BatchWrite (Russell Yanofsky)
2017-01-09 08:01:08 -08:00
Matt Corallo
e6111b2398
Make peer id logging consistent ("peer=%d" instead of "peer %d")
2017-01-07 16:19:34 -05:00
Douglas Roark
cc0589639c
Remove stray semicolon (Fix empty body warning)
...
Empty body introduced by commit #9319 should not be empty.
2017-01-07 09:49:14 -08:00
Pieter Wuille
46b249e578
Merge #9408 : Allow shutdown during LoadMempool, dump only when necessary
...
325e400
[Qt] Do proper shutdown (Jonas Schnelli)
9479f8d
Allow shutdown during LoadMempool, dump only when necessary (Jonas Schnelli)
2017-01-06 09:37:43 -08:00
Pieter Wuille
a55716abe5
Merge #9319 : Break addnode out from the outbound connection limits.
...
032ba3f
RPC help documentation for addnode peerinfo. (Gregory Maxwell)
90f13e1
Add release notes for addnode changes. (Gregory Maxwell)
50bd12c
Break addnode out from the outbound connection limits. (Gregory Maxwell)
2017-01-06 08:37:47 -08:00
Alex Morcos
20449ef09e
Don't overpay fee if we have selected new coins that result in a smaller transaction.
...
On repeated calls to SelectCoins we try to meet the fee necessary for the last transaction, the new fee required might be smaller, so increase our change by the difference if we can.
2017-01-06 10:18:56 -05:00
Alex Morcos
42f5ce4093
Try to reduce change output to make needed fee in CreateTransaction
...
Once we've picked coins and dummy-signed the transaction to calculate fee, if we don't have sufficient fee, then try to meet the fee by reducing change before resorting to picking new coins.
2017-01-06 10:12:05 -05:00
Jonas Schnelli
c5adf8f267
[Qt] Show more significant warning if we fall back to the default fee
2017-01-06 10:49:49 +01:00
Pieter Wuille
f646275b90
Merge #9138 : Improve fee estimation
...
44b64b9
Fix edge case with stale fee estimates (Alex Morcos)
78ae62d
Add clarifying comments to fee estimation (Alex Morcos)
5fe0f47
Add extra logging to processBlock in fee estimation. (Alex Morcos)
dc008c4
Add IsCurrentForFeeEstimatation (Alex Morcos)
ebafdca
Pass pointers to existing CTxMemPoolEntries to fee estimation (Alex Morcos)
d825838
Always update fee estimates on new blocks. (Alex Morcos)
6f06b26
rename bool to validFeeEstimate (Alex Morcos)
84f7ab0
Remove member variable hadNoDependencies from CTxMemPoolEntry (Alex Morcos)
60ac00d
Don't track transactions at all during IBD. (Alex Morcos)
4df4479
Remove extraneous LogPrint from fee estimation (Alex Morcos)
2017-01-05 14:22:19 -08:00
Pieter Wuille
c252685aa5
Merge #8610 : Share unused mempool memory with coincache
...
ba3cecf
Share unused mempool memory with coincache (Pieter Wuille)
2017-01-05 13:52:24 -08:00
Pieter Wuille
a7d55c9338
Merge #9465 : [Wallet] Do not perform ECDSA signing in the fee calculation inner loop.
...
b3d7b1c
Wallet: Do not perform ECDSA in the fee calculation inner loop. (Gregory Maxwell)
2017-01-05 13:37:03 -08:00
Matt Corallo
c1ae4fcf7d
Avoid holding cs_most_recent_block while calling ReadBlockFromDisk
2017-01-05 15:16:34 -05:00
Jonas Schnelli
fd7d8c7b35
Merge #9413 : [CoinControl] Allow non-wallet owned change addresses
...
54f8026
[CoinControl] Allow non-wallet owned change addresses (Jonas Schnelli)
2017-01-05 21:00:06 +01:00
Wladimir J. van der Laan
a72f76ca3d
Merge #9312 : Increase mempool expiry time to 2 weeks
...
5f0e27f
Increase mempool expiry time to 2 weeks (Alex Morcos)
2017-01-05 20:32:57 +01:00