LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Packages Projects Releases 32 Wiki Activity
3196 commits 22 branches 42 tags 99 MiB
Commit graph

1954 commits

Author SHA1 Message Date
kjj2 31a8b70ee3 Add a backup warning to the encryptwallet RPC command 2012-09-30 08:50:59 -05:00
Philip Kaufmann 9c8dc7caf1 harmonize printf format characters 
- remove the "%" character from format characters for (s)size_t and
  ptrdiff_t and harmonize them with the ones for int64 and uint64
 2012-09-30 11:57:25 +02:00
Wladimir J. van der Laan 018ec85ff7 Merge pull request #1875 from hsoft/master 
Fix compilation with clang under OS X
 2012-09-29 02:23:46 -07:00
Wladimir J. van der Laan f72fd0e792 Merge pull request #1881 from xanatos/Tests 
Removed a duplicated identical if
 2012-09-29 01:00:55 -07:00
Wladimir J. van der Laan 552af52b45 Merge pull request #1851 from fanquake/OpenSSL-1.0.1c 
Update to use OpenSSL 1.0.1c
 2012-09-29 00:58:15 -07:00
Wladimir J. van der Laan 3b2eb49db9 Merge pull request #1883 from sipa/norandstack 
Remove stack randomization
 2012-09-29 00:56:25 -07:00
Jeff Garzik 3e37e7eca4 Merge pull request #1871 from jgarzik/wallet-deadcode 
walletdb.h: remove dead code
 2012-09-28 17:05:16 -07:00
Pieter Wuille 2e3ffb2d82 Remove stack randomization 2012-09-28 21:53:28 +02:00
Pieter Wuille 842a31ad1b Merge pull request #1862 from kjj2/testports 
Fix: when testnet=1 specified, change default RPC port to 18332
 2012-09-28 08:03:45 -07:00
xanatos 50e01ee620 toHTML won't add empty wtx.mapValue elements 
As the code was before, toHTML added empty elements to mapValue to check for their existance. Now first it check for their existance and then for their non-emptiness.

Removed a duplicated identical if

There are two equal ifs, one inside another. If the first one is true, then the second one is true.
 2012-09-28 15:50:48 +02:00
Wladimir J. van der Laan 035cb4781d Merge pull request #1868 from maaku/and_or_xor_sign_extension 
Documented bug in sign-extension behavior of opcodes OP_AND, OP_OR, and OP_XOR
 2012-09-27 22:48:27 -07:00
Virgil Dupras fee10d800e Fixed compilation error with clang. 
Previously, trying to compile with clang would result in the error: assigning to 'objc_object *' from incompatible type 'DockIconClickEventHandler *'
 2012-09-27 15:06:16 -04:00
Wladimir J. van der Laan 14ac0adcc7 Remove -Wformat* warnings from makefiles 
commit 5a1a3622 effectively enabled these warnings, but they need
to be fixed before being enabled in the general build scripts.
 2012-09-27 04:10:21 +02:00
Jeff Garzik 189eb6a989 walletdb.h: remove dead code 2012-09-26 21:56:45 -04:00
Wladimir J. van der Laan 5a1a362215 Merge pull request #1807 from laanwj/2012_09_printf_warnings 
Add printf-style warnings to strprintf() and OutputDebugStringF()
 2012-09-25 22:56:29 -07:00
Mark Friedenbach 95d7f00295 Documented bug in sign-extension behavior of opcodes OP_AND, OP_OR, and OP_XOR. 
Due to a bug in the implementation of MakeSameSize(), using OP_AND, OP_OR, or OP_XOR with signed values of unequal size will result in the sign-value becoming part of the smaller integer, with nonsensical results. This patch documents the unexpected behavior and provides the basis of a solution should decision be made to fix the bug in the future.
 2012-09-25 16:40:34 -07:00
Jeff Garzik 1381ad2b21 Merge pull request #1684 from jgarzik/bootstrap 
Import $DataDir/bootstrap.dat automatically, if it exists.
 2012-09-25 13:53:40 -07:00
Wladimir J. van der Laan 4d369ec30c Update comment, we're no longer using boost::interprocess::scoped_lock 2012-09-25 12:16:37 +02:00
Wladimir J. van der Laan 1a52dd10a7 Merge pull request #1854 from Diapolo/fix_1843_V2 
additional fix for #1843
 2012-09-25 01:35:22 -07:00
kjj2 b202d43076 Fix: when testnet=1 specified, change default ports to 18332 and 18333 2012-09-24 15:26:04 -05:00
Jeff Garzik 22f9b06903 Send 'mempool' P2P command at the start of each P2P session 
to query remote node mempool contents.
 2012-09-24 13:53:44 -04:00
Jeff Garzik 52c90a2b2b Import $DataDir/bootstrap.dat automatically, if it exists. 
As discussed on IRC. Intended to make using an external blockchain download
solution just a bit easier.
 2012-09-24 13:37:03 -04:00
Jeff Garzik 93dd68e924 P2P: Do not request blocks from peers with fewer blocks than us 
If the remote node has a shorter chain, do not waste our
special getblocks request on them.
 2012-09-24 13:26:09 -04:00
Wladimir J. van der Laan feec18e329 Merge pull request #1836 from kjj2/stopdetach 
Adds a stopdetach <detach> RPC command.  <detach> defaults to true.  Wor...
 2012-09-23 05:49:42 -07:00
Wladimir J. van der Laan 49b09ec04f Merge pull request #1853 from fanquake/qt-include 
Update include for Qt5
 2012-09-23 05:35:24 -07:00
kjj2 3731f5788e Adds a stopdetach <detach> RPC command. <detach> defaults to true. Works just like stop, but overrides the commandline/config file 
-detachdb option.  Useful for upgrading, for example.  Lets you use fast stops usually, but force a detach when needed.  Also, allows
you to do a fast stop in a system normally configured for fast stops.
 2012-09-22 18:17:29 -05:00
fanquake ea9eaf9dec Update Qt include 
Update Qmenu include

This is to be more consistent with the rest of the source

Update Qt Includes
 2012-09-22 18:56:22 +08:00
Wladimir J. van der Laan 2f91373a0a Merge pull request #1852 from fanquake/bugreportlinks 
Update links to Qt
 2012-09-22 03:29:46 -07:00
Philip Kaufmann bb86cffa56 additional fix for #1843 
- a shortcut on "receive coins" was used twice
 2012-09-22 12:15:41 +02:00
fanquake e1eb3d4451 Update Bugreport Links 
Update Qt Links

Revert Qt source link

Update Qt links
 2012-09-22 18:05:25 +08:00
Wladimir J. van der Laan f394f21594 Merge pull request #1844 from Diapolo/Qt5_compat1 
enhance Qt5 compatibility
 2012-09-22 02:21:06 -07:00
fanquake 0eaaa83ba5 Update Bitcoin to use OpenSSL 1.0.1c 
Bump deps tp 0.0.5
Small docs corrections
 2012-09-22 14:51:03 +08:00
Wladimir J. van der Laan 38682648c2 Remove unnecessary text from tooltip in AddressBookPage 2012-09-22 08:37:56 +02:00
Philip Kaufmann da9413d913 fix #1843 by changing 2 GUI shortcuts 2012-09-21 19:31:53 +02:00
Philip Kaufmann 81605d90f5 enhance Qt5 compatibility 
- replace Q_WS_MAC (not supported anymore in Qt5) with Q_OS_MAC (supported
  in Qt4/5)
 2012-09-21 19:06:53 +02:00
Wladimir J. van der Laan e96a8c7d86 Merge pull request #1793 from Diapolo/fix_signed_unsigned_strprintf 
fix signed/unsigned in strprintf and CNetAddr::GetByte()
 2012-09-21 06:04:27 -07:00
Wladimir J. van der Laan 3ccbaa56f4 comment update: it's -> its 2012-09-21 14:15:26 +02:00
Wladimir J. van der Laan 1ba4925755 Merge pull request #1705 from Diapolo/cleanup_bitcoingui 
Qt: re-order GUI code and remove FIRST_CLASS_MESSAGING
 2012-09-20 23:08:52 -07:00
Wladimir J. van der Laan 2dca98511f Merge pull request #1810 from laanwj/2012_09_rpcconsole_eventfilter 
Improve RPC console key event behaviour
 2012-09-20 23:02:52 -07:00
Gavin Andresen f2b066da70 Update gitignore and Makefiles for build.h move from src/ to src/obj 2012-09-20 10:28:13 -04:00
Wladimir J. van der Laan bfc24bd4ce Merge pull request #1717 from Diapolo/Qt_change_TX_display 
Qt: show mined transactions at depth 1
 2012-09-20 00:42:31 -07:00
Gavin Andresen 6cbae37667 Merge branch 'testdata' of git://github.com/TheBlueMatt/bitcoin 2012-09-18 19:22:40 -04:00
Jeff Garzik b1d3e95a0a When rejected TX relay due to lack of fees, log full txid 2012-09-18 15:24:31 -04:00
Jeff Garzik ea0796bde3 Trim trailing whitespace for src/*.{h,cpp} 2012-09-18 15:07:58 -04:00
Gavin Andresen 8b371316c5 Merge branch 'master' of github.com:bitcoin/bitcoin 2012-09-18 12:20:01 -04:00
Gavin Andresen 8f09e4cac4 Give makefiles 'test' and 'check' targets to compile and run unit tests 2012-09-18 12:18:51 -04:00
Jeff Garzik f8c449b5c8 Merge pull request #1812 from jgarzik/misc-07 
Two minor generic cleanups done during OP_DROP hacking
 2012-09-18 09:14:53 -07:00
Gavin Andresen a0971337d0 Merge branch 'refactor_times' of git://github.com/luke-jr/bitcoin 2012-09-18 10:59:31 -04:00
Gavin Andresen 5add0b0d0f Bump client version to 0.7.0.99 now that 0.7.0 release is final. 2012-09-18 10:58:22 -04:00
Wladimir J. van der Laan 7fddf1210e update comment, secure_allocator is defined in allocators.h 2012-09-15 12:10:00 +02:00
Philip Kaufmann 463a1cab43 fix signed/unsigned in strprintf and CNetAddr::GetByte() 
- I checked every occurance of strprintf() in the code and used %u, where
  unsigned vars are used
- the change to GetByte() was made, as ip is an unsigned char
 2012-09-12 21:30:47 +02:00
Gavin Andresen 0a4e67afad Bump client version number for 0.7.0rc3 2012-09-12 14:07:22 -04:00
Pieter Wuille c1d79812f4 Do not abort if RPC listening for IPv6 fails 
Instead, fall back to IPv4 listening.
 2012-09-12 16:45:09 +02:00
Wladimir J. van der Laan 3b3d999618 Add format characters for (s)size_t and ptrdiff_t 2012-09-10 04:25:26 +02:00
Wladimir J. van der Laan ac4e7f6269 HexStr: don't build a vector<char> first 
Also const correctness for lookup tables in hex functions throughout the code.
 2012-09-10 04:24:57 +02:00
Gregory Maxwell ab91bf39b7 Apply BIP30 checks to all blocks except the two historic violations. 
Matt pointed out some time ago that there existed a minor DOS
attack where a node in its initial block download could be wedged
by an overwrite attack in a fork created between checkpoints before
a time where BIP30 was enforced. Now that the BIP30 timestamp
is irreversibly past the check can be more aggressive and apply to
all blocks except the two historic violations.
 2012-09-09 20:11:04 -04:00
Jeff Garzik 17f8d6e400 Improve debug logging, for mempool TXs that do not include sufficient fees 2012-09-09 17:05:26 -04:00
Jeff Garzik 76970091f1 Cosmetic: move CTransaction::GetMinFee out of header file 2012-09-09 17:01:18 -04:00
Wladimir J. van der Laan 62904b33f3 Improve RPC console key event behaviour 
- Paging using PageUp / PageDown now works when entry widget has focus
- Typing or pasting while the messages widget has focus auto-selects entry widget
 2012-09-09 20:44:59 +02:00
Wladimir J. van der Laan b019ea17ec Remove VC6 comment and pointless #ifdef'd benchmark code 
We're in a wholly different world now, C++-compiler-wise.

Current std::stringstream implementations don't have the stated problem anymore,
and are just as fast as CDataStream.

The #ifdef'd block does not even compile anymore; CDataStream constructor changed,
and missing some std::. Also timing in whole seconds is also way too granular
to say anything sensible in such microbenchmarks. Just remove it,
it can always be found again in git history.
 2012-09-09 17:24:00 +02:00
Wladimir J. van der Laan 963af6449f Cleanup some unused macros from util.h 
Encapsulate _snprintf/sprintf difference in implementation not header
 2012-09-09 15:47:29 +02:00
Wladimir J. van der Laan b0a90fbb0c Add printf-style warnings to strprintf() and OutputDebugStringF() 
This finds about ~150 potential problems with format characters on a 64 bit build.
 2012-09-09 14:47:31 +02:00
Wladimir J. van der Laan d8ecd21ff7 Merge pull request #1802 from luke-jr/bugfix_ts 
Update translations from Transifex (100% coverage for Finnish and Chinese (China)
 2012-09-09 00:04:03 -07:00
Luke Dashjr 85eb1e7e56 Update translations from Transifex (100% coverage for Finnish and Chinese (China) 2012-09-08 20:32:54 +00:00
Wladimir J. van der Laan 31fac119dc Merge pull request #1796 from luke-jr/bugfix_ts 
Various translation fixups and restorations
 2012-09-07 22:15:19 -07:00
Luke Dashjr 4ee706243c Partially Bugfix: Update English translation strings and translations from Transifex 
Bugfix: Correct doubled-up &amp;amp; in translations
Bugfix: Remove extra spaces after ampersand in translations (this fixes hotkeys)
Restore copyright translations, now split up
Restore old translations lost due to changes to English structure
	Skipped: ca_ES et eu_ES fr_CA (under 10% coverage)
 2012-09-08 04:59:13 +00:00
Luke Dashjr da7b8c1260 Bugfix: Initialize CWallet::nOrderPosNext on an empty wallet, and save it in db 2012-09-08 04:55:36 +00:00
Wladimir J. van der Laan db1967957d Merge pull request #1798 from xanatos/patch-19 
Wrong address added to collection in test (address1 instead of address2)
 2012-09-07 07:13:23 -07:00
Philip Kaufmann f875921176 Bitcoin-Qt (Windows only): add version info to Resource File 
- add version information to bitcoin-qt.rc, which is displayed on Windows, when looking in the executable properties and selecting "Details"
- introduce a new clientversion.h (used in bitcoin-qt.rc to generate
  version information), which takes only the version defines from
  version.h and is included in it (to allow usage with the windres rc-file
  compiler)
- move #define STRINGIFY(s) #s into clientversion.h as that is used in
  bitcoin-qt.rc and rename to DO_STRINGIZE(X)
- add #define STRINGIZE(X) DO_STRINGIZE(X), which is needed to convert the
  version defines into a version string in the rc-file
- this ensures we only need to update 1 file and have bitcoin-qt.exe
  version information

- for RC-file documentation see:
  http://msdn.microsoft.com/en-us/library/windows/desktop/aa381058%28v=vs.85%29.aspx
 2012-09-07 16:08:18 +02:00
xanatos af8c050bff Wrong address added to collection in test 
The wrong address is added to the collection. As was written a second copy of address1 was added (and so address2 was useless).
 2012-09-07 16:04:39 +03:00
Wladimir J. van der Laan f106491fa2 Merge pull request #1786 from jgarzik/select-fix 
select()'s first argument should be zero, if no file descriptors are selected
 2012-09-06 23:30:22 -07:00
Gavin Andresen 1913b6e2fc Fix double-paren typo 2012-09-06 16:29:59 -04:00
Matt Corallo 65786afb05 Add various tests for CTransaction::CheckTransaction() 2012-09-05 22:33:59 -04:00
Matt Corallo 1fcebc16c5 check tx.CheckTransaction for data-driven tx tests. 
(and change so that only one case has to fail to make a tx_invalid
test correct)
 2012-09-05 22:33:59 -04:00
Philip Kaufmann 4bd34b4966 replace 2x WSAGetLastError() with 1x WSAGetLastError() call 2012-09-05 22:20:26 +02:00
Jeff Garzik 2387944782 select(): Use precise fd presence check, rather than imprecise hSocketMax test 2012-09-05 16:01:28 -04:00
Gavin Andresen 8788221761 Bump version number for 0.7.0rc2 2012-09-05 12:38:37 -04:00
Gavin Andresen 91c218a1cb Merge branch 'testnet_alert' of git://github.com/gavinandresen/bitcoin-git 2012-09-05 11:38:38 -04:00
xanatos 4f76be1dc5 Correct LoadWallet() return value (false -> DB_LOAD_OK) 
Equivalent code. (false == 0 == DB_LOAD_OK). Fixes #1706.
 2012-09-05 11:32:13 +03:00
Jeff Garzik e271c1d3d0 Merge pull request #1789 from Diapolo/fix_double_Startuptime 
remove double logging of startup time, when !fLogTimestamps
 2012-09-04 23:39:15 -07:00
Philip Kaufmann 274b7ab123 remove double logging of startup time, when !fLogTimestamps 2012-09-05 08:36:50 +02:00
Philip Kaufmann 8d367c7e66 fix signed/unsigned usage in BlockFilePath() 2012-09-05 08:34:41 +02:00
Jeff Garzik 42613c97d5 Add block file naming helper, BlockFilePath() 2012-09-04 21:40:26 -04:00
Jeff Garzik dcb14198bb init.cpp: fix build error, and possibly-uninit'd warning 2012-09-04 12:24:08 -04:00
Jeff Garzik 38e8f282d2 Merge pull request #1427 from rebroad/StartTimeFix 
No need to log start time if it's already being done on every line.
 2012-09-04 09:10:47 -07:00
Jeff Garzik 2fd6f067db Merge pull request #1777 from laanwj/2012_09_eliminate_sprintf 
Remove last occurrence of potentially insecure function sprintf
 2012-09-04 09:00:02 -07:00
Jeff Garzik bec02998b4 Merge pull request #1779 from xanatos/patch-15 
Useless vector declaration
 2012-09-04 08:59:05 -07:00
Jeff Garzik 8c7b6c05db Merge pull request #1738 from laanwj/2012_08_boostthread 
implement CreateThread with boost::thread
 2012-09-04 08:53:05 -07:00
Wladimir J. van der Laan 9d7da11458 Merge pull request #1743 from xanatos/patch-14 
Changed nprev->pprev
 2012-09-03 08:11:36 -07:00
Wladimir J. van der Laan acbe4a1f32 Merge pull request #1728 from xanatos/patch-11 
Removed duplicated lock
 2012-09-03 08:00:18 -07:00
xanatos 89fbd1f11c Useless vector declaration 
The vector isn't referenced in the small code block it's declared. I don't see any "useful" side effect in its declaration.
 2012-09-03 17:53:27 +03:00
Wladimir J. van der Laan 9c80909452 Remove last occurrence of potentially insecure function sprintf. 
%d can return up to 11 characters. Move away from fixed buffer completely and
use our own safe function strprintf.
 2012-09-03 16:18:16 +02:00
Gavin Andresen eaf00a3a5d Merge pull request #1774 from luke-jr/refactor_times 
Bugfix: Require OrderedTxItems to provide properly scoped accounting entry list
 2012-09-02 16:47:58 -07:00
Wladimir J. van der Laan 4d0c2b6cf4 Merge pull request #1761 from Diapolo/timeout_desc 
add default value in -timeout description
 2012-09-02 06:19:10 -07:00
Luke Dashjr ddb709e9de Bugfix: Require OrderedTxItems to provide properly scoped accounting entry list 
OrderedTxItems returns a multimap of pointers, but needs a place to store the actual CAccountingEntries it points to.
It had been using a stack item, which was clobbered as soon as it returned, resulting in undefined behaviour.
This fixes at least bug #1768.
 2012-09-02 08:02:46 +00:00
Jeff Garzik 0e1be81a4a Merge pull request #1771 from luke-jr/bugfix_bip22_mode 
Bugfix: getblocktemplate: Accept optional "mode" parameter not being provided
 2012-09-01 12:30:13 -07:00
R E Broadley 016178132e No need to log start time if it's already being done on every line. 2012-09-01 14:24:33 +01:00
Luke Dashjr 0689a7eb9c Bugfix: getblocktemplate: Accept optional "mode" parameter not being provided 2012-09-01 07:12:56 +00:00
Wladimir J. van der Laan 9c94bdac06 RPC console: escaping within ' and " now handled differently 
Should now mimic bash quoting and escaping (see http://wiki.bash-hackers.org/syntax/quoting) exactly,
leaving out argument expansion and obscure syntax like $''.
 2012-09-01 09:08:38 +02:00
Gregory Maxwell ddbddcb31e Merge pull request #1758 from laanwj/2012_08_uiconsole_parsing 
Fix RPC console parser to handle escaped arguments more like bash
 2012-08-31 22:50:23 -07:00