Wladimir J. van der Laan
d31ad26550
qt: Add missing lock in WalletModel::listCoins
...
Another problem detected by cs_wallet lock detection (#3401 ).
2014-01-06 13:36:24 +01:00
Wladimir J. van der Laan
28352af060
qt: protect SetAddressBook with cs_wallet lock everywhere
2014-01-06 13:36:24 +01:00
Wladimir J. van der Laan
aaf8d15708
qt: Add missing LOCKs for locked coin functions
...
These don't aquire the wallet lock internally, so the caller has to do
it.
2014-01-06 10:34:34 +01:00
Wladimir J. van der Laan
4757e92318
qt: add missing cs_wallet lock in AddressTableModel::setData
...
duplicate check in AddressTableModel::setData accesses
wallet data structure as well as SetAddressBook without proper LOCK, fix this.
2014-01-06 10:34:33 +01:00
Wladimir J. van der Laan
7aedb91476
Merge pull request #3401
...
012ca1c
LoadWallet: acquire cs_wallet mutex before clearing setKeyPool (Wladimir J. van der Laan)
9569168
Document cs_wallet lock and add AssertLockHeld (Wladimir J. van der Laan)
19a5676
Use mutex pointer instead of name for AssertLockHeld (Wladimir J. van der Laan)
2014-01-06 10:34:01 +01:00
Wladimir J. van der Laan
ab086e0bd3
Merge pull request #3422
...
daa6b20
Unittests for uint256.h (Thomas Holenstein)
e85e19b
Changed Get64(.) to GetLow64() (Thomas Holenstein)
2014-01-06 10:29:08 +01:00
Wladimir J. van der Laan
a867f4556b
Merge pull request #3468
...
4d46da2
Update debian/ (Matt Corallo)
2014-01-06 10:23:25 +01:00
Wladimir J. van der Laan
16403b4275
Merge pull request #3474
...
aec55a0
"getnetworkhashps" with defaults was yielding "0", the hashrate is not 0. (Gregory Maxwell)
2014-01-05 10:43:10 +01:00
Wladimir J. van der Laan
51947e4972
Merge pull request #3480
...
340bff3
ui: Better tab order in send coins entry (Wladimir J. van der Laan)
2014-01-04 13:13:37 +01:00
Jeff Garzik
e8837b384d
Merge pull request #3481 from cdecker/bitcoinstats_seed
...
Added new DNS seed from bitcoinstats.com.
2014-01-03 06:53:08 -08:00
Christian Decker
cdc11b3228
Added new DNS seed from bitcoinstats.com.
2014-01-03 14:01:39 +01:00
Wladimir J. van der Laan
340bff34b7
ui: Better tab order in send coins entry
...
Pressing <tab> after entering a label now brings the focus to the
address entry, instead of the row of buttons. In my experience this
is more useful, as I usually want to paste an address after
entering the label.
The buttons are mostly useless anyway:
- Choosing a previously used address should be discouraged
- When I'm already using the keyboard the 'paste address' button is
useless - just use the Ctrl-V. Maybe it would be an idea to remove it
completely
- I usually don't want to remove the entry I'm typing now! So makes
sense to have it at the end of the tab chain.
2014-01-02 09:36:46 +01:00
Gregory Maxwell
aec55a073d
"getnetworkhashps" with defaults was yielding "0", the hashrate is not 0.
...
This was broken in 4c6d41b8b6
.
2013-12-29 03:14:06 -08:00
Matt Corallo
4d46da20ea
Update debian/
2013-12-27 22:09:37 -08:00
Thomas Holenstein
daa6b20e29
Unittests for uint256.h
...
Unit tests for uint256.h. The file uint160_tests.cpp is no longer
needed. The ad-hoc tests which were in uint256.h are also no longer
needed. The new tests achieve 100% coverage.
2013-12-25 11:07:21 +01:00
Thomas Holenstein
e85e19be06
Changed Get64(.) to GetLow64()
...
The function Get64(.) has a bug in case the width is not divisible by 64.
Since it is only ever used as Get64(0) this simply changes it to this
special case. Additionally, an assert is added, and a cast to prevent
a compiler error.
2013-12-25 11:07:21 +01:00
Wladimir J. van der Laan
6e7792003b
Merge pull request #3453
...
96e5f61
extend std::exception logging in txdb.cpp (Philip Kaufmann)
2013-12-24 10:06:58 +01:00
Wladimir J. van der Laan
086d7ec2b8
Merge pull request #3457
...
d78f35a
Explicitly ensure that wallet is unlocked in `importprivkey` (Wladimir J. van der Laan)
2013-12-24 09:43:05 +01:00
Wladimir J. van der Laan
362755d018
Merge pull request #3427
...
1ad2636
qt: Prevent non-functional GUI from popping up during Init (Wladimir J. van der Laan)
2013-12-23 09:53:30 +01:00
Wladimir J. van der Laan
d78f35a909
Explicitly ensure that wallet is unlocked in importprivkey
...
This makes for a more useful error reply (fixes #957 ).
2013-12-23 07:49:32 +01:00
Wladimir J. van der Laan
f46babc8c8
Merge pull request #3451
...
5fe19d6
qt: make wallet test consistent (Wladimir J. van der Laan)
2013-12-21 10:22:01 +01:00
Philip Kaufmann
96e5f61d6c
extend std::exception logging in txdb.cpp
2013-12-20 18:58:15 +01:00
Wladimir J. van der Laan
5fe19d640e
qt: make wallet test consistent
...
Add a function `WaitBlocks` to wait for blocks to propagate to all three
nodes, and use this instead of waiting a fixed time of one second.
Fixes #3445 .
2013-12-20 17:12:39 +01:00
Wladimir J. van der Laan
365350140a
Merge pull request #3391
...
3380713
[Qt] coin control change address handling update (Philip Kaufmann)
2013-12-20 16:23:33 +01:00
Wladimir J. van der Laan
9e508b5588
Merge pull request #3439
...
3c95599
init: add better formating for some command-line options (Philip Kaufmann)
2013-12-20 15:57:37 +01:00
Philip Kaufmann
3380713af5
[Qt] coin control change address handling update
...
- re-work change address handling so that default is CNoDestination(),
until a verified and known change address was entered (easier code flow)
- add a missing NULL pointer check for adresstablemodel
- add a missing text when opening coin control address selection for
priority and ensure the label is black
- add a missing . at the end of a sentence
2013-12-20 15:50:21 +01:00
Philip Kaufmann
3c955993a4
init: add better formating for some command-line options
2013-12-20 15:44:14 +01:00
Wladimir J. van der Laan
f498d43ee2
Merge pull request #3416
...
9e9056c
Remove -logtodebugger (Wladimir J. van der Laan)
2013-12-20 15:03:41 +01:00
Wladimir J. van der Laan
23981b1f47
Merge pull request #3369
...
6027b46
Add rpc command 'getunconfirmedbalance' to obtain total unconfirmed balance (Michael Bauer)
2013-12-20 14:43:01 +01:00
Wladimir J. van der Laan
326b5bb9d0
Merge pull request #3437
...
2ea980a
qt: Treat regtest as testnet (Wladimir J. van der Laan)
2013-12-20 11:20:36 +01:00
Wladimir J. van der Laan
2ea980a77c
qt: Treat regtest as testnet
...
No need to do anything special in the GUI for regtest mode,
but do treat it at testnet not mainnet to prevent confusion.
2013-12-20 11:18:50 +01:00
Wladimir J. van der Laan
cc661b4d7f
Merge pull request #3438
...
d2b6de0
qt: Make sure overviewpage button is pressed at startup (Wladimir J. van der Laan)
2013-12-20 09:35:10 +01:00
Wladimir J. van der Laan
d2b6de031f
qt: Make sure overviewpage button is pressed at startup
...
Due to walletframe changes, the overview page button is no longer
automatically selected at startup even though the overview page is shown.
2013-12-20 09:33:44 +01:00
Thomas Holenstein
df840de5da
Make bitcoin compile without wallet if "db_cxx.h" is not present
...
Moved includes of "db.h" into #ifdef ENABLE_WALLET blocks or remove
them.
2013-12-19 10:46:41 +01:00
Wladimir J. van der Laan
285cf7a1a6
Merge pull request #3412
...
c3a7f51
Move `verifymessage` from rpcwallet to rpcmisc (Wladimir J. van der Laan)
723a03d
Move `createmultisig` from rpcwallet to rpcmisc (Wladimir J. van der Laan)
452955f
Move `validateaddress` from rpcwallet to rpcmisc (Wladimir J. van der Laan)
cd7fa8b
Move `nTransactionFee` from main.cpp to wallet.cpp (Wladimir J. van der Laan)
a943bde
Move `settxfee` from rpcblockchain to rpcwallet (Wladimir J. van der Laan)
16bc9aa
Move `getinfo` from rpcnet to rpcmisc (Wladimir J. van der Laan)
652e156
add new RPC implementation file `rpcmisc.cpp` (Wladimir J. van der Laan)
2013-12-19 10:11:13 +01:00
Wladimir J. van der Laan
012ca1c9e4
LoadWallet: acquire cs_wallet mutex before clearing setKeyPool
...
Make the function mutex-aware, to prevent having to lock cs_wallet
at the call site in Init.
2013-12-19 10:00:58 +01:00
Wladimir J. van der Laan
956916806a
Document cs_wallet lock and add AssertLockHeld
...
Add locking assertions to wallet to all methods that
access internal fields and do not aquire the cs_wallet mutex.
2013-12-19 09:46:11 +01:00
Wladimir J. van der Laan
19a5676280
Use mutex pointer instead of name for AssertLockHeld
...
This makes it useable for non-global locks such as the wallet and
keystore locks.
2013-12-19 09:46:11 +01:00
Wladimir J. van der Laan
636a42bd0e
Remove ui_interface ThreadSafeAskFee residue
...
Missed these in ca2c83d
(#3415 ).
2013-12-18 13:46:10 +01:00
Wladimir J. van der Laan
a5824bb3c6
Merge pull request #3433
...
6c1bf19
[Qt] style-police, add missing license headers (Philip Kaufmann)
2013-12-18 11:27:14 +01:00
Wladimir J. van der Laan
57fdd68aac
Merge pull request #3415
...
4a61c39
qt: status WalletModel::Aborted is no longer used (Wladimir J. van der Laan)
ca2c83d
Remove unused ThreadSafeAskFee from ui_interface (Wladimir J. van der Laan)
37e67d3
Remove unused ThreadSafeHandleURI from ui_interface (Wladimir J. van der Laan)
2013-12-18 08:56:37 +01:00
Wladimir J. van der Laan
03d9dd47f6
Merge pull request #3424
...
06eb2f2
Seperate out wallet options in help message (Wladimir J. van der Laan)
2013-12-18 08:15:18 +01:00
Wladimir J. van der Laan
97203994a4
Merge pull request #3381
...
7df07b3
[Qt] fix RecentRequestsTableModel function ambiuguity (Philip Kaufmann)
2013-12-18 07:27:05 +01:00
Wladimir J. van der Laan
c8af33aa75
Fix heading in README.md
2013-12-17 11:51:49 +01:00
Wladimir J. van der Laan
5ac8b6eeaa
Merge pull request #3435
...
9c6546c
Rebrand README.md (Wladimir J. van der Laan)
2013-12-17 10:09:28 +01:00
Wladimir J. van der Laan
cf920b657d
Merge pull request #3405
...
55c6890
Squashed 'src/leveldb/' changes from 936b461..e991315 (Pieter Wuille)
2013-12-17 09:50:39 +01:00
Wladimir J. van der Laan
9c6546c90e
Rebrand README.md
...
How could I forgot this file...
2013-12-17 08:47:30 +01:00
Philip Kaufmann
6c1bf199ca
[Qt] style-police, add missing license headers
...
- add missing license headers in Mac files
- small code formating cleanups
2013-12-17 07:56:40 +01:00
Wladimir J. van der Laan
a549842499
Merge pull request #3431
...
131c3db
Fix typos in spendfrom README (Lake Denman)
2013-12-17 07:30:48 +01:00
Wladimir J. van der Laan
8f5fd94497
Merge pull request #3434
...
46469d0
some more small re-branding changes (Bitcoin Core) (Philip Kaufmann)
2013-12-17 07:29:53 +01:00