Pieter Wuille
5b2ea29cf4
Merge #8594 : Do not add random inbound peers to addrman.
...
eb3596f
2016-09-07 13:19:53 +02:00
Pieter Wuille
e2a1a1ee89
Merge #8606 : Fix some locks
...
144ed76
2016-09-07 13:10:10 +02:00
Hampus Sjöberg
c015634400
qt: Adding transaction size to transaction details window
2016-09-06 22:31:36 +02:00
Hampus Sjöberg
fdf82fba31
Adding method GetTotalSize() to CTransaction
...
GetTotalSize() returns the total transaction size (including witness) in
bytes.
2016-09-06 22:30:30 +02:00
Jeremy Rubin
426e7bce0e
Fix obvious assignment/equality error in test
2016-09-06 16:22:13 -04:00
Jeremy Rubin
f71d4a3786
Minimal fix to slow prevector tests as stopgap measure
2016-09-06 16:19:25 -04:00
Wladimir J. van der Laan
d077f43f7e
Merge #8663 : trivial: remove unnecessary variable fDaemon
...
ff2ed7a
2016-09-06 15:20:08 +02:00
Pieter Wuille
34521e4d7d
Do not store witness txn in rejection cache
2016-09-05 17:48:56 +02:00
Pieter Wuille
e82fb872ff
Merge #8651 : Predeclare PrecomputedTransactionData as struct
...
4424af5
2016-09-05 13:30:09 +02:00
Suhas Daftuar
c40b034327
Clear witness with vin/vout in CWallet::CreateTransaction()
2016-09-04 20:09:13 -04:00
mruddy
ff2ed7a5bc
trivial: remove unnecessary variable fDaemon
2016-09-04 11:42:07 -04:00
Gregory Maxwell
6d0ced1865
Do not set an addr time penalty when a peer advertises itself.
...
Claims a peer makes about itself are inherently more credible.
2016-09-03 10:24:37 +00:00
Pavel Janík
7c069a7093
Do not shadow global variable
2016-09-02 20:50:59 +02:00
Wladimir J. van der Laan
cbe9ae8c69
Merge #8466 : [Trivial] Do not shadow variables in networking code
...
b7c349d
2016-09-02 12:51:56 +02:00
Wladimir J. van der Laan
381d0ddc8a
Merge #8449 : [Trivial] Do not shadow local variable, cleanup
...
a159f25cce3024
2016-09-02 12:25:59 +02:00
Pieter Wuille
4424af5190
Predeclare PrecomputedTransactionData as sturct
2016-09-02 11:43:06 +02:00
Wladimir J. van der Laan
6f939c9080
Merge #8629 : C++11: s/boost::scoped_ptr/std::unique_ptr/
...
cdd79eb
2016-09-02 09:56:33 +02:00
Jorge Timón
cdd79eb70f
C++11: s/boost::scoped_ptr/std::unique_ptr/
2016-09-01 19:05:07 +02:00
Pieter Wuille
854f1af22e
Make the dummy argument to getaddednodeinfo optional
2016-09-01 16:27:30 +02:00
Wladimir J. van der Laan
f061415d12
Merge #8638 : rest.cpp: change HTTP_INTERNAL_SERVER_ERROR to HTTP_BAD_REQUEST
...
f012a85
2016-09-01 15:58:43 +02:00
Wladimir J. van der Laan
0e563d89c0
Merge #8472 : Do not shadow LOCK's criticalblock variable for LOCK inside LOCK
...
33d15a3
2016-09-01 14:42:00 +02:00
Pieter Wuille
19b0f33de0
Merge #8524 : Precompute sighashes
...
35fe039ab48c5ed2c5d04
2016-09-01 12:20:43 +02:00
djpnewton
f012a857f5
rest.cpp: change HTTP_INTERNAL_SERVER_ERROR to HTTP_BAD_REQUEST
2016-09-01 22:12:19 +12:00
Wladimir J. van der Laan
84decb54f2
Merge #8612 : Check for compatibility with download in FindNextBlocksToDownload
...
887919c
2016-08-31 17:59:56 +02:00
Wladimir J. van der Laan
abc677c9a9
Merge #8191 : Do not shadow variables in src/wallet
...
b175cb7
2016-08-31 16:40:29 +02:00
Wladimir J. van der Laan
5cac8b123e
Merge #8291 : [util] CopyrightHolders: Check for untranslated substitution
...
33336e1
2016-08-31 16:17:00 +02:00
Pavel Janík
b175cb755b
Do not shadow variables.
2016-08-31 16:16:05 +02:00
Wladimir J. van der Laan
0c8875d23b
Merge #8163 : Do not shadow global RPC table variable (tableRPC)
...
de1bbe3
2016-08-31 16:07:58 +02:00
Wladimir J. van der Laan
df3f12d409
Merge #8626 : Berkeley DB v6 compatibility fix
...
323a5fe
2016-08-31 14:42:45 +02:00
Johnson Lau
482f852da6
Implement NULLDUMMY softfork
2016-08-31 19:38:23 +08:00
Wladimir J. van der Laan
2b23dbaee5
Merge #8611 : Reduce default number of blocks to check at startup
...
203f212
2016-08-30 13:38:42 +02:00
Alexey Vesnin
323a5fe06a
Berkeley DB v6 compatibility fix
...
Fixes building error looking like this:
CXX wallet/libbitcoin_wallet_a-db.o
wallet/db.cpp: In member function ‘void CDBEnv::EnvShutdown()’:
wallet/db.cpp:46:16: error: call of overloaded ‘DbEnv(int)’ is ambiguous
DbEnv(0).remove(strPath.c_str(), 0);
^
wallet/db.cpp:46:16: note: candidates are:
In file included from wallet/db.h:21:0,
from wallet/db.cpp:6:
/usr/include/db_cxx.h:916:2: note: DbEnv::DbEnv(const DbEnv&)
DbEnv(const DbEnv &);
^
/usr/include/db_cxx.h:518:2: note: DbEnv::DbEnv(DB_ENV)
DbEnv(DB_ENV *dbenv);
^
/usr/include/db_cxx.h:516:2: note: DbEnv::DbEnv(u_int32_t)
DbEnv(u_int32_t flags);
^
Makefile:5780: recipe for target 'wallet/libbitcoin_wallet_a-db.o' failed
make[2]: ** [wallet/libbitcoin_wallet_a-db.o] Error 1
2016-08-30 09:00:55 +03:00
Pieter Wuille
01680195f8
Merge #8564 : [Wallet] remove unused code/conditions in ReadAtCursor
...
beef966
2016-08-29 16:16:23 +02:00
Wladimir J. van der Laan
a5bb6387f7
Merge #8607 : [doc] Fix doxygen off-by-one comments, fix typos
...
fafe7b3fa27c0afabfd5d67a5502
2016-08-28 16:06:03 +02:00
Pieter Wuille
05e1c85fb6
Merge #8573 : Set jonasschnellis dns-seeder filter flag
...
40a95cf
2016-08-28 13:17:30 +02:00
Pieter Wuille
203f2121be
Reduce default number of blocks to check at startup
2016-08-27 15:28:20 +02:00
Pieter Wuille
887919c7b7
Check for compatibility with download in FindNextBlocksToDownload
2016-08-26 21:44:44 +02:00
Pieter Wuille
144ed76ea0
Fix some locks
...
This makes sure that cs_filter is never held while taking cs_main
or CNode::cs_vSend.
2016-08-26 21:11:57 +02:00
Pieter Wuille
35fe0393f2
Rename to PrecomputedTransactionData
2016-08-26 18:44:10 +02:00
Pieter Wuille
9a0ed08b40
Merge #8109 : Do not shadow member variables
...
ff8d279
2016-08-26 18:13:22 +02:00
Wladimir J. van der Laan
12892dbb9f
Merge #8590 : Remove unused variables
...
fa6dc9f
2016-08-26 13:24:12 +02:00
Wladimir J. van der Laan
05fa823bf6
wallet: Add BIP125 comment for MAXINT-1/-2 behavior
2016-08-26 12:57:28 +02:00
Peter Todd
152f45ba58
Add option to opt into full-RBF when sending funds
2016-08-26 12:10:42 +02:00
Jonas Schnelli
e3245b43d5
[Qt] add out-of-sync modal info layer
2016-08-26 11:34:30 +02:00
Wladimir J. van der Laan
65837375d9
Merge #8581 : [wallet] rpc: Drop misleading option
...
fab5ecb
2016-08-26 11:21:55 +02:00
Wladimir J. van der Laan
c19f8a4a77
Merge #8583 : Show XTHIN in GUI
...
4c3e2cb
2016-08-26 11:20:36 +02:00
Wladimir J. van der Laan
6c9f1b8c24
Merge #8561 : Show "end" instead of many zeros when getheaders request received with a hashStop of Null
...
259ee09
2016-08-26 10:04:26 +02:00
Jonas Schnelli
e47052f6b5
[Qt] ClientModel add method to get the height of the header chain
2016-08-26 09:53:09 +02:00
Jonas Schnelli
a001f18802
[Qt] Always pass the numBlocksChanged signal for headers tip changed
2016-08-26 09:53:09 +02:00
Jonas Schnelli
bd44a04dc3
[Qt] make Out-Of-Sync warning icon clickable
2016-08-26 09:53:09 +02:00
Jonas Schnelli
0904c3cda4
[Refactor] refactor function that forms human readable text out of a timeoffset
2016-08-26 09:53:09 +02:00
Gregory Maxwell
eb3596f7c2
Do not add random inbound peers to addrman.
...
We should learn about new peers via address messages.
An inbound peer connecting to us tells us nothing about
its ability to accept incoming connections from us, so
we shouldn't assume that we can connect to it based on
this.
The vast majority of nodes on the network do not accept
incoming connections, adding them will only slow down
the process of making a successful connection in the
future.
Nodes which have configured themselves to not announce would prefer we
not violate their privacy by announcing them in GETADDR responses.
2016-08-25 23:48:59 +00:00
MarcoFalke
fa8b02d36d
[rpc] rawtx: Prepare fLimitFree to make it an option
2016-08-25 15:28:04 +02:00
MarcoFalke
fa28bfa341
[wallet] Set fLimitFree = true
2016-08-25 15:27:48 +02:00
Pieter Wuille
53f8f226bd
Merge #8462 : Move AdvertiseLocal debug output to net category
...
f13c1ba
2016-08-25 15:15:16 +02:00
Pavel Janík
de1bbe3b78
Do not shadow global RPC table variable (tableRPC)
2016-08-25 15:02:26 +02:00
MarcoFalke
fa6dc9f0e5
Remove unused variables
2016-08-25 14:59:38 +02:00
Jonas Schnelli
0606f95b1e
Merge #7579 : [Qt] show network/chain errors in the GUI
...
2f32c82
2016-08-25 14:55:26 +02:00
Jonas Schnelli
d26234a9e2
Merge #8487 : Persist the datadir after option reset
...
57acb8215df3c1
2016-08-25 11:42:57 +02:00
MarcoFalke
95a983d56d
Merge #8578 : [test] Remove unused code
...
fa1cf9e
2016-08-25 11:00:21 +02:00
Wladimir J. van der Laan
026c6edac9
Merge #8282 : net: Feeler connections to increase online addrs in the tried table.
...
dbb1f64
2016-08-25 10:48:24 +02:00
R E Broadley
4c3e2cb2df
Show XTHIN in GUI
2016-08-25 09:22:46 +07:00
MarcoFalke
fa1cf9e7b8
[test] Remove unused code
2016-08-24 20:21:31 +02:00
MarcoFalke
fab5ecb771
[wallet] rpc: Drop misleading option
2016-08-24 19:28:04 +02:00
Andrew Chow
57acb82e70
Load choose datadir dialog after options reset
2016-08-24 09:40:48 -04:00
Jonas Schnelli
62a5a8a018
Merge #8463 : [qt] Remove Priority from coincontrol dialog
...
fa8dd78
2016-08-24 13:58:43 +02:00
Wladimir J. van der Laan
21857d2bf7
Merge #8450 : [Test] Replace rpc_wallet_tests.cpp with python RPC unit tests
...
957833325400c4
2016-08-24 12:10:42 +02:00
MarcoFalke
fa8dd785a2
[qt] Remove Priority from coincontrol dialog
2016-08-24 11:37:30 +02:00
Pieter Wuille
f12d2b5a8a
Merge #8560 : Trivial: Fix two VarInt examples in serialize.h
...
7bd5ff4
2016-08-24 10:42:08 +02:00
Wladimir J. van der Laan
f9167003d9
Merge #8445 : Move CWallet::setKeyPool to private section of CWallet.
...
8680d3ae86eb71
2016-08-24 10:33:16 +02:00
Jonas Schnelli
40a95cfd8f
Set jonasschnellis dns-seeder filter flag
2016-08-24 09:06:56 +02:00
Ethan Heilman
dbb1f640e6
Added feeler connections increasing good addrs in the tried table.
...
Tests if addresses are online or offline by briefly connecting to them. These short lived connections are referred to as feeler connections. Feeler connections are designed to increase the number of fresh online addresses in tried by selecting and connecting to addresses in new. One feeler connection is attempted on average once every two minutes.
This change was suggested as Countermeasure 4 in
Eclipse Attacks on Bitcoin’s Peer-to-Peer Network, Ethan Heilman,
Alison Kendler, Aviv Zohar, Sharon Goldberg. ePrint Archive Report
2015/263. March 2015.
2016-08-23 16:26:42 -04:00
Jonas Schnelli
beef966e36
[Wallet] remove unused code/conditions in ReadAtCursor
2016-08-23 15:36:23 +02:00
Jonas Schnelli
15860448d3
[Qt] RPC-Console: support nested commands and simple value queries
...
Commands can be executed with bracket syntax, example: `getwalletinfo()`.
Commands can be nested, example: `sendtoaddress(getnewaddress(), 10)`.
Simple queries are possible: `listunspent()[0][txid]`
Object values are accessed with a non-quoted string, example: [txid].
Fully backward compatible.
`generate 101` is identical to `generate(101)`
Result value queries indicated with `[]` require the new brackets syntax.
Comma as argument separator is now also possible: `sendtoaddress,<address>,<amount>`
Space as argument separator works also with the bracket syntax, example: `sendtoaddress(getnewaddress() 10)
No dept limitation, complex commands are possible:
`decoderawtransaction(getrawtransaction(getblock(getbestblockhash())[tx][0]))[vout][0][value]`
2016-08-23 15:32:39 +02:00
R E Broadley
259ee09f88
Show "end" instead of many zeros when getheaders request received with a hashStop of Null.
2016-08-23 13:14:07 +07:00
Christian Barcenas
7bd5ff4623
Trivial: Fix two VarInt examples in serialize.h
2016-08-22 20:49:36 -04:00
Wladimir J. van der Laan
41d8e78f94
Merge #8539 : CDB: fix debug output
...
fab2e26
2016-08-22 16:40:08 +02:00
MarcoFalke
fa27c0a2c4
[doc] Fix typos in comments, doxygen: Fix comment syntax
2016-08-22 10:51:41 +02:00
Wladimir J. van der Laan
67a55025a1
init: Fix typo in help message for -whitelistforcerelay
...
Reported by pryds on Transifex in the Danish translation.
2016-08-22 10:51:13 +02:00
Wladimir J. van der Laan
37e77c106c
Merge #8554 : trivial: remove unused variable
...
4207630
2016-08-22 10:36:37 +02:00
Wladimir J. van der Laan
bb0f763a25
Merge #8558 : Add copyright header to wallet_text_fixture.cpp
...
653bb3d
2016-08-22 10:32:30 +02:00
Wladimir J. van der Laan
a55a018d5f
Merge #8548 : [wallet] Use __func__ to get function name for output printing
...
fa785d1
2016-08-22 09:58:28 +02:00
Wladimir J. van der Laan
653bb3d640
Add copyright header to wallet_text_fixture.cpp
...
I created the file but forgot to add this header.
2016-08-22 09:24:50 +02:00
Patrick Strateman
8680d3aa80
Move wallet initialization logic from AppInit2 to CWallet::InitLoadWallet
2016-08-20 14:03:47 -07:00
Daniel Kraft
4207630f5a
trivial: remove unused variable
...
Remove the unused variable "blockTmp" in CMerkleTx::SetMerkleBranch. It
was previously used to read the block from disk if not provided as
argument, but is no longer needed.
2016-08-20 10:28:06 +02:00
MarcoFalke
fa785d1211
Use __func__ to get function name for output printing
2016-08-19 18:59:00 +02:00
Jonas Schnelli
2468292a03
Merge #8517 : [Qt] show wallet HD state in statusbar
...
914154f
2016-08-19 18:47:49 +02:00
Jonas Schnelli
56ac046960
Merge #8443 : [Wallet] Trivial cleanup of HD wallet changes
...
7e5d94d
2016-08-19 18:39:19 +02:00
Jonas Schnelli
7e5d94df1f
[Wallet] Trivial cleanup of HD wallet changes
2016-08-19 16:23:37 +02:00
Wladimir J. van der Laan
f4e777819c
Merge #8461 : document return value of networkhashps for getmininginfo RPC endpoint
...
65f4532
2016-08-19 12:18:42 +02:00
Jonas Schnelli
914154f0cc
[Qt] add HD enabled/disabled icon to the status bar
2016-08-19 09:21:04 +02:00
Wladimir J. van der Laan
b4a9aa511c
qt: Fix random segfault when closing "Choose data directory" dialog
...
The `pickDataDirectory()` function was calling `exit(0)` to quit
the application when the user closes the dialog without choosing
a data directory.
This is a bad idea because a background thread is created (to
check free space on the drive of the currently selected datadir).
The thread is not stopped and unwound properly, resulting in a potential
race condition somewhere deep in Qt.
So replace the `exit()` by a boolean return value, and let the
stack unwind normally.
2016-08-18 16:58:25 +02:00
crowning-
fab2e26d20
CDB: fix debug output
...
It doesn't really help to clear a variable before printing it to the debug log.
2016-08-18 16:52:38 +02:00
Pieter Wuille
8250de1358
Merge #8453 : Bring secp256k1 subtree up to date with master
...
b213535
2016-08-18 13:53:41 +02:00
Patrick Strateman
e86eb71604
Move CWallet::setKeyPool to private section of CWallet
2016-08-17 15:24:57 -07:00
Wladimir J. van der Laan
e753eaeb34
Merge #8505 : Trivial: Fix typos in various files
...
1aacfc2
2016-08-17 12:51:16 +02:00
Wladimir J. van der Laan
65e6444181
Merge #8513 : Fix a type error that would not compile on OSX.
...
8194a6e
2016-08-17 12:32:58 +02:00
Wladimir J. van der Laan
29496fc9e0
Merge #8512 : Trivial: Corrected JSON typo on setban of net.cpp
...
6ffd996
2016-08-17 12:01:46 +02:00
Nicolas DORIER
ab48c5e721
Unit test for sighash caching
2016-08-16 15:37:56 +02:00
Pieter Wuille
d2c5d044d0
Precompute sighashes
...
Original version by Nicolas Dorier. Precomputing version by Pieter Wuille.
2016-08-16 15:35:45 +02:00
Wladimir J. van der Laan
0237096df5
Merge commit 'b2135359b3ad37cf2ac09b008079ddb237eff2c9'
2016-08-16 11:34:43 +02:00
Wladimir J. van der Laan
b2135359b3
Squashed 'src/secp256k1/' changes from 6c527ec..7a49cac
...
7a49cac Merge #410 : Add string.h include to ecmult_impl
0bbd5d4 Add string.h include to ecmult_impl
c5b32e1 Merge #405 : Make secp256k1_fe_sqrt constant time
926836a Make secp256k1_fe_sqrt constant time
e2a8e92 Merge #404 : Replace 3M + 4S doubling formula with 2M + 5S one
8ec49d8 Add note about 2M + 5S doubling formula
5a91bd7 Merge #400 : A couple minor cleanups
ac01378 build: add -DSECP256K1_BUILD to benchmark_internal build flags
a6c6f99 Remove a bunch of unused stdlib #includes
65285a6 Merge #403 : configure: add flag to disable OpenSSL tests
a9b2a5d configure: add flag to disable OpenSSL tests
b340123 Merge #402 : Add support for testing quadratic residues
e6e9805 Add function for testing quadratic residue field/group elements.
efd953a Add Jacobi symbol test via GMP
fa36a0d Merge #401 : ecmult_const: unify endomorphism and non-endomorphism skew cases
c6191fd ecmult_const: unify endomorphism and non-endomorphism skew cases
0b3e618 Merge #378 : .gitignore build-aux cleanup
6042217 Merge #384 : JNI: align shared files copyright/comments to bitcoinj's
24ad20f Merge #399 : build: verify that the native compiler works for static precomp
b3be852 Merge #398 : Test whether ECDH and Schnorr are enabled for JNI
aa0b1fd build: verify that the native compiler works for static precomp
eee808d Test whether ECDH and Schnorr are enabled for JNI
7b0fb18 Merge #366 : ARM assembly implementation of field_10x26 inner (rebase of #173 )
001f176 ARM assembly implementation of field_10x26 inner
0172be9 Merge #397 : Small fixes for sha256
3f8b78e Fix undefs in hash_impl.h
2ab4695 Fix state size in sha256 struct
6875b01 Merge #386 : Add some missing `VERIFY_CHECK(ctx != NULL)`
2c52b5d Merge #389 : Cast pointers through uintptr_t under JNI
43097a4 Merge #390 : Update bitcoin-core GitHub links
31c9c12 Merge #391 : JNI: Only call ecdsa_verify if its inputs parsed correctly
1cb2302 Merge #392 : Add testcase which hits additional branch in secp256k1_scalar_sqr
d2ee340 Merge #388 : bench_ecdh: fix call to secp256k1_context_create
093a497 Add testcase which hits additional branch in secp256k1_scalar_sqr
a40c701 JNI: Only call ecdsa_verify if its inputs parsed correctly
faa2a11 Update bitcoin-core GitHub links
47b9e78 Cast pointers through uintptr_t under JNI
f36f9c6 bench_ecdh: fix call to secp256k1_context_create
bcc4881 Add some missing `VERIFY_CHECK(ctx != NULL)` for functions that use `ARG_CHECK`
6ceea2c align shared files copyright/comments to bitcoinj's
70141a8 Update .gitignore
7b549b1 Merge #373 : build: fix x86_64 asm detection for some compilers
bc7c93c Merge #374 : Add note about y=0 being possible on one of the sextic twists
e457018 Merge #364 : JNI rebased
86e2d07 JNI library: cleanup, removed unimplemented code
3093576a JNI library
bd2895f Merge pull request #371
e72e93a Add note about y=0 being possible on one of the sextic twists
3f8fdfb build: fix x86_64 asm detection for some compilers
e5a9047 [Trivial] Remove double semicolons
c18b869 Merge pull request #360
3026daa Merge pull request #302
03d4611 Add sage verification script for the group laws
a965937 Merge pull request #361
83221ec Add experimental features to configure
5d4c5a3 Prevent damage_array in the signature test from going out of bounds.
419bf7f Merge pull request #356
03d84a4 Benchmark against OpenSSL verification
git-subtree-dir: src/secp256k1
git-subtree-split: 7a49cacd3937311fcb1cb36b6ba3336fca811991
2016-08-16 11:34:11 +02:00
instagibbs
edb6cf1432
remove no-longer-used InitError logic
2016-08-15 10:28:53 -04:00
MarcoFalke
6e5e5abba6
Merge #8270 : Tests: Use portable #! in python scripts (/usr/bin/env)
...
7b01ce2#7723 (Matthew King)
873e81f
2016-08-15 15:45:20 +02:00
Jonas Schnelli
c503863150
Merge #8192 : [trivial] Remove URLs from About dialog translations
...
208d37f
2016-08-15 15:36:42 +02:00
Pavel Janík
b7c349d5e7
Do not shadow variables in networking code
2016-08-15 14:10:07 +02:00
Wladimir J. van der Laan
1030fa718c
Merge #8128 : Net: Turn net structures into dumb storage classes
...
9e9d644894538421ba40721e5b961017b8ab6c3ff3f96c7c431d6b1d
2016-08-15 13:35:27 +02:00
Pieter Wuille
d727f77e39
Merge #7946 : Reduce cs_main locks during ConnectTip/SyncWithWallets
...
b3b3c2a
2016-08-15 11:56:37 +02:00
Jeremy Rubin
8194a6e525
Fix a type error that would not compile on Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
2016-08-14 20:45:46 -04:00
leijurv
1aacfc2da5
various typos
2016-08-14 07:57:11 -06:00
Sev
6ffd996b8e
Corrected JSON typo on setban of net.cpp
2016-08-14 15:36:22 +03:00
Wladimir J. van der Laan
3859072963
Merge #8353 : Trivial: tiny c++11 refactors
...
c7840865e187e7947913f
2016-08-13 15:55:09 +02:00
Cory Fields
9e9d644f51
net: fixup nits
2016-08-12 14:22:49 -04:00
Jonas Schnelli
b3b3c2a562
Reduce cs_main locks during ConnectTip/SyncWithWallets
2016-08-12 14:53:10 +02:00
Wladimir J. van der Laan
0d0abcac1e
Merge #8481 : Qt: Fix minimize and close bugs
...
05242e9
2016-08-11 15:23:05 +02:00
Andrew Chow
15df3c196b
Persist the datadir after option reset
...
After a reset is performed, the datadir setting is saved and readded to the settings so that it is persisted across option resets.
2016-08-10 15:09:19 -04:00
Wladimir J. van der Laan
edebf425a2
Merge #8489 : Bugfix: Use pre-BIP141 sigops until segwit activates (GBT)
...
239cbd2160f895
2016-08-10 09:21:34 +02:00
MarcoFalke
fa5d276c90
[init] ParameterInteraction() iff wallet enabled
2016-08-10 08:40:57 +02:00
whythat
c784086075
use std::map::emplace() instead of std::map::insert()
2016-08-09 03:11:45 +03:00
whythat
5e187e7001
use c++11 std::unique_ptr instead of boost::shared_ptr
2016-08-09 03:11:45 +03:00
whythat
947913fc54
use std::map::erase(const_iterator, const_iterator) to get non-constant iterator
2016-08-09 03:11:28 +03:00
Luke Dashjr
160f895a80
Bugfix: Use pre-BIP141 sigops until segwit activates
2016-08-08 21:56:32 +00:00
Patrick Strateman
9578333ec4
Remove rpc_wallet_tests.cpp
2016-08-07 19:30:20 -07:00
adlawren
05242e937d
Fix minimize and close bugs
...
refs #8225
To ensure the GUI closes when the "Minimize on close" window option is disabled, and the "Minimize to the tray instead of the taskbar" window option is enbaled, remove a check made against the "Minimize to the tray instead of the taskbar" value, made during GUI closure.
To ensure the GUI minimizes to the taskbar when the "Minimize on close" window option is enabled, and the "Minimize to the tray instead of the taskbar" window option is disabled, minimize the GUI and ignore the closure event.
2016-08-06 23:58:30 -07:00
Pavel Janík
33d15a3a76
Do not shadow LOCK's criticalblock variable for LOCK inside LOCK
2016-08-06 10:54:29 +02:00
Pavel Janík
4a35e0f34c
Do not shadow members in dbwrapper
2016-08-05 21:17:50 +02:00
Pavel Janík
a159f25e19
Remove redundand (and shadowing) declaration
2016-08-05 20:03:01 +02:00
Michael Rotarius
f13c1bae52
Move AdvertiseLocal debug output to net category
2016-08-05 18:34:32 +02:00
Jameson Lopp
65f4532f13
document return value of networkhashps for getmininginfo RPC endpoint
2016-08-05 04:04:07 -04:00
Cory Fields
8945384bca
net: Have LookupNumeric return a CService directly
...
Also fix up a few small issues:
- Lookup with "badip:port" now sets the port to 0
- Don't allow assert to have side-effects
2016-08-04 16:41:39 -04:00
Wladimir J. van der Laan
f97d335942
Merge #8392 : Fix several node initialization issues
...
9d4eb9aaa59f2e0fd2a33
2016-08-04 12:33:21 +02:00
Wladimir J. van der Laan
37d83bb0a9
Merge #8391 : Consensus: Remove ISM
...
122786d
2016-08-04 12:20:35 +02:00
Pavel Janík
cce3024c23
Do not shadow local variable, cleanup
2016-08-03 20:35:29 +02:00
Wladimir J. van der Laan
194110fb91
Merge #8189 : rename mapAddrCount to mapNetGroupNodes
...
657fc19
2016-08-03 11:50:45 +02:00
Wladimir J. van der Laan
ced2d5ef7c
Merge #8446 : [Trivial] BIP9 parameters on regtest cleanup
...
0fc00be115265b
2016-08-03 11:05:29 +02:00
Wladimir J. van der Laan
fc93486d2a
Merge #8428 : Update README.md inside of src/test/
...
b8db185
2016-08-03 11:00:30 +02:00
Pavel Janík
0fc00bea5d
Do not shadow previous local variable
2016-08-02 10:26:54 +02:00
Pavel Janík
115265bb10
Trivial: bip -> BIP in help text and comment
2016-08-02 10:26:05 +02:00
Wladimir J. van der Laan
63c03dd41c
Merge #8418 : Add tests for compact blocks
...
45c7ddd9a22a6ca8689fd9c8593d56c87e9
2016-08-02 08:26:57 +02:00
Wladimir J. van der Laan
ea268747b6
Merge #8419 : Enable size accounting in mining unit tests
...
8bfd708
2016-08-01 10:42:31 +02:00
Pieter Wuille
c7e05b35ab
Merge #8432 : Make CWallet::fFileBacked private.
...
29c2d99
2016-08-01 02:12:47 +02:00
Pieter Wuille
b9c1cd8184
Merge #8152 : [Wallet] Remove CWalletDB* parameter from CWallet::AddToWallet
...
5723bb4867f84200f09c9
2016-08-01 02:06:42 +02:00
Pieter Wuille
8ea7d31e38
Merge #8413 : Trivial: pass Consensus::Params& instead of CChainParams& in ContextualCheckBlock
...
c8664ee
2016-08-01 01:53:29 +02:00
Pieter Wuille
f798b891bc
Merge #8346 : Mempool: Use Consensus::CheckTxInputs direclty over main::CheckInputs
...
a6cc299
2016-08-01 00:09:14 +02:00
Pavel Janík
ff8d279a78
Do not shadow member variables
2016-07-31 20:55:09 +02:00
Cory Fields
21ba407a73
net: narrow include scope after moving to netaddress
...
Net functionality is no longer needed for CAddress/CAddrman/etc. now that
CNetAddr/CService/CSubNet are dumb storage classes.
2016-07-31 14:01:44 -04:00
Cory Fields
21e5b96ff4
net: move CNetAddr/CService/CSubNet out of netbase
2016-07-31 14:01:44 -04:00
Cory Fields
1017b8a960
net: Add direct tests for new CSubNet constructors
2016-07-31 14:01:43 -04:00
Cory Fields
b6c3ff3dae
net: Split resolving out of CSubNet
2016-07-31 14:01:43 -04:00
Chris Stewart
b8db185952
Update README.md
...
Updating documentation for adding new unit test files
Removing unneeded sentence from README
Removing uint160_tests.cpp as it DNE
Formatting command line instructions to use ``
fixing 80 char formatting issue in README
fixing more nits
2016-07-31 12:43:45 -05:00
Cory Fields
f96c7c4d91
net: Split resolving out of CService
2016-07-31 13:24:07 -04:00
Cory Fields
31d6b1d5f0
net: Split resolving out of CNetAddr
2016-07-31 13:24:07 -04:00
Patrick Strateman
29c2d99bc9
Make CWallet::fFileBacked private.
2016-07-30 11:27:48 -07:00
Pieter Wuille
9d4eb9ad99
Do diskspace check before import thread is started
2016-07-30 02:17:51 +02:00
Pieter Wuille
aa59f2ed3f
Add extra message to avoid a long 'Loading banlist'
2016-07-30 02:17:51 +02:00
Pieter Wuille
0fd2a33648
Use a signal to continue init after genesis activation
2016-07-30 02:17:47 +02:00
Patrick Strateman
5723bb44ce
Remove unused pwalletdb from CWallet::AddToWallet
2016-07-29 17:04:14 -07:00
Patrick Strateman
867f842f1e
Remove CWalletDB* parameter from CWallet::AddToWallet
2016-07-29 17:04:14 -07:00
Patrick Strateman
00f09c920c
Split CWallet::AddToWallet into AddToWallet and LoadToWallet.
...
This removes the fFromLoadWallet flag in AddToWallet. These were already
effectively two methods.
2016-07-29 17:04:14 -07:00
Wladimir J. van der Laan
5c9e49d12c
net: Ignore notfound P2P messages
2016-07-29 17:44:01 +02:00
Pieter Wuille
9c8593d2b4
Implement SipHash in Python
2016-07-29 09:41:58 -04:00
Suhas Daftuar
56c87e9211
Allow changing BIP9 parameters on regtest
2016-07-29 09:41:58 -04:00
Wladimir J. van der Laan
7a2d402727
Merge #8274 : util: Update tinyformat
...
a5072a7695041e
2016-07-29 12:32:47 +02:00
Wladimir J. van der Laan
b77bb95b3c
Merge #8421 : httpserver: drop boost ( #8023 dependency)
...
7e87033d3773ca755aa05
2016-07-29 11:29:00 +02:00
Wladimir J. van der Laan
842bf8d2c5
Merge #8408 : Prevent fingerprinting, disk-DoS with compact blocks
...
1d06e491de2a46
2016-07-29 08:21:03 +02:00
Cory Fields
7e87033447
httpserver: replace boost threads with std
...
along with mutex/condvar/bind/etc.
httpserver handles its own interruption, so there's no reason not to use std
threading.
While we're at it, may as well kill the BOOST_FOREACH's as well.
2016-07-28 19:08:04 -04:00
Cory Fields
d3773ca9ae
httpserver: explicitly detach worker threads
...
When using std::thread in place of boost::thread, letting the threads destruct
results in a std::terminate. According to the docs, the same thing should be
be happening in later boost versions:
http://www.boost.org/doc/libs/1_55_0/doc/html/thread/thread_management.html#thread.thread_management.thread.destructor
I'm unsure why this hasn't blown up already, but explicitly detaching can't
hurt.
2016-07-28 19:07:23 -04:00
Cory Fields
755aa05174
httpserver: use a future rather than relying on boost's try_join_for
2016-07-28 19:07:15 -04:00
Pieter Wuille
ad087638ee
Merge #8412 : libconsensus: Expose a flag for BIP112
...
d12b732
2016-07-29 00:59:02 +02:00
Jorge Timón
a6cc299541
Mempool: Use Consensus::CheckTxInputs direclty over main::CheckInputs
2016-07-29 00:48:20 +02:00
Suhas Daftuar
8bfd70817b
Enable size accounting in mining unit tests
2016-07-28 14:27:19 -04:00
Wladimir J. van der Laan
133c727cc4
Merge #8321 : [trivial] Switched constants to sizeof()
...
fbc6070
2016-07-28 13:54:08 +02:00
Jonas Schnelli
2266b43e33
Port from 0.13: Create a new HD seed after encrypting the wallet
...
Forward-ports two commits from 0.13:
- [0.13] Create a new HD seed after encrypting the wallet
- [Wallet] Add CKeyMetadata record for HDMasterKey(s), factor out HD key generation
Github-Pull: #8389
Rebased-From: f142c11ac634df487cc4bc65a5f1c9a3e3563dd9 de45c065f0648c4c41b57cb492420ceeed29dd11
2016-07-28 13:22:33 +02:00
Wladimir J. van der Laan
806b9e7570
Merge #8332 : semi trivial: clarify witness branches in transaction.h serialization
...
e37b16a
2016-07-28 13:00:02 +02:00
Wladimir J. van der Laan
30a87c0747
Merge #8407 : [Qt] Add dbcache migration path
...
893f379
2016-07-28 11:28:42 +02:00
Jonas Schnelli
893f379ba0
[Qt] Add dbcache migration path
2016-07-28 10:57:24 +02:00
Wladimir J. van der Laan
64d660a43f
Merge #8348 : Trivial: Segwit: Don't call IsWitnessEnabled from ContextualCheckBlock
...
38c4c8b
2016-07-28 09:51:04 +02:00
Kaz Wesley
d3af342276
prepend license statement to indirectmap
...
Add statement about MIT licensing to indirectmap.h. I forgot the license
preamble when I originally wrote the file.
2016-07-27 16:27:07 -07:00
Jorge Timón
d12b732ac2
libconsensus: Expose a flag for BIP112
...
We added the segwit one, but we forgot CHECKSEQUENCEVERIFY
2016-07-28 00:23:03 +02:00
Jorge Timón
c8664eeac7
Trivial: pass Consensus::Params& instead of CChainParams& in ContextualCheckBlock
2016-07-27 23:58:04 +02:00
Wladimir J. van der Laan
4d4970fe53
Merge #8206 : [Wallet] Add HD xpriv to dumpwallet
...
77c912d
2016-07-27 15:25:34 +02:00
Jonas Schnelli
77c912d21c
[Wallet] add HD xpriv to dumpwallet
2016-07-27 15:19:23 +02:00
Suhas Daftuar
1d06e49834
Ignore CMPCTBLOCK messages for pruned blocks
...
Also ignores CMPCTBLOCK announcements that have too little work. This is to
prevent disk-exhaustion DoS.
2016-07-26 16:52:35 -04:00
Suhas Daftuar
1de2a46632
Ignore GETBLOCKTXN requests for unknown blocks
...
Don't disconnect peers, or else we leak information that could be
used for fingerprinting.
2016-07-26 16:50:48 -04:00
Wladimir J. van der Laan
4b1a4d8810
Merge #8381 : Make witness v0 outputs non-standard
...
c59c4341ffaff2
2016-07-26 14:24:11 +02:00
Wladimir J. van der Laan
618c9dd8c6
Merge #8365 : Treat high-sigop transactions as larger rather than rejecting them
...
ab942c1
2016-07-26 11:27:30 +02:00
Wladimir J. van der Laan
517eee3e8f
Merge #8362 : Scale legacy sigop count in CreateNewBlock
...
682aa0f
2016-07-25 18:08:09 +02:00
lizhi
cc021ef486
remove outdated legacy code
...
CheckSignatureElement is not used,it be replaced by eccrypto::CheckSignatureElement.
2016-07-24 10:49:07 +08:00
NicolasDorier
122786d0e0
Consensus: Remove ISM
2016-07-23 01:02:53 +09:00
Suhas Daftuar
c59c434b7d
qa: Add test for standardness of segwit v0 outputs
2016-07-23 00:01:02 +08:00
Johnson Lau
1ffaff2f74
Make witness v0 outputs non-standard before segwit activation
2016-07-22 06:35:07 +00:00
Jonas Schnelli
b50e1ac298
[Wallet] Correct hdmasterkeyid/masterkeyid name confusion
2016-07-21 21:58:12 +02:00
Wladimir J. van der Laan
381917f610
Merge #8347 : Trivial: Make CBlockIndex param const in ContextualCheckBlockHeader and ContextualCheckBlock
...
6f3d616
2016-07-21 14:31:40 +02:00
NicolasDorier
7821889bce
Consensus: Remove calls to error() from ContextualCheckBlock
2016-07-21 20:57:08 +09:00
Wladimir J. van der Laan
6f4092da80
Merge #8342 : Consensus: Trivial transform BOOST_FOREACH into for loop
...
a3e1984
2016-07-21 11:56:33 +02:00
fanquake
208d37f116
[trivial] Remove URLs from About dialog translations
2016-07-21 16:21:08 +08:00
Jonas Schnelli
2f32c82b3d
[Qt] show network/chain errors in the GUI
2016-07-20 14:42:19 +02:00
Patrick Strateman
6523fcaab2
Move SetMinVersion for FEATURE_HD to SetHDMasterKey
2016-07-19 22:30:17 -07:00
Pieter Wuille
ab942c15bd
Treat high-sigop transactions as larger rather than rejecting them
2016-07-19 12:31:49 +02:00
Wladimir J. van der Laan
045106b4f1
Merge #8367 : [Wallet] Ensure <0.13 clients can't open HD wallets
...
a4f137f
2016-07-19 12:13:12 +02:00
Thomas Snider
fbc60703a5
[trivial] Switched constants to sizeof()
2016-07-18 19:42:09 -07:00
Jonas Schnelli
a4f137f367
[Wallet] Ensure <0.13 clients can't open HD wallets
2016-07-18 22:56:45 +02:00
Suhas Daftuar
2c06bae39e
Rename "block cost" to "block weight"
2016-07-18 13:28:26 -04:00
Suhas Daftuar
682aa0f289
Scale legacy sigop count in CreateNewBlock
2016-07-18 12:42:41 -04:00
Wladimir J. van der Laan
6c0336c772
build: bump version to 0.13.99
...
Now that 0.13 branch has been split off, master is 0.13.99 (pre-0.14).
2016-07-18 12:22:18 +02:00
Wladimir J. van der Laan
e4382fbef5
qt: periodic translations update
2016-07-18 12:13:08 +02:00
Wladimir J. van der Laan
8cef5bd58a
mining: Improve -blockmaxcost help message
...
One-word replacement to #8354 .
2016-07-18 10:56:25 +02:00
Wladimir J. van der Laan
f5660d381a
Merge #8295 : Mining-related fixups for 0.13.0
...
c1d61fb27362ddd2e46e16dd4bc2f15c2cd
2016-07-18 08:23:45 +02:00
Wladimir J. van der Laan
238300b398
Merge #8323 : Add HD keypath to CKeyMetadata, report metadata in validateaddress
...
794508868d7682f708085986c223b1c7b245b95dd2
2016-07-18 07:58:33 +02:00
Wladimir J. van der Laan
37303934fe
Merge #8305 : Improve handling of unconnecting headers
...
e91cf4b96fa953
2016-07-18 07:46:12 +02:00
Jorge Timón
38c4c8b701
Trivial: Segwit: Don't call IsWitnessEnabled from ContextualCheckBlock
2016-07-17 02:41:58 +02:00
Jorge Timón
6f3d616dc8
Trivial: Make CBlockIndex param const in ContextualCheckBlockHeader and ContextualCheckBlock
2016-07-17 01:43:15 +02:00
NicolasDorier
a3e1984651
Consensus: Trivial transform BOOST_FOREACH into for loop
2016-07-16 11:08:52 +09:00
Jonas Schnelli
7945088d41
[Wallet] comsetic non-code changes for the HD feature
2016-07-15 10:34:08 +02:00
Jonas Schnelli
68d7682b9f
[Wallet] ensure CKeyMetadata.hdMasterKeyID will be cleared during SetNull()
2016-07-15 10:33:25 +02:00
Wladimir J. van der Laan
bc94b87487
Merge #8324 : [Wallet] keep HD seed during salvagewallet
...
b993671
2016-07-14 11:37:48 +02:00
Wladimir J. van der Laan
ca40ef6029
Merge #8312 : Fix mempool DoS vulnerability from malleated transactions
...
46c9620bb66a11
2016-07-14 08:21:13 +02:00
Wladimir J. van der Laan
4324bd237c
Merge #8311 : Rename CTxinWitness -> CTxInWitness
...
36ae37a
2016-07-14 08:18:38 +02:00
Wladimir J. van der Laan
1bc9c8085f
Merge #8271 : [bugfix] Do not send witnesses in cmpctblock
...
252675e
2016-07-14 08:17:22 +02:00
Daniel Cousens
e37b16a75c
transaction: clarify witness branches
2016-07-14 13:40:50 +10:00
Suhas Daftuar
96fa95361f
Improve handling of unconnecting headers
...
When processing a headers message that looks like a block announcement,
send peer a getheaders if the headers message won't connect.
Apply DoS points after too many consecutive unconnecting headers messages.
2016-07-12 13:12:40 -04:00
Wladimir J. van der Laan
4831a16223
qt: periodic translation update
...
Added languages:
- `bg_BG`: Bulgarian (Bulgaria)
2016-07-12 11:40:33 +02:00
Jonas Schnelli
b993671921
[Wallet] keep HD seed during salvagewallet
2016-07-09 12:58:03 +02:00
Jonas Schnelli
986c223214
[Wallet] print hd masterkeyid in getwalletinfo
2016-07-09 12:12:36 +02:00
Jonas Schnelli
b1c7b244e2
[Wallet] report optional HDKeypath/HDMasterKeyId in validateaddress
2016-07-09 12:12:32 +02:00
Jonas Schnelli
5b95dd2c25
[Wallet] extend CKeyMetadata with HD keypath
2016-07-09 11:52:17 +02:00
MarcoFalke
477777f250
[rpcwallet] Don't use floating point
2016-07-08 12:01:25 +02:00
Wladimir J. van der Laan
ff46dd4a34
Merge #7540 : Rename OP_NOP3 to OP_CHECKSEQUENCEVERIFY
...
18c975c14d0130
2016-07-08 11:39:10 +02:00
Suhas Daftuar
bb66a11396
Fix DoS vulnerability in mempool acceptance
...
Moves the IsStandard check to happen after the premature-witness check,
so that adding a witness to a transaction can't prevent mempool acceptance.
Note that this doesn't address the broader category of potential mempool DoS
issues that affect transactions after segwit activation.
2016-07-07 15:49:26 -04:00
Bob McElrath
36ae37a9f9
Rename CTxinWitness -> CTxInWitness
2016-07-06 19:46:46 -04:00
Jonas Schnelli
91abb77970
Merge #8288 : qt: Network-specific example address
...
4f44cb6
2016-07-06 15:45:17 +02:00
Wladimir J. van der Laan
b978701ba1
qt: periodic translations update
2016-07-06 07:59:07 +02:00
Wladimir J. van der Laan
396f9d6296
Merge #8273 : Bump -dbcache default to 300MiB
...
efd1d8332cab91
2016-07-06 07:46:47 +02:00
Wladimir J. van der Laan
32cab91278
Bump -dbcache default to 300MiB
...
Also cap the allocation for the leveldb-specific cache for the UTXO set
to 8MiB.
This avoids that the extra cache memory goes to the much less effective
leveldb cache instead of our application-level cache.
2016-07-06 07:44:51 +02:00
Wladimir J. van der Laan
042c323922
Merge #8275 : Remove bad chain alert partition check
...
ab8be98
2016-07-06 07:35:54 +02:00
Wladimir J. van der Laan
aef381161f
Merge #8298 : wallet: Revert input selection post-pruning
...
20f3cd7
2016-07-06 07:21:40 +02:00
Suhas Daftuar
c1d61fbd08
Add warning if -blockminsize is used.
2016-07-05 19:57:45 -04:00
Gregory Maxwell
4fbdc4365b
Revert "net: Avoid duplicate getheaders requests." PR #8054
...
This reverts commit f93c2a1b7e
2016-07-05 20:45:14 +00:00
MarcoFalke
33336e1aac
[util] CopyrightHolders: Check for untranslated substitution
...
Also, remove check which is always true
2016-07-02 10:46:26 +02:00
Wladimir J. van der Laan
20f3cd75f6
wallet: Revert input selection post-pruning
...
This reverts PR #4906 , "Coinselection prunes extraneous inputs from
ApproximateBestSubset".
Apparently the previous behavior of slightly over-estimating the set of
inputs was useful in cleaning up UTXOs.
See also #7664 , #7657 , as well as 2016-07-01 discussion on #bitcoin-core-dev IRC.
2016-07-01 13:26:01 +02:00
Suhas Daftuar
27362dda4d
Remove -blockminsize option
2016-06-30 11:41:13 -04:00
Suhas Daftuar
d2e46e1b5c
Remove addScoreTxs()
2016-06-30 11:37:38 -04:00
Suhas Daftuar
6dd4bc289c
Exclude witness transactions in addPackageTxs() pre-segwit activation
2016-06-30 11:24:32 -04:00
Wladimir J. van der Laan
975a41dcc2
windows: Add testnet icon for testnet link
...
Overhauled testnet icon by Jonas Schnelli
2016-06-30 17:17:58 +02:00
Wladimir J. van der Laan
4f44cb616d
qt: Network-specific example address
...
Generate an (invalid) example address for in the bitcoin address
widgets, based on the network prefix, instead of hardcoding a mainnet
address.
- `1NS17iag9jJgTHD1VXjvLCEnZuQ3rJDE9L` for mainnet (same as now)
- `n2wxQmfexkjwEPgdD6iJA7T7RtzkmHxhFc` for testnet
2016-06-29 17:35:54 +02:00
Wladimir J. van der Laan
a7897c02f7
qt: Remove client name from debug window
...
Remove the client name from the debug window in the GUI. It is already
part of the user agent, so adding it separately doesn't add anything.
2016-06-28 18:27:49 +02:00
BtcDrak
14d01309be
Rename OP_NOP3 to OP_CHECKSEQUENCEVERIFY
2016-06-28 17:17:36 +01:00
Wladimir J. van der Laan
3685e0c1da
Merge #8261 : The bit field is shown only when status is "started"
...
2129fce
2016-06-28 16:06:40 +02:00
Wladimir J. van der Laan
3b2dadc8d5
qt: Periodic translations update
2016-06-28 11:49:38 +02:00
Pavel Janík
2129fcea69
The bit field is shown only when status is "started"
2016-06-28 10:25:27 +02:00
