Alex Morcos
f9b9371c60
[rpc] Remove priorityDelta from prioritisetransaction
...
This a breaking API change to the prioritisetransaction RPC call which previously required exactly three arguments and now requires exactly two (hash and feeDelta). The function prioritiseTransaction is also updated.
2017-03-03 16:50:19 -05:00
Alex Morcos
49be7e1bef
[rpc] Remove priority information from mempool RPC calls
...
"startingpriority" and "currentpriority" are no longer returned in the JSON information about a mempool entry. This affects getmempoolancestors, getmempooldescendants, getmempooolentry, and getrawmempool.
2017-03-03 16:50:19 -05:00
Alex Morcos
0315888d0d
[test] Remove priority from tests
...
Remove all coin age priority functionality from unit tests and RPC tests.
2017-03-03 16:50:19 -05:00
Alex Morcos
f838005444
No longer allow "free" transactions
...
Remove -limitfreerelay and always enforce minRelayTxFee in the mempool (except from disconnected blocks)
Remove -relaypriority, the option was only used for the ability to allow free transactions to be relayed regardless of their priority. Both notions no longer apply.
2017-03-03 16:50:19 -05:00
Alex Morcos
ad727f4eaf
[rpc] sendrawtransaction no longer bypasses minRelayTxFee
...
The prioritisetransaction API can always be used if a transaction needs to be submitted that bypasses minRelayTxFee.
2017-02-27 11:23:51 -05:00
Alex Morcos
fe282acd76
[cleanup] Remove estimatePriority and estimateSmartPriority
...
Unused everywhere now except one test.
2017-02-27 11:23:51 -05:00
Alex Morcos
400b15147c
[debug] Change -printpriority option
...
-printpriority output is now changed to only show the fee rate and hash of transactions included in a block by the mining code.
2017-02-27 11:23:50 -05:00
Alex Morcos
272b25a6a9
[mining] Remove -blockprioritysize.
...
Remove ability of mining code to fill part of a block with transactions sorted by coin age.
2017-02-27 11:23:50 -05:00
Alex Morcos
12839cdd56
[rpc] Remove estimatepriority and estimatesmartpriority.
...
The RPC calls were already deprecated.
2017-02-27 11:23:50 -05:00
MarcoFalke
ddf58c7573
wallet: Remove sendfree
...
This removes the option from the wallet to not pay a fee on "small"
transactions which spend "old" inputs.
This code is no longer worth keeping around, as almost all miners
prefer not to include transactions which pay no fee at all.
2017-02-27 11:23:50 -05:00
Wladimir J. van der Laan
94e5ba9ba2
Merge #9875 : tests: Fix dangling pwalletMain pointer in wallet tests
...
75a1093
tests: Fix dangling pwalletMain pointer in wallet tests (Wladimir J. van der Laan)
Tree-SHA512: 7fb6e8385fe7d542f9ecb113a08d675ca9e84907a1939b3a6ad41318fda55bc999b9bc8ffc3f56cd8610ca49d0db982d3c793df7bbcb7eb9638f4483030db6a8
2017-02-27 13:38:51 +01:00
Wladimir J. van der Laan
75a109338f
tests: Fix dangling pwalletMain pointer in wallet tests
2017-02-27 13:15:39 +01:00
Wladimir J. van der Laan
c7e57ce981
Merge #9839 : [qa] Make import-rescan.py watchonly check reliable
...
864890a
[qa] Make import-rescan.py watchonly check reliable (Russell Yanofsky)
Tree-SHA512: ea0e2b1d4fc8f35174c3d575fb751b428daf6ad3aa944fad4e3ddcc9195e4f17051473acabc54203b1d27cca64cf911b737ab92e986c40ef384410652e2dbea1
2017-02-27 08:46:19 +01:00
Wladimir J. van der Laan
6206252e50
Merge #9847 : Extra test vector for BIP32
...
30aedcb
BIP32 extra test vector (Pieter Wuille)
2017-02-25 10:43:29 +01:00
Wladimir J. van der Laan
f19afdbfb4
Merge #9612 : [trivial] Rephrase the definition of difficulty.
...
dc222f8
Trivial: Rephrase the definition of difficulty in the code. (Karl-Johan Alm)
2017-02-24 12:48:56 +01:00
Wladimir J. van der Laan
dd6e0d6301
Merge #9833 : Trivial: fix comments referencing AppInit2
...
ef9f495
Trivial: fix comments referencing AppInit2 (Marko Bencun)
2017-02-24 10:53:32 +01:00
Wladimir J. van der Laan
00285cece8
Merge #9840 : Update sendfrom RPC help to correct coin selection misconception
...
f81f0d0
Update sendfrom RPC help to correct coin selection misconception (Russell Yanofsky)
2017-02-24 10:22:04 +01:00
Karl-Johan Alm
dc222f8f63
Trivial: Rephrase the definition of difficulty in the code.
2017-02-23 22:06:37 -08:00
Pieter Wuille
30aedcbdb4
BIP32 extra test vector
2017-02-23 17:59:52 -08:00
Marko Bencun
ef9f495e93
Trivial: fix comments referencing AppInit2
...
It was refactored into multiple functions in
0cc8b6bc44
.
2017-02-24 09:19:29 +09:00
Russell Yanofsky
864890adf5
[qa] Make import-rescan.py watchonly check reliable
...
Send payments during the test from a different node than the node generating
keys to be imported, so the spending node doesn't create transactions that
inadvertently involve (spend funds from) the imported keys.
Fixes #9826
2017-02-23 14:09:43 -05:00
Russell Yanofsky
f81f0d0030
Update sendfrom RPC help to correct coin selection misconception
2017-02-23 13:44:12 -05:00
Wladimir J. van der Laan
692c9eddba
Merge #9831 : build: force a c++ standard to be specified
...
9829c54
build: force a c++ standard to be specified (Cory Fields)
2017-02-23 19:03:14 +01:00
MarcoFalke
a13a417cdc
Merge #9823 : qa: Set correct path for binaries in rpc tests
...
3333ad0
qa: Set correct path for binaries in rpc tests (MarcoFalke)
2017-02-23 17:36:02 +01:00
MarcoFalke
d6064a89ac
Merge #9577 : Fix docstrings in qa tests
...
3f95a80
Fix docstrings in qa tests (John Newbery)
2017-02-23 16:39:22 +01:00
MarcoFalke
7146d96de3
Merge #9766 : Add --exclude option to rpc-tests.py
...
c578408
Add exclude option to rpc-tests.py (John Newbery)
2017-02-23 16:34:07 +01:00
John Newbery
3f95a806b1
Fix docstrings in qa tests
...
This commit fixes the module-level docstrings for the tests and helper
modules in qa. Many of these tests were uncommented previously - this
commit ensures that every test case has at least a minimum level of
commenting.
2017-02-23 10:31:04 -05:00
Wladimir J. van der Laan
e68c266f3d
Merge #9789 : build: add --enable-werror and warn on vla's
...
205830a
build: add --enable-werror option (Cory Fields)
b602fe0
build: warn about variable length arrays (Cory Fields)
2017-02-23 10:48:46 +01:00
Wladimir J. van der Laan
1d2a57e9fd
Merge #9824 : qa: Check return code when stopping nodes
...
fa4cd2e
qa: Check return code when stopping nodes (MarcoFalke)
2017-02-23 10:40:47 +01:00
Wladimir J. van der Laan
d14555de3d
Merge #9820 : Fix pruning test broken by 2 hour manual prune window
...
874c736
Fix pruning test broken by 2 hour manual prune window (Russell Yanofsky)
2017-02-23 10:38:26 +01:00
Cory Fields
205830a37b
build: add --enable-werror option
...
This turns some compiler warnings into errors. Useful for c-i.
2017-02-23 01:06:04 -05:00
MarcoFalke
fa4cd2e998
qa: Check return code when stopping nodes
...
This includes work by jnewbery
2017-02-23 03:05:43 +01:00
Cory Fields
9829c54de2
build: force a c++ standard to be specified
...
Newer compilers may switch to newer standards by default. For example, gcc6
uses std=gnu++14 by default.
2017-02-22 13:37:35 -05:00
Wladimir J. van der Laan
bed5b30a56
Merge #9711 : [Trivial] Remove incorrect help message from gettxoutproof()
...
9949ebf
[Trivial] Remove incorrect help message from gettxoutproof() (John Newbery)
2017-02-22 13:03:42 +01:00
Wladimir J. van der Laan
1efc99c4dc
Merge #9819 : Remove harmless read of unusued priority estimates
...
bc8fd12
Remove harmless read of unusued priority estimates (Alex Morcos)
2017-02-22 13:02:10 +01:00
Wladimir J. van der Laan
ba7220b5e8
Merge #9773 : Return errors from importmulti if complete rescans are not successful
...
e2e2f4c
Return errors from importmulti if complete rescans are not successful (Russell Yanofsky)
2017-02-22 12:43:11 +01:00
Wladimir J. van der Laan
a8c5751038
Merge #9801 : Removed redundant parameter from mempool.PrioritiseTransaction
...
eaea2bb
Removed redundant parameter from mempool.PrioritiseTransaction (gubatron)
2017-02-22 12:18:38 +01:00
Wladimir J. van der Laan
5b583efaa7
Merge #9805 : Add seed.btc.petertodd.org to mainnet DNS seeds
...
3b4dd2a
Add seed.btc.petertodd.org to mainnet DNS seeds (Peter Todd)
2017-02-22 12:14:37 +01:00
Wladimir J. van der Laan
92dd6c8dfd
Merge #9815 : Trivial: use EXIT_ codes instead of magic numbers
...
a87d02a
use EXIT_ codes instead of magic numbers (Marko Bencun)
2017-02-22 11:48:45 +01:00
MarcoFalke
3333ad0b63
qa: Set correct path for binaries in rpc tests
2017-02-22 10:49:02 +01:00
gubatron
eaea2bbb41
Removed redundant parameter from mempool.PrioritiseTransaction
...
(Also made the `const uint256 hash` parameter a `const uint256& hash` as suggested by @sdaftuar)
2017-02-21 20:44:23 -07:00
MarcoFalke
5628c70f2a
Merge #9807 : RPC doc fix-ups.
...
851f6a3
[qa][doc] Correct rpc test options in readme (fanquake)
41e7219
[trivial] Add tests_config.ini to .gitignore (fanquake)
2017-02-22 00:05:22 +01:00
Russell Yanofsky
874c7363d7
Fix pruning test broken by 2 hour manual prune window
...
Regression happened in 91fb506
Add two hour buffer to manual pruning.
2017-02-21 12:57:30 -05:00
Cory Fields
b602fe0f73
build: warn about variable length arrays
2017-02-21 11:56:07 -05:00
Wladimir J. van der Laan
61a640ea97
Merge #9485 : ZMQ example using python3 and asyncio
...
b471daf
Adddress nits, use asyncio signal handling, create_task (Bob McElrath)
4bb7d1b
Add python version checks and 3.4 example (Bob McElrath)
5406d51
Rewrite to not use Polling wrapper for asyncio, link to python2.7 example (Bob McElrath)
5ea5368
ZMQ example using python3 and asyncio (Bob McElrath)
2017-02-21 17:51:00 +01:00
Alex Morcos
bc8fd12289
Remove harmless read of unusued priority estimates
2017-02-21 11:12:44 -05:00
Wladimir J. van der Laan
5f0556d032
Merge #9727 : Remove fallbacks for boost_filesystem < v3
...
056aba2
Remove fallbacks for boost_filesystem < v3 (Wladimir J. van der Laan)
2017-02-21 17:08:37 +01:00
Wladimir J. van der Laan
8528d6ac6d
Merge #9817 : Fix segfault crash when shutdown the GUI in disablewallet mode
...
312c4f1
Fix segfault crash when shutdown the GUI in disablewallet mode (Jonas Schnelli)
2017-02-21 15:13:17 +01:00
Jonas Schnelli
312c4f1057
Fix segfault crash when shutdown the GUI in disablewallet mode
2017-02-21 14:37:20 +01:00
Wladimir J. van der Laan
8ad31f9aa3
Merge #9798 : Fix Issue #9775 (Check returned value of fopen)
...
40f11f8
Fix for issue #9775 . Added check for open() returning a NULL pointer. (kirit93)
2017-02-21 14:32:58 +01:00