LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues29 Pull requests1 Projects Releases32 Packages Wiki Activity

Add/reorganize unit tests for CClaimTrieCache/CClaimTrie #104

New issue
Closed
opened 2018-03-12 14:27:25 +01:00 by kaykurokawa · 4 comments
kaykurokawa commented 2018-03-12 14:27:25 +01:00 (Migrated from github.com)

We have decent coverage for integration testing the CClaimTrieCache together with CClaimTrie but we do not have any unit tests for testing them separately.

Especially for CClaimTrieCache, adding unit tests would help developers understand and debug the class. We'll have better confidence on the correctness of the code going forward.

Acceptance Criteria

Definition of Done

  • Tested against acceptance criteria
  • Tested against the assumptions of the user story
  • The project builds without errors
  • Unit tests are written and passing
  • Tests on devices/browsers listed in the issue have passed
  • QA performed & issues resolved
  • Refactoring completed
  • Any configuration or build changes documented
  • Documentation updated
  • Peer Code Review performed
We have decent coverage for integration testing the CClaimTrieCache together with CClaimTrie but we do not have any unit tests for testing them separately. Especially for CClaimTrieCache, adding unit tests would help developers understand and debug the class. We'll have better confidence on the correctness of the code going forward. ### Acceptance Criteria 1. 2. 3. ### Definition of Done - [ ] Tested against acceptance criteria - [ ] Tested against the assumptions of the user story - [ ] The project builds without errors - [ ] Unit tests are written and passing - [ ] Tests on devices/browsers listed in the issue have passed - [ ] QA performed & issues resolved - [ ] Refactoring completed - [ ] Any configuration or build changes documented - [ ] Documentation updated - [ ] Peer Code Review performed
kaykurokawa commented 2018-06-13 17:40:02 +02:00 (Migrated from github.com)

Some tests were added here: https://github.com/lbryio/lbrycrd/pull/105 but could use more

Some tests were added here: https://github.com/lbryio/lbrycrd/pull/105 but could use more
BrannonKing commented 2018-07-23 23:58:15 +02:00 (Migrated from github.com)

Waiting on 's proposed "separate PRs".

Waiting on #175 's proposed "separate PRs".
BrannonKing commented 2018-10-05 19:38:59 +02:00 (Migrated from github.com)

Having combined the two claimtrie unit test files as part of my other story to reuse unit test framework, I now agree with @lbrynaut 's comment about that being a bad move; I should have moved the unit test framework into its own file instead. The one unit test file is just too large (now knocking on 4k lines); it needs to be split into a number of smaller files.

Having combined the two claimtrie unit test files as part of my other story to reuse unit test framework, I now agree with @lbrynaut 's comment about that being a bad move; I should have moved the unit test framework into its own file instead. The one unit test file is just too large (now knocking on 4k lines); it needs to be split into a number of smaller files.
bvbfan commented 2019-09-11 13:13:44 +02:00 (Migrated from github.com)

#316
Sign in to join this conversation.
No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
Epic
good first issue
hacktoberfest
hard fork
help wanted
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
soft fork
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
work in progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#104
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?