nCurrentHeight in ClaimTrie and ClaimTrieCache needs to be renamed #138

New issue

Closed

opened 2018-05-14 19:08:46 +02:00 by kaykurokawa · 5 comments

kaykurokawa commented

2018-05-14 19:08:46 +02:00

(Migrated from github.com)

nCurrentHeight, a member variable in ClaimTrie and ClaimTrieCache, is not the actual current height.
It is the current height + 1 (i.e, if there is a total of two blocks including the genesis, nCurrentHeight is 2 where as the standard definition of current height would be 1) , or perhaps it can be called as the current height "to be worked on".

nNextHeight might be a better name.

nCurrentHeight, a member variable in ClaimTrie and ClaimTrieCache, is not the actual current height. It is the current height + 1 (i.e, if there is a total of two blocks including the genesis, nCurrentHeight is 2 where as the standard definition of current height would be 1) , or perhaps it can be called as the current height "to be worked on". nNextHeight might be a better name.

kauffj commented

2018-05-16 01:36:20 +02:00

(Migrated from github.com)

@kaykurokawa add comment until refactor happens?

bvbfan commented

2018-06-06 19:14:11 +02:00

(Migrated from github.com)

I can take it on my refactor branch, it's sound good?

bvbfan commented

2018-06-15 10:46:38 +02:00

(Migrated from github.com)

It is nNextHeight in my local branch i'll made pull request.