Improve logging by separating debug from information #144

New issue

Closed

opened 2018-05-23 05:53:31 +02:00 by shyba · 5 comments

shyba commented

2018-05-23 05:53:31 +02:00

(Migrated from github.com)

fDebug flag can be used for that like: 01a222a3c5/src/main.cpp (L5226-L5227)

It's initialized according to -debug setting: 270307a290/src/init.cpp (L860)

Ideally it should be applied to log messages that doesn't hold information for a sysadmin, but mainly for developers, like: https://github.com/lbryio/lbrycrd/blob/master/src/claimtrie.cpp#L1927

To be updated with more examples where it should be applied after #137 gets merged as it adds more cases.

`fDebug` flag can be used for that like: https://github.com/lbryio/lbrycrd/blob/01a222a3c5f730973c857ff9d13d032e6108462a/src/main.cpp#L5226-L5227 It's initialized according to `-debug` setting: https://github.com/lbryio/lbrycrd/blob/270307a29070a4c10095528e232ad0f8e251ec5a/src/init.cpp#L860 Ideally it should be applied to log messages that doesn't hold information for a sysadmin, but mainly for developers, like: https://github.com/lbryio/lbrycrd/blob/master/src/claimtrie.cpp#L1927 To be updated with more examples where it should be applied after #137 gets merged as it adds more cases.

alyssaoc commented

2018-10-04 19:54:13 +02:00

(Migrated from github.com)

@shyba Is this still a valid issue

BrannonKing commented

2018-10-18 17:41:21 +02:00

(Migrated from github.com)

I didn't mean to close this. I think it's a valid issue. I think it could be a subset of the work on issue #211

BrannonKing commented

2019-06-19 21:51:14 +02:00

(Migrated from github.com)

@lbrynaut reports that repeatedly calling "generate 1" significantly increases the log size. This appears to just be the standard logging for every new block -- log new claims, supports, etc. I think we should revisit that logging as part of this issue. Maybe by default we just summarize each new block, and maybe we don't bother to summarize those that we generate locally.

BrannonKing commented

2019-09-26 20:41:08 +02:00

(Migrated from github.com)

I think is sufficiently covered with the move of the claim logging into its own category.

ghost commented

2019-11-04 18:10:29 +01:00

(Migrated from github.com)

I want free swag t-shirt. Fake crying

I want free swag t-shirt. *Fake crying*

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#144

No description provided.