Should create function for claim processing code in main.cpp #151
Labels
No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
Epic
good first issue
hacktoberfest
hard fork
help wanted
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
soft fork
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
work in progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbrycrd#151
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Claim processing code that goes in main.cpp's ConnectBlock() and DisconnectBlock() should be refactored into functions.
https://github.com/lbryio/lbrycrd/blob/v0.12.2.0/src/main.cpp#L2588
https://github.com/lbryio/lbrycrd/blob/v0.12.2.0/src/main.cpp#L2160
This should remove code duplication in miner.cpp : https://github.com/lbryio/lbrycrd/blob/v0.12.2.0/src/miner.cpp#L320
And also allow us to write unit tests for transaction parsing on claim commands and achieve better seperation between Bitcoin Core code and claimtrie code.
#222
merged