Should create function for claim processing code in main.cpp #151

New issue

Closed

opened 2018-05-28 20:12:43 +02:00 by kaykurokawa · 2 comments

kaykurokawa commented

2018-05-28 20:12:43 +02:00

(Migrated from github.com)

Claim processing code that goes in main.cpp's ConnectBlock() and DisconnectBlock() should be refactored into functions.

https://github.com/lbryio/lbrycrd/blob/v0.12.2.0/src/main.cpp#L2588

https://github.com/lbryio/lbrycrd/blob/v0.12.2.0/src/main.cpp#L2160

This should remove code duplication in miner.cpp : https://github.com/lbryio/lbrycrd/blob/v0.12.2.0/src/miner.cpp#L320

And also allow us to write unit tests for transaction parsing on claim commands and achieve better seperation between Bitcoin Core code and claimtrie code.

Claim processing code that goes in main.cpp's ConnectBlock() and DisconnectBlock() should be refactored into functions. https://github.com/lbryio/lbrycrd/blob/v0.12.2.0/src/main.cpp#L2588 https://github.com/lbryio/lbrycrd/blob/v0.12.2.0/src/main.cpp#L2160 This should remove code duplication in miner.cpp : https://github.com/lbryio/lbrycrd/blob/v0.12.2.0/src/miner.cpp#L320 And also allow us to write unit tests for transaction parsing on claim commands and achieve better seperation between Bitcoin Core code and claimtrie code.

bvbfan commented

2018-10-18 15:23:10 +02:00

(Migrated from github.com)

#222

BrannonKing commented

2019-05-08 00:33:53 +02:00

(Migrated from github.com)

merged