Rename CClaimTrieCache to CClaimTrieUpdateBuffer #156

Closed
kaykurokawa wants to merge 276 commits from cclaimtriecache_change into master
kaykurokawa commented 2018-06-04 20:58:56 +02:00 (Migrated from github.com)

credit to @roylee17 for suggesting that CClaimTrieCache is a buffer.

I know some people are working on changes that would be annoying to rebase with this, so I would be fine to hold on to merge this till later.

credit to @roylee17 for suggesting that CClaimTrieCache is a buffer. I know some people are working on changes that would be annoying to rebase with this, so I would be fine to hold on to merge this till later.
BrannonKing (Migrated from github.com) reviewed 2018-06-04 20:58:56 +02:00
bvbfan commented 2018-06-05 05:35:30 +02:00 (Migrated from github.com)

I have plan to separate this class in file, are you OK? We can rise issue? Furthermore i made a couple of changes in implementation details, simplification, const-ness (it's look weird to me) methods like add, undo, insert, clear cannot be const, logically it's not normal.

I have plan to separate this class in file, are you OK? We can rise issue? Furthermore i made a couple of changes in implementation details, simplification, const-ness (it's look weird to me) methods like add, undo, insert, clear cannot be const, logically it's not normal.
BrannonKing commented 2018-07-18 16:06:31 +02:00 (Migrated from github.com)

Rejecting in favor of #160

Rejecting in favor of #160
BrannonKing commented 2018-07-18 16:07:17 +02:00 (Migrated from github.com)

@bvbfan , can you delete this branch if it is not necessary?

@bvbfan , can you delete this branch if it is not necessary?

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#156
No description provided.