Specify coding style, other guidelines in README #157

New issue

Closed

opened 2018-06-06 19:29:58 +02:00 by kaykurokawa · 2 comments

kaykurokawa commented

2018-06-06 19:29:58 +02:00

(Migrated from github.com)

We should probably adopt the same coding style as adopted in Bitcoin Core
https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md

Additional notes:
Avoid changing components in Bitcoin Core unless it is absolutely necessary (basically if the codes does not have anything to do with the claimtrie, it is part of Bitcoin Core although there are exceptions such as the POW algorithm, reward schedule, various chain params, etc..). This is to make merges from Bitcoin Core as easy as possible.

We should probably adopt the same coding style as adopted in Bitcoin Core https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md Additional notes: Avoid changing components in Bitcoin Core unless it is absolutely necessary (basically if the codes does not have anything to do with the claimtrie, it is part of Bitcoin Core although there are exceptions such as the POW algorithm, reward schedule, various chain params, etc..). This is to make merges from Bitcoin Core as easy as possible.

kaykurokawa commented

2018-06-13 21:51:28 +02:00

(Migrated from github.com)

Useful script:
run this in the base lbrycrd folder for the clang format diff:
git diff -U0 HEAD~1.. | ./contrib/devtools/clang-format-diff.py -p1 -i -v

Useful script: run this in the base lbrycrd folder for the clang format diff: git diff -U0 HEAD~1.. | ./contrib/devtools/clang-format-diff.py -p1 -i -v

kaykurokawa commented

2018-07-19 18:54:03 +02:00

(Migrated from github.com)

implemented in https://github.com/lbryio/lbrycrd/pull/163 and https://github.com/lbryio/lbrycrd/pull/155