An automated test for checking that a PR can sync #164

New issue

Open

opened 2018-06-25 16:40:16 +02:00 by kaykurokawa · 4 comments

kaykurokawa commented

2018-06-25 16:40:16 +02:00

(Migrated from github.com)

Not sure if this is possible just using travis (might take too long? use too much disk space?). We might have to set up some servers for this.

As part of the automated travis build (or maybe it could be a separate thing from travis) , we should try to run and sync the built lbrycrd on testnet to see if it can a) sync from scratch and b) start up when its already synced and can succesfuly recieve a couple of blocks. Not sure if this is possible just using travis (might take too long? use too much disk space?). We might have to set up some servers for this.

lbrynaut commented

2018-06-27 01:42:45 +02:00

(Migrated from github.com)

Yeah, I agree it would be nice, but I think it would also require doing externally. As a first cut, we could probably just grab the binaries built from the travis build, run them for however long it's trying to do things, then e-mail the last couple hundred lines of the log to determine if things were normal up until shutdown.

I think travis has timeout limits that would prevent it from working there.

eukreign commented

2018-06-27 02:25:17 +02:00

(Migrated from github.com)

Would be cool if you guys could use orchstr8 to run the tests. The wallet currently runs integration tests where it creates a regtest and generates 200 blocks then performs some interactions. Is testing regtest good enough or do you guys need mainnet/testnet specifically?

Looks like this: https://travis-ci.org/lbryio/torba/jobs/397136549#L562

Would be cool if you guys could use orchstr8 to run the tests. The wallet currently runs integration tests where it creates a `regtest` and generates 200 blocks then performs some interactions. Is testing `regtest` good enough or do you guys need mainnet/testnet specifically? Looks like this: https://travis-ci.org/lbryio/torba/jobs/397136549#L562

lbrynaut commented

2018-06-27 02:56:36 +02:00

(Migrated from github.com)

Nothing wrong with regtest testing also, but what @kaykurokawa is suggesting is specifically testnet, to ensure nothing obvious is overlooked in a PR. Usually that kind of testing is done manually.

kaykurokawa commented

2018-06-27 18:07:01 +02:00

(Migrated from github.com)

It wouldn't hurt to have some quick tests to verify regtest within the test.
Also, might also be good to try testing sync'ing to mainnet as well.

It wouldn't hurt to have some quick tests to verify regtest within the test. Also, might also be good to try testing sync'ing to mainnet as well.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#164

No description provided.