Claim expiration time is set to 262974 blocks, or 456.55... days #20

New issue

Closed

opened 2016-07-18 23:35:09 +02:00 by kaykurokawa · 2 comments

kaykurokawa commented

2016-07-18 23:35:09 +02:00

(Migrated from github.com)

https://github.com/lbryio/lbrycrd/blob/master/src/claimtrie.h#L285

Claim expiration time is set to 262974 blocks or 456.55... days.

Should be set to 52416 blocks or 91 days, according to original design document. Will require hard fork and reindexing.

We have roughly till the end of August to fix this issue in a simple way. Otherwise there needs to be exceptions made for early blocks.

https://github.com/lbryio/lbrycrd/blob/master/src/claimtrie.h#L285 Claim expiration time is set to 262974 blocks or 456.55... days. Should be set to 52416 blocks or 91 days, according to original design document. Will require hard fork and reindexing. We have roughly till the end of August to fix this issue in a simple way. Otherwise there needs to be exceptions made for early blocks.

kaykurokawa commented

2016-08-13 04:59:04 +02:00

(Migrated from github.com)

Team discussion on 8/12 concluded that we will look to extend the expiration time. 365 days was tentatively suggested as a possible expiration time.

kauffj commented

2017-08-14 18:05:32 +02:00

(Migrated from github.com)

I see no need to change this, and certainly not to reduce it.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#20

No description provided.