LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Packages Projects Releases 32 Wiki Activity

CClaimTrieCache::removeClaim does not need the height parameter #226

New issue
Closed
opened 2018-10-19 21:14:24 +02:00 by BrannonKing · 2 comments
BrannonKing commented 2018-10-19 21:14:24 +02:00 (Migrated from github.com)
Copy link

... since the claim object itself knows the correct height. Please use the one on the claim object and remove the parameter and simplify the code accordingly.

Acceptance Criteria

Definition of Done

  • Tested against acceptance criteria
  • Tested against the assumptions of the user story
  • The project builds without errors
  • Unit tests are written and passing
  • Tests on devices/browsers listed in the issue have passed
  • QA performed & issues resolved
  • Refactoring completed
  • Any configuration or build changes documented
  • Documentation updated
  • Peer Code Review performed
... since the claim object itself knows the correct height. Please use the one on the claim object and remove the parameter and simplify the code accordingly. ### Acceptance Criteria 1. 2. 3. ### Definition of Done - [ ] Tested against acceptance criteria - [ ] Tested against the assumptions of the user story - [ ] The project builds without errors - [ ] Unit tests are written and passing - [ ] Tests on devices/browsers listed in the issue have passed - [ ] QA performed & issues resolved - [ ] Refactoring completed - [ ] Any configuration or build changes documented - [ ] Documentation updated - [ ] Peer Code Review performed
Techievena commented 2018-10-28 07:47:09 +01:00 (Migrated from github.com)
Copy link

I want to work on this

I want to work on this
kaykurokawa commented 2018-11-25 23:27:16 +01:00 (Migrated from github.com)
Copy link

This was finished with this commit: 15be5dacce

This was finished with this commit: https://github.com/lbryio/lbrycrd/commit/15be5dacce5db4923c694ae5d2cfd641c9b7840b
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
mergemine_hf
block_info_fix
block_info_fix_try2
v19_master
hash_bit_seq
v17_master
finance
static_link
small_takeover_experiment
dont_force_segwit
add_signature_test
cache_nth_trie_children
v12_master
experimental_use_basho_leveldb
experimental_separate_dbs
experimental_use_bdb_for_claimtrie
experimental_prefix_node_pool
experimental_sqlite_kvps
move_to_gitlab_ci
get_activations_in_block
add_claim_import_scripts
v0.17.3.3
v0.19.1.3
v0.17.4.6
v0.19.1.2
v0.17.4.5
v0.19.1.1
v0.17.4.4
v0.17.4.3
v0.17.4.2
v0.17.4.1
v0.17.3.2
v0.17.3.1
v0.17.3.0rc1
v0.17.2.1
v0.17.2.0
v0.17.1.0
v0.12.4.1
v0.12.4.0
v0.12.3.1
v0.12.3.0
v0.12.2.3
v0.12.2.2
v0.12.2.1
v0.12.2.0
v0.12.1.2
v0.12.1.1
v0.12.1.0
v0.12.0.6
v0.12.0.5
getclaimbyid_1
v0.12.0.4
v0.12.0.3
v0.12.0.2
v0.3.16
v0.3.15
0.13.0
test-win-release
v0.12.99
v0.3-osx
v0.2-alpha
v0.1-alpha-os-x
v0.1-alpha
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
hard fork

   
help wanted

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
soft fork

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
work in progress

The proposed solution is still incomplete.

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
Epic
good first issue
hacktoberfest
hard fork
help wanted
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
soft fork
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
work in progress
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#226
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?