LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Fixes #226 #228

Merged
arrodriguez merged 9 commits from master into master 2018-11-08 23:29:28 +01:00
Conversation 9 Commits 9 Files changed 6 +138 -123
arrodriguez commented 2018-10-23 02:49:34 +02:00 (Migrated from github.com)
Copy link
No description provided.
BrannonKing commented 2018-10-23 17:51:00 +02:00 (Migrated from github.com)
Copy link

I apologize that we have a silly formatting requirement at the moment. Can you run this command and submit one more time?

git diff -U0 master -- '*.h' '*.cpp' | ./contrib/devtools/clang-format-diff.py -p1 -i
I apologize that we have a silly formatting requirement at the moment. Can you run this command and submit one more time? ``` git diff -U0 master -- '*.h' '*.cpp' | ./contrib/devtools/clang-format-diff.py -p1 -i ```
BrannonKing commented 2018-10-23 17:58:31 +02:00 (Migrated from github.com)
Copy link

I would like to ask for one additional favor on this: can you (temporarily, as an experiment) modify CClaimTrieCache::removeFromExpirationQueue such that it prints to stderr whenever it succeeds to call erase and whenever it fails? I would like to know that it always succeeds in our unit tests (unless the test was made specifically to perturb the situation). It might also be good to audit the CClaimTrieCache::removeClaim to see if it returns false only in expected situations in the unit tests.

I would like to ask for one additional favor on this: can you (temporarily, as an experiment) modify `CClaimTrieCache::removeFromExpirationQueue` such that it prints to stderr whenever it succeeds to call erase and whenever it fails? I would like to know that it always succeeds in our unit tests (unless the test was made specifically to perturb the situation). It might also be good to audit the `CClaimTrieCache::removeClaim` to see if it returns false only in expected situations in the unit tests.
arrodriguez commented 2018-10-23 18:31:43 +02:00 (Migrated from github.com)
Copy link

Hi Thank you for your review.
Before sending the pull request i execute all travis stages (for linux) .
The problem is the version of clang-format version in my OS is 3.8 and the
trusty version is 3.4. I think that command output is different between
version. I really dont know why. I will try again in a container.

On Tue, Oct 23, 2018 at 12:58 PM Brannon King notifications@github.com
wrote:

I apologize that we have a silly formatting requirement at the moment. Can
you run this command and submit one more time?

git diff -U0 master -- '.h' '.cpp' | ./contrib/devtools/clang-format-diff.py -p1 -i

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbrycrd/pull/228#issuecomment-432305071, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFbK8IRaTcfICEEjyjjlkBbjKy00cS1yks5unzyygaJpZM4X0deX
.

Hi Thank you for your review. Before sending the pull request i execute all travis stages (for linux) . The problem is the version of clang-format version in my OS is 3.8 and the trusty version is 3.4. I think that command output is different between version. I really dont know why. I will try again in a container. On Tue, Oct 23, 2018 at 12:58 PM Brannon King <notifications@github.com> wrote: > I apologize that we have a silly formatting requirement at the moment. Can > you run this command and submit one more time? > > git diff -U0 master -- '*.h' '*.cpp' | ./contrib/devtools/clang-format-diff.py -p1 -i > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbrycrd/pull/228#issuecomment-432305071>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AFbK8IRaTcfICEEjyjjlkBbjKy00cS1yks5unzyygaJpZM4X0deX> > . >
BrannonKing commented 2018-10-31 20:52:03 +01:00 (Migrated from github.com)
Copy link

@arrodriguez I want to merge this today. Any luck with the formatting? Can you rebase on current master? In addition, I would like your formatting changes to only affect the areas specifically modified for this story.

@arrodriguez I want to merge this today. Any luck with the formatting? Can you rebase on current master? In addition, I would like your formatting changes to only affect the areas specifically modified for this story.
arrodriguez commented 2018-11-01 16:56:54 +01:00 (Migrated from github.com)
Copy link

Hi @BrannonKing i will try to make the changes today.

Thanx for the patience

Hi @BrannonKing i will try to make the changes today. Thanx for the patience
arrodriguez commented 2018-11-02 07:05:29 +01:00 (Migrated from github.com)
Copy link

Hi @BrannonKing , i think that all is covered here now. I did also rebase master branch with this PR.

Any feedback is welcome.

Regards,

Hi @BrannonKing , i think that all is covered here now. I did also rebase master branch with this PR. Any feedback is welcome. Regards,
BrannonKing (Migrated from github.com) requested changes 2018-11-02 19:00:09 +01:00
src/claimtrie.cpp
BrannonKing (Migrated from github.com) commented 2018-11-02 18:57:56 +01:00
Copy link

This needs to be removed before merge.

This needs to be removed before merge.
BrannonKing (Migrated from github.com) commented 2018-11-02 18:58:36 +01:00
Copy link

This also needs to be removed. I used it, though. I looked through the build report to see that there were actually some failures here. I've filed issue #233 for it.

This also needs to be removed. I used it, though. I looked through the build report to see that there were actually some failures here. I've filed issue #233 for it.
BrannonKing (Migrated from github.com) commented 2018-11-02 18:59:37 +01:00
Copy link

And this third print needs to be removed. I was looking for a report on these, not a check-in.

And this third print needs to be removed. I was looking for a report on these, not a check-in.
arrodriguez (Migrated from github.com) reviewed 2018-11-03 01:00:25 +01:00
src/claimtrie.cpp
arrodriguez (Migrated from github.com) commented 2018-11-03 01:00:24 +01:00
Copy link

It makes sense, i think i misunderstood your request in the first comment.

It makes sense, i think i misunderstood your request in the first comment.
arrodriguez (Migrated from github.com) reviewed 2018-11-03 01:00:36 +01:00
src/claimtrie.cpp
arrodriguez (Migrated from github.com) commented 2018-11-03 01:00:36 +01:00
Copy link

Ok

Ok
arrodriguez (Migrated from github.com) reviewed 2018-11-03 01:00:43 +01:00
src/claimtrie.cpp
arrodriguez (Migrated from github.com) commented 2018-11-03 01:00:43 +01:00
Copy link

Ok.

Ok.
BrannonKing (Migrated from github.com) approved these changes 2018-11-08 23:25:53 +01:00
tzarebczan commented 2018-11-09 19:41:56 +01:00 (Migrated from github.com)
Copy link

hey @arrodriguez, thanks so much for this PR and congrats on getting it merged into our codebase! If you haven't already, check out our contributing guide.

Also, can we offer you some LBC in appreciation for your contribution?

We'll also get you a special LBRY hacktoberfest t-shirt after you reach out :)

hey @arrodriguez, thanks so much for this PR and congrats on getting it merged into our codebase! If you haven't already, check out [our contributing guide](https://lbry.tech/contribute). Also, can we offer you some [LBC in appreciation](https://lbry.io/faq/appreciation) for your contribution? We'll also get you a special LBRY hacktoberfest t-shirt after you reach out :)
arrodriguez commented 2018-11-11 08:07:23 +01:00 (Migrated from github.com)
Copy link

Yes , please i would like to receive some LBC for the contribution.

Here is my address:

bRu6UAubBgfNUTrPyeYyeGLNE6q4kHVFUP

i will try to do more contributions whenever i can.

Thanx a lot!

Yes , please i would like to receive some LBC for the contribution. Here is my address: bRu6UAubBgfNUTrPyeYyeGLNE6q4kHVFUP i will try to do more contributions whenever i can. Thanx a lot!
👍 1
tzarebczan commented 2018-11-12 18:26:03 +01:00 (Migrated from github.com)
Copy link

@arrodriguez awesome, thanks for providing that info. Can you please send us an email to hello@lbry.io per our appreciation process?

@arrodriguez awesome, thanks for providing that info. Can you please send us an email to hello@lbry.io per our appreciation process?
Sign in to join this conversation.
Reviewers
No reviewers
BrannonKing
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
hard fork

   
help wanted

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
soft fork

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
work in progress

The proposed solution is still incomplete.

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
Epic
good first issue
hacktoberfest
hard fork
help wanted
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
soft fork
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
work in progress
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#228
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?