LBRYCommunity/lbrycrd

Fork 0

Lbrycrd needs version scheme #26

New issue

Closed

opened 2016-07-22 17:03:02 +02:00 by kaykurokawa · 6 comments

kaykurokawa commented

2016-07-22 17:03:02 +02:00

(Migrated from github.com)

Need to figure out how versions will be set

da53f17a28/src/clientversion.h

Need to figure out how versions will be set https://github.com/lbryio/lbrycrd/blob/da53f17a28cb7609fdb421a82ac58f9a1649a30f/src/clientversion.h

kaykurokawa commented

2016-07-26 00:42:51 +02:00

(Migrated from github.com)

Sensible proposal :
Major , Minor follows Bitcoin Core code (would be 12.0 currently)
Client version build is used to track major lbry releases within the Core code base ( Increment from 0 up to 99). Current version could be 1 after soft fork at 874948ec59

Sensible proposal : Major , Minor follows Bitcoin Core code (would be 12.0 currently) Client version build is used to track major lbry releases within the Core code base ( Increment from 0 up to 99). Current version could be 1 after soft fork at https://github.com/lbryio/lbrycrd/commit/874948ec59b7958f4212522f0b0b1f1b9cb224fb

jobevers commented

2016-08-08 15:34:47 +02:00

(Migrated from github.com)

One nit - major.minor is currently 0.12 not 12.0.

When you say client version, what do you mean?

Regarding tracking lbry releases - I don't understand what happens when it gets reset to 1; it seems that something else should get incremented when that happens.

One nit - major.minor is currently `0.12` not `12.0`. When you say client version, what do you mean? Regarding tracking lbry releases - I don't understand what happens when it gets reset to 1; it seems that something else should get incremented when that happens.

kaykurokawa commented

2016-08-08 17:45:52 +02:00

(Migrated from github.com)

You are right about the first point, to clarify , the Bitcoin Core version we are using is 0.12.0 (it is not really 0.12.99 , the 99 is a place holder indicating that it is not a release version).

We use the first three numbers from the Bitcoin core version we are using, and than the last number gets incremented according to our releases. So we get 0.12.0.1 to 0.12.0.2 etc... I would only increment the release for major changes such as a soft fork, not minor changes like to the RPC commands. The primary purpose would be to be able to tell which client version nodes are running in the event of soft forks. For minor changes we can do a git tag such as 0.12.0.1 release 1/2/...etc.

So current version should be 0.12.0.1 and release 2 I believe.

You are right about the first point, to clarify , the Bitcoin Core version we are using is 0.12.0 (it is not really 0.12.99 , the 99 is a place holder indicating that it is not a release version). We use the first three numbers from the Bitcoin core version we are using, and than the last number gets incremented according to our releases. So we get 0.12.0.1 to 0.12.0.2 etc... I would only increment the release for major changes such as a soft fork, not minor changes like to the RPC commands. The primary purpose would be to be able to tell which client version nodes are running in the event of soft forks. For minor changes we can do a git tag such as 0.12.0.1 release 1/2/...etc. So current version should be 0.12.0.1 and release 2 I believe.

jimmykiselak commented

2016-08-18 02:52:26 +02:00

(Migrated from github.com)

How is this going to handle future pulls from upstream?

kaykurokawa commented

2016-08-26 18:45:54 +02:00

(Migrated from github.com)

For example , if bitcoin release is 0.12.0.1 our release is 0.12.0.X where X is some custom number we use. The last number in Bitcoin is for client builds which are usually not major changes, so we can use it to keep track of changes unique to Lbrycrd.

kaykurokawa commented

2016-09-06 04:19:24 +02:00

(Migrated from github.com)

closed as https://github.com/lbryio/lbrycrd/pull/37

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#26

No description provided.

Rows
Columns