support GCC 8.3 or document that 6 should be used #282

New issue

Closed

opened 2019-05-28 04:31:59 +02:00 by shyba · 4 comments

shyba commented

2019-05-28 04:31:59 +02:00

(Migrated from github.com)

tried and bdb build fails. GCC 6 works
error output is huge, but this is repeated all over the place:

../dist/../dbinc/atomic.h:179:19: error: definition of ‘int __atomic_compare_exchange(db_atomic_t*, atomic_value_t, atomic_value_t)’ ambiguates built-in declaration ‘bool __atomic_compare_exchange(long unsigned int, volatile void*, void*, void*, int, int)’
static inline int __atomic_compare_exchange(
                  ^~~~~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:2020: cxx_dbc.o] Error 1

tried and bdb build fails. GCC 6 works error output is huge, but this is repeated all over the place: ``` ../dist/../dbinc/atomic.h:179:19: error: definition of ‘int __atomic_compare_exchange(db_atomic_t*, atomic_value_t, atomic_value_t)’ ambiguates built-in declaration ‘bool __atomic_compare_exchange(long unsigned int, volatile void*, void*, void*, int, int)’ static inline int __atomic_compare_exchange( ^~~~~~~~~~~~~~~~~~~~~~~~~ make: *** [Makefile:2020: cxx_dbc.o] Error 1 ```

lbrynaut commented

2019-05-28 14:11:42 +02:00

(Migrated from github.com)

Thanks @shyba . The reported issue is specifically for building dependencies, via reproducible build. A known work-around is to run the script as: CC=gcc-6 CXX=g++-6 ./reproducible_build.sh

Thanks @shyba . The reported issue is specifically for building dependencies, via reproducible build. A known work-around is to run the script as: `CC=gcc-6 CXX=g++-6 ./reproducible_build.sh`

BrannonKing commented

2019-05-29 23:09:11 +02:00

(Migrated from github.com)

Saving link: https://patchwork.ozlabs.org/patch/932375/

BrannonKing commented

2019-06-06 19:56:05 +02:00

(Migrated from github.com)

Yesterday I realized that the "depends" build had this fixed ages ago (in upstream bitcoin which we recently merged). @shyba tested it also and saw no problems.

BrannonKing commented

2019-06-17 23:50:26 +02:00

(Migrated from github.com)

in master now. (use build.sh or packaging/build_*)

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#282

No description provided.