Todo left in help info 0.17.2.1 #306

Closed
opened 2019-08-22 05:52:56 +02:00 by tiger5226 · 6 comments
tiger5226 commented 2019-08-22 05:52:56 +02:00 (Migrated from github.com)

Todo in help info

supportclaim "name" "claimid" "amount" "value"
Increase the value of a claim. Whichever claim has the greatest value, including all support values, will be the authoritative claim, according to the rest of the rules. The name is the name which is claimed by the claim that will be supported, the txid is the txid of the claim that will be supported, nout is the transaction output which contains the claim to be supported, and amount is the amount which will be added to the value of the claim. If the claim is currently the authoritative claim, this support will go into effect immediately . Otherwise, it will go into effect after 100 blocks. The support will be in effect until it is spent, and will lose its effect when the claim is spent or expires. The amount is a real and is rounded to the nearest .00000001

Arguments:
1. "name"  (string, required) The name claimed by the claim to support.
2. "claimid"  (string, required) The claimid of the claim to support. This can be obtained by TODO PUT IN PLACE THAT SHOWS THIS.
3. "amount"  (numeric, required) The amount in LBC to use to support the claim.
4. "value"  (string, optional) The metadata of the support encoded in hexadecimal.

Result:
"transactionid"  (string) The transaction id of the support.
Todo in help info ``` supportclaim "name" "claimid" "amount" "value" Increase the value of a claim. Whichever claim has the greatest value, including all support values, will be the authoritative claim, according to the rest of the rules. The name is the name which is claimed by the claim that will be supported, the txid is the txid of the claim that will be supported, nout is the transaction output which contains the claim to be supported, and amount is the amount which will be added to the value of the claim. If the claim is currently the authoritative claim, this support will go into effect immediately . Otherwise, it will go into effect after 100 blocks. The support will be in effect until it is spent, and will lose its effect when the claim is spent or expires. The amount is a real and is rounded to the nearest .00000001 Arguments: 1. "name" (string, required) The name claimed by the claim to support. 2. "claimid" (string, required) The claimid of the claim to support. This can be obtained by TODO PUT IN PLACE THAT SHOWS THIS. 3. "amount" (numeric, required) The amount in LBC to use to support the claim. 4. "value" (string, optional) The metadata of the support encoded in hexadecimal. Result: "transactionid" (string) The transaction id of the support. ```
tiger5226 commented 2019-08-22 05:53:48 +02:00 (Migrated from github.com)

In addition to this, it would be best if these parameters were optional. Like supporting a name only. would make testing easier.

In addition to this, it would be best if these parameters were optional. Like supporting a name only. would make testing easier.
bvbfan commented 2019-08-23 16:45:13 +02:00 (Migrated from github.com)

Name + (partial) claimId, which specify a distinct claim, or best one.

Name + (partial) claimId, which specify a distinct claim, or best one.
tiger5226 commented 2019-08-24 02:50:42 +02:00 (Migrated from github.com)

Just a name would be best with the option of passing a claimid to make it distinct.

Just a name would be best with the option of passing a claimid to make it distinct.
bvbfan commented 2019-09-02 15:40:53 +02:00 (Migrated from github.com)
https://github.com/lbryio/lbrycrd/pull/303/commits/af9ecd463caa1e51087cc67e426ca55cf0771720 Default amount is the minimum one 0.00000001.
tiger5226 commented 2019-09-03 05:30:12 +02:00 (Migrated from github.com)

Sweet! @nikooo777 One this is in the release we can take out Chainquery as a dependency of the e2e test.

Sweet! @nikooo777 One this is in the release we can take out Chainquery as a dependency of the e2e test.
BrannonKing commented 2019-09-06 22:12:04 +02:00 (Migrated from github.com)
Merged via https://github.com/lbryio/lbrycrd/pull/303
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#306
No description provided.