lbrycrdd created invalid transaction, thinks address is empty even though its not #46

New issue

Closed

opened 2016-10-12 18:51:39 +02:00 by lyoshenka · 2 comments

lyoshenka commented

2016-10-12 18:51:39 +02:00

(Migrated from github.com)

2016-10-12 03:02:18 keypool added key 1639, size=101
2016-10-12 03:02:18 keypool reserve 1539
2016-10-12 03:02:18 CommitTransaction:
CTransaction(hash=d5e2963d45, ver=1, vin.size=1, vout.size=2, nLockTime=59807)
    CTxIn(COutPoint(ffed835a3d, 0), scriptSig=473044022018e0ee20c8474e, nSequence=4294967294)
    CTxOut(nValue=824.99874871, scriptPubKey=76a914c11400b5d35876bef008839c)
    CTxOut(nValue=25.00000000, scriptPubKey=76a914e37301b31113436528931a41)
2016-10-12 03:02:18 keypool keep 1539
2016-10-12 03:02:18 AddToWallet d5e2963d45dbf17a6eea65967de1a9dc44fe47f74420e3b73a3da62308e2aa76  new
2016-10-12 03:02:18 AddToWallet d5e2963d45dbf17a6eea65967de1a9dc44fe47f74420e3b73a3da62308e2aa76  
2016-10-12 03:02:18 Relaying wtx d5e2963d45dbf17a6eea65967de1a9dc44fe47f74420e3b73a3da62308e2aa76
2016-10-12 03:02:43 keypool added key 1640, size=101
2016-10-12 03:02:43 keypool reserve 1540
2016-10-12 03:02:43 CommitTransaction:
CTransaction(hash=2dc2153fa3, ver=1, vin.size=1, vout.size=2, nLockTime=59807)
    CTxIn(COutPoint(d5e2963d45, 0), scriptSig=47304402206c4c0e0f3e6f35, nSequence=4294967294)
    CTxOut(nValue=25.00000000, scriptPubKey=76a914f012b6449f34caf0be5b5a25)
    CTxOut(nValue=799.99870228, scriptPubKey=76a91482292715dab1cd680e6efe97)
2016-10-12 03:02:43 keypool keep 1540
2016-10-12 03:02:43 AddToWallet 2dc2153fa379701c6de8ede9d17760483627857501e2b45f59427e353ec574a6  new
2016-10-12 03:02:43 CommitTransaction(): Error: Transaction not valid
2016-10-12 03:02:59 incrementBlock: nCurrentHeight (before increment): 59808
2016-10-12 03:02:59 UpdateTip: new best=d1621fd8943436c946ace601571a6784308440f6f369843c35b8df88baf4d9ab height=59808 version=0x20000000 log2_work=63.798004 tx=719930 date='2016-10-12 03:02:50' progress=1.000000 cache=2.9MiB(9076tx)

near the bottom, it looks like an invalid transaction was created
it was created using a script, but the script just calls lbrycrd-cli sendtoaddress
anyway, the transaction was supposed to spent from the address bWLB555cGfRcW4eCPBQgPScmocZoMPNGCd, which is where the previous transaction (d5e2963d45dbf17a6eea65967de1a9dc44fe47f74420e3b73a3da62308e2aa76) sent its change
however, the wallet now thinks that bWLB555cGfRcW4eCPBQgPScmocZoMPNGCd is empty
even though the invalid transaction was never accepted by the network
i bet i could fix this by exporting the address, creating a brand new wallet, then reimporting the address
(though i havent tried that yet)
but the bug should probably be fixed first. plus it may be something we want to send upstream, since its probably not related to anything we changed in bitcoin
let me know if you need help reproducing this. i don't have the invalid transaction that was attempted, but i can send you the wallet file and more logs
i can maybe reconstruct the command that the script tried to run

``` 2016-10-12 03:02:18 keypool added key 1639, size=101 2016-10-12 03:02:18 keypool reserve 1539 2016-10-12 03:02:18 CommitTransaction: CTransaction(hash=d5e2963d45, ver=1, vin.size=1, vout.size=2, nLockTime=59807) CTxIn(COutPoint(ffed835a3d, 0), scriptSig=473044022018e0ee20c8474e, nSequence=4294967294) CTxOut(nValue=824.99874871, scriptPubKey=76a914c11400b5d35876bef008839c) CTxOut(nValue=25.00000000, scriptPubKey=76a914e37301b31113436528931a41) 2016-10-12 03:02:18 keypool keep 1539 2016-10-12 03:02:18 AddToWallet d5e2963d45dbf17a6eea65967de1a9dc44fe47f74420e3b73a3da62308e2aa76 new 2016-10-12 03:02:18 AddToWallet d5e2963d45dbf17a6eea65967de1a9dc44fe47f74420e3b73a3da62308e2aa76 2016-10-12 03:02:18 Relaying wtx d5e2963d45dbf17a6eea65967de1a9dc44fe47f74420e3b73a3da62308e2aa76 2016-10-12 03:02:43 keypool added key 1640, size=101 2016-10-12 03:02:43 keypool reserve 1540 2016-10-12 03:02:43 CommitTransaction: CTransaction(hash=2dc2153fa3, ver=1, vin.size=1, vout.size=2, nLockTime=59807) CTxIn(COutPoint(d5e2963d45, 0), scriptSig=47304402206c4c0e0f3e6f35, nSequence=4294967294) CTxOut(nValue=25.00000000, scriptPubKey=76a914f012b6449f34caf0be5b5a25) CTxOut(nValue=799.99870228, scriptPubKey=76a91482292715dab1cd680e6efe97) 2016-10-12 03:02:43 keypool keep 1540 2016-10-12 03:02:43 AddToWallet 2dc2153fa379701c6de8ede9d17760483627857501e2b45f59427e353ec574a6 new 2016-10-12 03:02:43 CommitTransaction(): Error: Transaction not valid 2016-10-12 03:02:59 incrementBlock: nCurrentHeight (before increment): 59808 2016-10-12 03:02:59 UpdateTip: new best=d1621fd8943436c946ace601571a6784308440f6f369843c35b8df88baf4d9ab height=59808 version=0x20000000 log2_work=63.798004 tx=719930 date='2016-10-12 03:02:50' progress=1.000000 cache=2.9MiB(9076tx) ``` near the bottom, it looks like an invalid transaction was created it was created using a script, but the script just calls `lbrycrd-cli sendtoaddress` anyway, the transaction was supposed to spent from the address `bWLB555cGfRcW4eCPBQgPScmocZoMPNGCd`, which is where the previous transaction (d5e2963d45dbf17a6eea65967de1a9dc44fe47f74420e3b73a3da62308e2aa76) sent its change however, the wallet now thinks that `bWLB555cGfRcW4eCPBQgPScmocZoMPNGCd` is empty even though the invalid transaction was never accepted by the network i bet i could fix this by exporting the address, creating a brand new wallet, then reimporting the address (though i havent tried that yet) but the bug should probably be fixed first. plus it may be something we want to send upstream, since its probably not related to anything we changed in bitcoin let me know if you need help reproducing this. i don't have the invalid transaction that was attempted, but i can send you the wallet file and more logs i can maybe reconstruct the command that the script tried to run

lyoshenka commented

2017-06-14 15:22:53 +02:00

(Migrated from github.com)

@kaykurokawa did you ever look into this? if this hasn't come up since, maybe we can close this issue.

alyssaoc commented

2018-07-18 18:06:15 +02:00

(Migrated from github.com)

have not seen this issue again

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#46

No description provided.

Rows
Columns