Rejected dust transactions return error code 64 instead of 65 #97

New issue

Closed

opened 2018-02-22 19:47:10 +01:00 by jackrobison · 2 comments

jackrobison commented

2018-02-22 19:47:10 +01:00

(Migrated from github.com)

The constant REJECT_DUST is never used.

I think this is where the incorrect error code is coming from: 51d6b690cb/src/main.cpp (L1037)

The above calls: e08d765f11/src/policy/policy.cpp (L109)

The constant `REJECT_DUST` is [never used](https://github.com/lbryio/lbrycrd/blob/fa24439ff3d8ab5b9efaf66ef4dae6713b88cb35/src/consensus/validation.h#L17). I think this is where the incorrect error code is coming from: https://github.com/lbryio/lbrycrd/blob/51d6b690cb2adae1dfa8bc042a07e476ea7edf15/src/main.cpp#L1037 The above calls: https://github.com/lbryio/lbrycrd/blob/e08d765f11a421d0b832ecefcc859c5598fa56d0/src/policy/policy.cpp#L109

kaykurokawa commented

2018-03-19 03:06:27 +01:00

(Migrated from github.com)

looks like REJECT_NONSTANDARD is a catchall error type for the IsStandardTx function , and it would be better if it was refined to return the more specific error codes such as REJECT_DUST

bvbfan commented

2018-08-05 17:26:56 +02:00

(Migrated from github.com)

https://github.com/lbryio/lbrycrd/pull/185

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#97

No description provided.

Rows
Columns