The main normalization branch that needs review pronto #235

Merged
kaykurokawa merged 10 commits from normalization_1107_2 into master 2019-02-09 20:03:00 +01:00

10 commits

Author SHA1 Message Date
Brannon King
308175a6ad set go-live normalization fork numbers 2019-02-06 13:47:20 -07:00
Brannon King
965a82e460 tweak windows build just a bit 2019-02-06 13:47:20 -07:00
lbrynaut
97e46e915c Fix Windows ICU build by making sure the cross compiled ICU exists before building boost.
Add some additional logging during ICU configuration and build process.

Resolve ICU on windows link issues.

Add /tmp/icu_install (cross-compile staging build) to the travis
directory cache for future windows builds.
2019-02-06 13:47:20 -07:00
Brannon King
38810be123 repaired ICU link order 2019-02-06 13:47:20 -07:00
lbrynaut
3cfdda83a9 Modify ICU discovery and add ICU linkage for tests
Rename claimtrieForks to claimtrieforks for consistency
Update a typo in rpcwallet
2019-02-06 13:47:20 -07:00
Brannon King
2186d7a03b reverted accidental use of c++11 const
don't skip build by dir alone
2019-02-06 13:47:20 -07:00
Brannon King
453a10772a bumping version for release 2019-02-06 13:47:20 -07:00
Brannon King
a8a9b81a18 removed duplicate trie in RAM, other norm fixes
also includes code to validate incoming utf8
moved normalization from claimTrie; all in cache now

also fixed a few post-merge issues
added handling for support normalization

fixed failure to handle unnormalized items reinserted on rollback

fixing ICU deps for Travis build

get more info on Travis build failure

Travis experiment 2: ICU fPIC

add independent tests to check string normalization only

move comment to proper location, and note what excpetion is thrown

add RPC call checknormalization so user can see what normalization does

made expiration at norm time smarter

also rearranged unit test code to avoid some spurious errors
made ICU compile statically

also fixed early exit in reproducible_build script
changed to keep original name

removed ability to return just-added supports

it was impossible to get the normalized names correct there
apparently the -s is no longer appreciated

moved normalization code to separate file

also fixed bug on effective amount
fixed performance problem on trie upgrade

fixed issue with valid height on rollback

fixed issue with post-normalization name q data

fixed failure to remove normalized claims on rollback

post-merge fixes

post-merge fixes
2019-02-06 13:47:20 -07:00
lbrynaut
9c55b9eee8 No longer abort on removal from claimtrie in the case of expiration
where normalization is enabled and the claim no longer exists (due to
normalization related narrowing)
2019-02-06 13:47:20 -07:00
lbrynaut
69880ded9f Implement a hard fork to normalize claim names
Apply (self) review feedback
Clean deps required for boost to rebuild with icu support (for now)
Normalization bug fixes and improvements
Clang-formatting
2019-02-06 13:47:20 -07:00