Fix expiration fork usage #296

Merged

bvbfan merged 3 commits from expiration_fix into master

2019-07-22 22:27:26 +02:00

bvbfan commented

2019-07-10 16:02:38 +02:00

(Migrated from github.com)

Signed-off-by: Anthony Fieroni bvbfan@abv.bg

Fixes #287

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> Fixes #287

BrannonKing (Migrated from github.com) requested changes

2019-07-16 18:55:53 +02:00

src/test/claimtriebranching_tests.cpp

BrannonKing (Migrated from github.com) commented

2019-07-16 18:55:48 +02:00

I don't think this is right. Aren't those 800s supposed to be 140, the current height? What was the old behavior? I don't see that this test goes all the way to 800 increments, so I doubt it's hitting the danger zone.

bvbfan (Migrated from github.com) reviewed

2019-07-16 19:11:35 +02:00

src/test/claimtriebranching_tests.cpp

bvbfan (Migrated from github.com) commented

2019-07-16 19:11:35 +02:00

In ClaimTrieChainFixture we don't change the consensus, so setExpirationTime was supposed to change only expiration time, since we don't have such functionality it should be

fixture.setExpirationForkHeight(consensus.nExtendedClaimExpirationForkHeight, 3, consensus.nExtendedClaimExpirationTime)

In ClaimTrieChainFixture we don't change the consensus, so setExpirationTime was supposed to change only expiration time, since we don't have such functionality it should be ``` fixture.setExpirationForkHeight(consensus.nExtendedClaimExpirationForkHeight, 3, consensus.nExtendedClaimExpirationTime) ```

No reviewers

BrannonKing

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#296

No description provided.

Rows
Columns