LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity
lbrycrd/src/qt
History
MarcoFalke 1a274bce4b
Merge #16205: Refactor: Replace fprintf with tfm::format 
fa8f195195 Replace remaining fprintf with tfm::format manually (MarcoFalke)
fac03ec43a scripted-diff: Replace fprintf with tfm::format (MarcoFalke)
fa72a64b90 tinyformat: Add doc to Bitcoin Core specific strprintf (MarcoFalke)

Pull request description:

  This should be a refactor except in the cases where we use the wrong format specifier [1], in which case this patch is a bug fix.

  [1] : e.g.  depends: Add libevent compatibility patch for windows #8730

ACKs for commit fa8f19:
  promag:
    ACK fa8f195195. Ideally this should be rebased before merge.
  practicalswift:
    utACK fa8f195195
  Empact:
    ACK fa8f195195
  laanwj:
    code review and lightly tested ACK fa8f195195
  jonatack:
    ACK fa8f195195 from light code review, building, and running linter/unit tests/extended functional tests.

Tree-SHA512: 65f648b0bc383e3266a5bdb4ad8c8a1908a719635d49e1cd321b91254be24dbc7e22290370178e29b98ddcb3fec0889de9cbae273c7140abc9793d849534a743
2019-06-17 06:06:41 -04:00
..
forms Merge #16090: Qt: Add vertical spacer to peer detail widget 2019-06-03 23:17:46 +02:00
locale qt: Pre-0.18 split-off translations update 2019-02-04 15:24:37 +01:00
res Scripts and tools & Docs: Used #!/usr/bin/env bash instead of obsolete #!/bin/bash, added linting for .sh files shebang and updated the Developer Notes. 2018-12-02 16:14:21 +02:00
test Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
addressbookpage.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
addressbookpage.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
addresstablemodel.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
addresstablemodel.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
askpassphrasedialog.cpp Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
askpassphrasedialog.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
bantablemodel.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
bantablemodel.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
bitcoin.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
bitcoin.h Merge #15101: gui: Add WalletController 2019-01-18 10:21:08 -10:00
bitcoin.qrc [gui] Add proxy icon in statusbar 2018-05-15 23:23:56 +03:00
bitcoin_locale.qrc qt: periodic translations update 2017-01-10 12:52:02 +01:00
bitcoinaddressvalidator.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
bitcoinaddressvalidator.h Added "Core" to copyright headers 2014-12-19 19:55:32 +01:00
bitcoinamountfield.cpp Replace remaining 0 with nullptr in Qt code 2019-01-13 03:25:14 -08:00
bitcoinamountfield.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
bitcoingui.cpp Merge #16118: gui: Enable open wallet menu on setWalletController 2019-06-13 16:47:38 +08:00
bitcoingui.h gui: Add close wallet action 2019-02-12 22:07:45 +00:00
bitcoinstrings.cpp qt: Pre-0.18 split-off translations update 2019-02-04 15:24:37 +01:00
bitcoinunits.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
bitcoinunits.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
clientmodel.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
clientmodel.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
coincontroldialog.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
coincontroldialog.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
coincontroltreewidget.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
coincontroltreewidget.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
csvmodelwriter.cpp Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
csvmodelwriter.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
editaddressdialog.cpp Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
editaddressdialog.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
guiconstants.h GUI: Move QRImageWidget to its own file-pair 2019-05-02 12:18:18 +00:00
guiutil.cpp qt: fix opening bitcoin.conf via Preferences on macOS; see #15409 2019-06-03 10:32:15 +08:00
guiutil.h Resolve the qt/guiutil <-> qt/optionsmodal CD 2019-04-23 13:26:06 +02:00
intro.cpp Resolve the qt/guiutil <-> qt/optionsmodal CD 2019-04-23 13:26:06 +02:00
intro.h Resolve the qt/guiutil <-> qt/optionsmodal CD 2019-04-23 13:26:06 +02:00
macdockiconhandler.h Remove obj_c for macOS Dock icon menu 2018-11-04 02:42:18 +02:00
macdockiconhandler.mm Remove obj_c for macOS Dock icon menu 2018-11-04 02:42:18 +02:00
macnotificationhandler.h convert C-style (void) parameter lists to C++ style () 2018-09-13 10:36:41 -07:00
macnotificationhandler.mm Refactoring with QString::toNSString 2018-12-16 20:29:56 +02:00
macos_appnap.h macOS: disable AppNap during sync 2018-11-01 18:22:06 +03:00
macos_appnap.mm macOS: disable AppNap during sync 2018-11-01 18:22:06 +03:00
main.cpp Add BitcoinApplication & RPCConsole tests 2019-01-04 06:31:07 -05:00
Makefile build: add stub makefiles for easier subdir builds 2014-06-05 16:05:43 -04:00
modaloverlay.cpp Qt: Fix update headers-count 2019-01-04 08:52:27 -10:00
modaloverlay.h Qt: Fix update headers-count 2019-01-04 08:52:27 -10:00
networkstyle.cpp Replace remaining 0 with nullptr in Qt code 2019-01-13 03:25:14 -08:00
networkstyle.h Added "Core" to copyright headers 2014-12-19 19:55:32 +01:00
notificator.cpp Remove misplaced Q_UNUSED and others enhancements 2018-12-20 01:06:37 +02:00
notificator.h Remove misplaced Q_UNUSED and others enhancements 2018-12-20 01:06:37 +02:00
openuridialog.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
openuridialog.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
optionsdialog.cpp Merge #15801: Bugfix: GUI: Options: Initialise prune setting range before loading current value, and remove upper bound limit 2019-04-18 17:46:38 +02:00
optionsdialog.h Merge #13248: [gui] Make proxy icon from statusbar clickable 2018-08-20 13:40:11 +02:00
optionsmodel.cpp Resolve the qt/guiutil <-> qt/optionsmodal CD 2019-04-23 13:26:06 +02:00
optionsmodel.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
overviewpage.cpp Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
overviewpage.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
paymentrequest.proto Specify Protobuf version 2 in paymentrequest.proto 2016-09-16 11:45:08 +08:00
paymentrequestplus.cpp scripted-diff: Move util files to separate directory. 2018-11-04 22:46:07 -08:00
paymentrequestplus.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
paymentserver.cpp GUI: If BIP70 is disabled, give a proper error when trying to open a payment request file 2019-02-11 15:08:41 +00:00
paymentserver.h qt: cleanup: Move BIP70 functions together in paymentserver 2018-10-22 04:03:17 -06:00
peertablemodel.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
peertablemodel.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
platformstyle.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
platformstyle.h qt: Introduce PlatformStyle 2015-07-31 09:35:18 +02:00
qrimagewidget.cpp GUI: Move QRImageWidget to its own file-pair 2019-05-02 12:18:18 +00:00
qrimagewidget.h GUI: Move QRImageWidget to its own file-pair 2019-05-02 12:18:18 +00:00
qvalidatedlineedit.cpp Replace remaining 0 with nullptr in Qt code 2019-01-13 03:25:14 -08:00
qvalidatedlineedit.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
qvaluecombobox.cpp qt: Use new Qt5 connect syntax 2018-08-21 09:43:54 +01:00
qvaluecombobox.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
README.md Fix macOS files description 2018-10-08 00:41:40 +03:00
receivecoinsdialog.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
receivecoinsdialog.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
receiverequestdialog.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
receiverequestdialog.h GUI: Move QRImageWidget to its own file-pair 2019-05-02 12:18:18 +00:00
recentrequeststablemodel.cpp Use C++11 default member initializers 2019-01-05 16:16:37 +01:00
recentrequeststablemodel.h Use C++11 default member initializers 2019-01-05 16:16:37 +01:00
rpcconsole.cpp gui: Enable console line edit on setClientModel 2019-05-30 23:26:18 +01:00
rpcconsole.h Remove redundant stopExecutor() signal 2019-01-10 01:21:25 +02:00
sendcoinsdialog.cpp Merge #15886: qt, wallet: Revamp SendConfirmationDialog 2019-06-06 13:12:17 +02:00
sendcoinsdialog.h Make SendConfirmationDialog fully fledged 2019-04-24 21:56:10 +03:00
sendcoinsentry.cpp Replace remaining 0 with nullptr in Qt code 2019-01-13 03:25:14 -08:00
sendcoinsentry.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
signverifymessagedialog.cpp Replace CScriptID and CKeyID in CTxDestination with dedicated types 2019-04-29 10:15:23 -04:00
signverifymessagedialog.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
splashscreen.cpp Replace remaining 0 with nullptr in Qt code 2019-01-13 03:25:14 -08:00
splashscreen.h Cleanup SplashScreen class 2018-12-02 01:26:28 +02:00
trafficgraphwidget.cpp Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
trafficgraphwidget.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
transactiondesc.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
transactiondesc.h Remove unused adjustedTime parameter 2018-10-28 09:04:10 +02:00
transactiondescdialog.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
transactiondescdialog.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
transactionfilterproxy.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
transactionfilterproxy.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
transactionrecord.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
transactionrecord.h Don't label transactions "Open" while catching up 2019-01-03 00:10:24 +02:00
transactiontablemodel.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
transactiontablemodel.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
transactionview.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
transactionview.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
utilitydialog.cpp scripted-diff: Replace fprintf with tfm::format 2019-06-13 10:32:52 -04:00
utilitydialog.h Replace remaining 0 with nullptr in Qt code 2019-01-13 03:25:14 -08:00
walletcontroller.cpp gui: Defer removeAndDeleteWallet when no modal widget is active 2019-03-22 09:51:04 +00:00
walletcontroller.h gui: Add closeWallet to WalletController 2019-02-12 22:07:45 +00:00
walletframe.cpp gui: Drop unused return values in WalletFrame 2019-02-22 16:26:09 +00:00
walletframe.h gui: Drop unused return values in WalletFrame 2019-02-22 16:26:09 +00:00
walletmodel.cpp Give WalletModel::UnlockContext move semantics 2019-05-09 18:07:33 -07:00
walletmodel.h Give WalletModel::UnlockContext move semantics 2019-05-09 18:07:33 -07:00
walletmodeltransaction.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
walletmodeltransaction.h build: Add --disable-bip70 configure option 2018-10-09 03:36:14 -06:00
walletview.cpp gui: Set progressDialog to nullptr 2019-06-02 22:18:19 +01:00
walletview.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
winshutdownmonitor.cpp scripted-diff: Move util files to separate directory. 2018-11-04 22:46:07 -08:00
winshutdownmonitor.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00

README.md

This directory contains the BitcoinQT graphical user interface (GUI). It uses the cross-platform framework Qt.

The current precise version for Qt 5 is specified in qt.mk.

Compile and run

See build instructions (macOS, Windows, Unix, etc).

To run:

./src/qt/bitcoin-qt

Files and directories

forms

Contains Designer UI files. They are created with Qt Creator, but can be edited using any text editor.

locale

Contains translations. They are periodically updated. The process is described here.

res

Resources such as the icon.

test

Tests.

bitcoingui.(h/cpp)

Represents the main window of the Bitcoin UI.

*model.(h/cpp)

The model. When it has a corresponding controller, it generally inherits from QAbstractTableModel. Models that are used by controllers as helpers inherit from other Qt classes like QValidator.

ClientModel is used by the main application bitcoingui and several models like peertablemodel.

*page.(h/cpp)

A controller. :NAMEpage.cpp generally includes :NAMEmodel.h and forms/:NAME.page.ui with a similar :NAME.

*dialog.(h/cpp)

Various dialogs, e.g. to open a URL. Inherit from QDialog.

paymentserver.(h/cpp)

Used to process BIP21 and BIP70 (see https://github.com/bitcoin/bitcoin/pull/11622) payment URI / requests. Also handles URI based application switching (e.g. when following a bitcoin:... link from a browser).

walletview.(h/cpp)

Represents the view to a single wallet.

Other .h/cpp files

  • UI elements like BitcoinAmountField, which inherit from QWidget.
  • bitcoinstrings.cpp: automatically generated
  • bitcoinunits.(h/cpp): BTC / mBTC / etc handling
  • callback.h
  • guiconstants.h: UI colors, app name, etc
  • guiutil.h: several helper functions
  • macdockiconhandler.(h/mm): macOS dock icon handler
  • macnotificationhandler.(h/mm): display notifications in macOS

Contribute

See CONTRIBUTING.md for general guidelines. Specifically for Qt:

Using Qt Creator as IDE

You can use Qt Creator as an IDE. This is especially useful if you want to change the UI layout.

Download and install the community edition of Qt Creator. Uncheck everything except Qt Creator during the installation process.

Instructions for macOS:

  1. Make sure you installed everything through Homebrew mentioned in the macOS build instructions
  2. Use ./configure with the --enable-debug flag
  3. In Qt Creator do "New Project" -> Import Project -> Import Existing Project
  4. Enter "bitcoin-qt" as project name, enter src/qt as location
  5. Leave the file selection as it is
  6. Confirm the "summary page"
  7. In the "Projects" tab select "Manage Kits..."
  8. Select the default "Desktop" kit and select "Clang (x86 64bit in /usr/bin)" as compiler
  9. Select LLDB as debugger (you might need to set the path to your installation)
  10. Start debugging with Qt Creator (you might need to the executable to "bitcoin-qt" under "Run", which is where you can also add command line arguments)