LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity
lbrycrd/src/qt
History
Wladimir J. van der Laan f29d5dbd04
Merge #10899: [test] Qt: Use _putenv_s instead of setenv on Windows builds 
0be03c7 Qt: Use _putenv_s instead of setenv on Windows builds (Brian McMichael)

Pull request description:

  Fixes https://github.com/bitcoin/bitcoin/issues/10836

  Error message I would get on `make`:
  ```
  ...
    CXXLD    bench/bench_bitcoin.exe
    OBJCXXLD qt/bitcoin-qt.exe
  qt/test/test_main.cpp: In function ‘int main(int, char**)’:
  qt/test/test_main.cpp:64:43: error: ‘setenv’ was not declared in this scope
       setenv("QT_QPA_PLATFORM", "minimal", 0);
                                             ^
  make[2]: *** [qt/test/qt_test_test_bitcoin_qt-test_main.o] Error 1
  make[2]: *** Waiting for unfinished jobs....
  make[2]: Leaving directory `/home/bmcmichael/Projects/bcoin/src'
  make[1]: *** [all-recursive] Error 1
  make[1]: Leaving directory `/home/bmcmichael/Projects/bcoin/src'
  make: *** [all-recursive] Error 1
  ```

  `setenv` function is not available from the Microsoft runtime library. Need to use `_putenv_s` instead.

  This solution tells the compiler to use `_putenv_s` on `WIN32` compilation (Note: this also works on 64-bit Windows instances.) and `setenv` everywhere else.

  I've tested builds on Windows 10 x64 and Ubuntu 16.04 with this code.

Tree-SHA512: d53c996c890e3c6f22b4f2dcca718bef9168f19a6d4a29b8ff13391bfc0c8ea9c1cd16782b47c25b156dcbdff18bb19e23bfd5f6fefb1f373c9d5454a13fc969
2017-07-26 08:12:01 +02:00
..
forms [Qt] replace fee slider with a Dropdown, extend conf. targets 2017-07-13 12:20:09 +02:00
locale qt: Periodic translations update 2017-07-20 23:33:53 +02:00
res [qt] Make network disabled icon 50% opaque 2016-11-13 22:06:35 +01:00
test Qt: Use _putenv_s instead of setenv on Windows builds 2017-07-21 17:20:14 -04:00
addressbookpage.cpp scripted-diff: Remove Q_FOREACH 2017-06-05 20:11:01 +02:00
addressbookpage.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
addresstablemodel.cpp scripted-diff: Remove #include <boost/foreach.hpp> 2017-06-22 03:48:52 +02:00
addresstablemodel.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
askpassphrasedialog.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
askpassphrasedialog.h qt: askpassphrasedialog: Clear pass fields on accept 2016-05-19 14:52:08 +03:00
bantablemodel.cpp Remove excess logic. 2017-04-10 10:24:49 +02:00
bantablemodel.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
bitcoin.cpp init: Factor out AppInitLockDataDirectory 2017-07-17 14:56:52 +02:00
bitcoin.qrc Overhaul network activity toggle 2016-10-24 10:23:58 +00:00
bitcoin_locale.qrc qt: periodic translations update 2017-01-10 12:52:02 +01:00
bitcoinaddressvalidator.cpp Added "Core" to copyright headers 2014-12-19 19:55:32 +01:00
bitcoinaddressvalidator.h Added "Core" to copyright headers 2014-12-19 19:55:32 +01:00
bitcoinamountfield.cpp Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
bitcoinamountfield.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
bitcoingui.cpp scripted-diff: Remove Q_FOREACH 2017-06-05 20:11:01 +02:00
bitcoingui.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
bitcoinstrings.cpp qt: Periodic translations update 2017-07-20 23:33:53 +02:00
bitcoinunits.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
bitcoinunits.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
callback.h Make qt wallet test compatible with qt4 2017-03-27 14:34:38 -04:00
clientmodel.cpp Avoid redundant redeclaration of GetWarnings(const string&) 2017-07-18 15:54:38 +02:00
clientmodel.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
coincontroldialog.cpp Make QT fee displays use GetMinimumFee instead of estimateSmartFee 2017-07-14 23:41:37 -04:00
coincontroldialog.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
coincontroltreewidget.cpp Limit variable scope 2017-06-05 00:52:36 +02:00
coincontroltreewidget.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
csvmodelwriter.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
csvmodelwriter.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
editaddressdialog.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
editaddressdialog.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
guiconstants.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
guiutil.cpp Consensus: Minimal way to move dust out of consensus 2017-05-03 17:55:52 +02:00
guiutil.h Merge #9890: Add a button to open the config file in a text editor 2017-04-10 10:46:21 +02:00
intro.cpp Turn TryCreateDirectory() into TryCreateDirectories() 2017-06-14 00:04:13 +02:00
intro.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
macdockiconhandler.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
macdockiconhandler.mm qt: update forgotten emit to Q_EMIT in macdockiconhandler.mm 2015-07-15 15:09:31 +02:00
macnotificationhandler.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
macnotificationhandler.mm Remove references to X11 licence 2014-12-16 15:56:50 +08:00
Makefile
modaloverlay.cpp Fixed multiple typos 2017-06-22 19:18:10 +03:00
modaloverlay.h qt: Use nPowTargetSpacing constant 2017-01-19 20:47:04 +01:00
networkstyle.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
networkstyle.h Added "Core" to copyright headers 2014-12-19 19:55:32 +01:00
notificator.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
notificator.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
openuridialog.cpp Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
openuridialog.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
optionsdialog.cpp Merge #10502: scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE 2017-06-13 18:05:58 -07:00
optionsdialog.h Add a button to open the config file in a text editor 2017-03-23 12:54:36 -04:00
optionsmodel.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
optionsmodel.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
overviewpage.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
overviewpage.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
paymentrequest.proto Specify Protobuf version 2 in paymentrequest.proto 2016-09-16 11:45:08 +08:00
paymentrequestplus.cpp Merge #9475: Let autoconf detect presence of EVP_MD_CTX_new 2017-01-05 10:28:47 +01:00
paymentrequestplus.h Selectively suppress deprecation warnings 2017-02-14 13:50:57 +01:00
paymentserver.cpp scripted-diff: Remove PAIRTYPE 2017-06-05 20:14:53 +02:00
paymentserver.h Move BIP70_MAX_PAYMENTREQUEST_SIZE to header 2017-02-17 11:54:32 -08:00
peertablemodel.cpp scripted-diff: Remove Q_FOREACH 2017-06-05 20:11:01 +02:00
peertablemodel.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
platformstyle.cpp scripted-diff: Remove Q_FOREACH 2017-06-05 20:11:01 +02:00
platformstyle.h qt: Introduce PlatformStyle 2015-07-31 09:35:18 +02:00
qvalidatedlineedit.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
qvalidatedlineedit.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
qvaluecombobox.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
qvaluecombobox.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
receivecoinsdialog.cpp scripted-diff: Remove Q_FOREACH 2017-06-05 20:11:01 +02:00
receivecoinsdialog.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
receiverequestdialog.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
receiverequestdialog.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
recentrequeststablemodel.cpp scripted-diff: Remove #include <boost/foreach.hpp> 2017-06-22 03:48:52 +02:00
recentrequeststablemodel.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
rpcconsole.cpp [Qt] Use wallet 0 in rpc console if running with multiple wallets 2017-07-20 20:24:52 +02:00
rpcconsole.h Merge #9450: Increment MIT licence copyright header year on files modified in 2016 2017-01-04 12:09:05 +01:00
sendcoinsdialog.cpp Make QT fee displays use GetMinimumFee instead of estimateSmartFee 2017-07-14 23:41:37 -04:00
sendcoinsdialog.h Use CoinControl to pass custom fee setting from QT. 2017-07-14 23:40:33 -04:00
sendcoinsentry.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
sendcoinsentry.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
signverifymessagedialog.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
signverifymessagedialog.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
splashscreen.cpp [Qt] allow to execute a callback during splashscreen progress 2017-06-29 17:48:08 +02:00
splashscreen.h [Qt] allow to execute a callback during splashscreen progress 2017-06-29 17:48:08 +02:00
trafficgraphwidget.cpp Merge #10502: scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE 2017-06-13 18:05:58 -07:00
trafficgraphwidget.h Bump copyright headers to 2015 2015-12-13 18:08:39 +01:00
transactiondesc.cpp scripted-diff: Remove PAIRTYPE 2017-06-05 20:14:53 +02:00
transactiondesc.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
transactiondescdialog.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
transactiondescdialog.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
transactionfilterproxy.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
transactionfilterproxy.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
transactionrecord.cpp scripted-diff: Remove #include <boost/foreach.hpp> 2017-06-22 03:48:52 +02:00
transactionrecord.h [Qt] make sure transaction table entry gets updated after bump 2017-05-24 17:09:01 +02:00
transactiontablemodel.cpp Merge #10502: scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE 2017-06-13 18:05:58 -07:00
transactiontablemodel.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
transactionview.cpp [qt] Avoid potential null pointer dereference in TransactionView::exportClicked() 2017-06-27 15:06:39 +02:00
transactionview.h [Qt] simple fee bumper with user verification 2017-05-11 15:27:04 +02:00
utilitydialog.cpp scripted-diff: Remove Q_FOREACH 2017-06-05 20:11:01 +02:00
utilitydialog.h Remove unnecessary forward class declarations in header files 2017-06-12 20:37:43 +02:00
walletframe.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
walletframe.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
walletmodel.cpp Refactor to use CoinControl in GetMinimumFee and FeeBumper 2017-07-14 23:10:58 -04:00
walletmodel.h Make CoinControl a required argument to CreateTransaction 2017-07-14 23:07:18 -04:00
walletmodeltransaction.cpp scripted-diff: Remove Q_FOREACH 2017-06-05 20:11:01 +02:00
walletmodeltransaction.h Bump copyright headers to 2014 2016-01-05 21:01:39 +01:00
walletview.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
walletview.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
winshutdownmonitor.cpp Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
winshutdownmonitor.h Added "Core" to copyright headers 2014-12-19 19:55:32 +01:00