lbrycrd/src/qt
Wladimir J. van der Laan f8be434133
Merge #13284: gui: fix visual "overflow" of amount input.
5f3cbde9de Increased max width of amount field to prevent number overflow bug. (Brandon Ruggles)

Pull request description:

  Fixes #13231.

  I was able to reproduce this bug within my own Fedora 27 VM. Following @jonasschnelli's advice, I first tried to change `setAlignment(Qt::AlignRight);` to `setAlignment(Qt::AlignLeft);`, however, I realized that this wouldn't fix the underlying overflow problem, as it would only make it easier to see the most significant digits under certain scenarios. The reason for the overflow is that Fedora uses plus and minus buttons on the Qt spin box class, rather than up and down arrows, which is what happens on **most** other operating systems. These plus and minus buttons take up more width, and therefore provide less space for text.

  The solution I went with was the second suggestion by @jonasschnelli, which was to just increase the maximum width of the amount box. After some experimentation, 240 seemed to be the smallest max width that would allow as many digits as one would want in the amount box without overflow, even with the plus and minus buttons in Fedora.

  Please let me know if there are any issues with this PR and I will work to fix them. Thank you!

Tree-SHA512: 155f34cec74af46ec1fe723a5241798d8e15607a4e1cdc493014dcc0ae9818a001c7901831168b5f26a6953ec5a992e4a67c57db1ad377bcf10f12941688ee93
2018-05-24 15:52:21 +02:00
..
forms GUI: Rephrase Bech32 checkbox text/tooltip 2018-05-17 09:31:35 +08:00
locale qt: Periodic translations update 2018-01-30 13:43:26 +01:00
res [gui] Add proxy icon in statusbar 2018-05-15 23:23:56 +03:00
test wallet: Use shared pointer to retain wallet instance 2018-05-22 16:56:20 +01:00
addressbookpage.cpp Qt: remove "new" button during receive-mode in addressbook 2018-03-19 12:13:08 +07:00
addressbookpage.h [tests] [qt] Add tests for address book manipulation via EditAddressDialog 2018-04-25 13:13:24 -04:00
addresstablemodel.cpp Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor 2018-05-02 16:49:59 +02:00
addresstablemodel.h Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor 2018-05-02 16:49:59 +02:00
askpassphrasedialog.cpp Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
askpassphrasedialog.h Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
bantablemodel.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
bantablemodel.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
bitcoin.cpp ui: Support wallets loaded dynamically 2018-05-16 20:48:48 +01:00
bitcoin.qrc [gui] Add proxy icon in statusbar 2018-05-15 23:23:56 +03:00
bitcoin_locale.qrc qt: periodic translations update 2017-01-10 12:52:02 +01:00
bitcoinaddressvalidator.cpp Split key_io (address/key encodings) off from base58 2018-02-19 18:55:21 -08:00
bitcoinaddressvalidator.h
bitcoinamountfield.cpp Increased max width of amount field to prevent number overflow bug. 2018-05-20 01:09:16 -04:00
bitcoinamountfield.h Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
bitcoingui.cpp [gui] Add proxy icon in statusbar 2018-05-15 23:23:56 +03:00
bitcoingui.h [gui] Add proxy icon in statusbar 2018-05-15 23:23:56 +03:00
bitcoinstrings.cpp initwallet: Do not translate highly technical addresstype help 2018-01-24 11:30:44 -05:00
bitcoinunits.cpp [qt] Added satoshi unit 2018-05-17 16:14:49 +02:00
bitcoinunits.h [qt] Added satoshi unit 2018-05-17 16:14:49 +02:00
callback.h Declare single-argument (non-converting) constructors "explicit" 2017-08-16 16:33:25 +02:00
clientmodel.cpp [gui] Add proxy icon in statusbar 2018-05-15 23:23:56 +03:00
clientmodel.h [gui] Add proxy icon in statusbar 2018-05-15 23:23:56 +03:00
coincontroldialog.cpp wallet: Make fee settings non-static members 2018-04-23 10:49:21 -04:00
coincontroldialog.h [gui] Defer coin control instancing 2018-02-01 19:40:20 +00:00
coincontroltreewidget.cpp Merge #10498: Use static_cast instead of C-style casts for non-fundamental types 2018-02-07 16:15:28 -05:00
coincontroltreewidget.h
csvmodelwriter.cpp Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
csvmodelwriter.h
editaddressdialog.cpp [qt] Display more helpful message when adding a send address has failed 2018-04-25 13:08:53 -04:00
editaddressdialog.h [tests] [qt] Add tests for address book manipulation via EditAddressDialog 2018-04-25 13:13:24 -04:00
guiconstants.h Increment MIT Licence copyright header year on files modified in 2016 2016-12-31 11:01:21 -07:00
guiutil.cpp Merge #12878: [refactor] Config handling refactoring in preparation for network-specific sections 2018-04-08 16:24:30 +02:00
guiutil.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
intro.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
intro.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
macdockiconhandler.h
macdockiconhandler.mm Document the preference of nullptr over NULL or (void*)0 2017-08-18 09:51:00 +02:00
macnotificationhandler.h Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
macnotificationhandler.mm [macOS] remove Growl support, remove unused code 2017-09-07 10:11:44 -07:00
Makefile
modaloverlay.cpp Fix typos 2018-03-21 08:34:44 +02:00
modaloverlay.h Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
networkstyle.cpp Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
networkstyle.h
notificator.cpp Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
notificator.h Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
openuridialog.cpp Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
openuridialog.h
optionsdialog.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
optionsdialog.h Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
optionsmodel.cpp Fix illegal default addProxy and addrSeparateProxyTor settings. 2018-04-10 22:22:55 +02:00
optionsmodel.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
overviewpage.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
overviewpage.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
paymentrequest.proto Specify Protobuf version 2 in paymentrequest.proto 2016-09-16 11:45:08 +08:00
paymentrequestplus.cpp Remove duplicate includes 2018-04-09 09:18:49 +02:00
paymentrequestplus.h Split key_io (address/key encodings) off from base58 2018-02-19 18:55:21 -08:00
paymentserver.cpp Merge #12729: Get rid of ambiguous OutputType::NONE value 2018-05-03 11:53:30 +02:00
paymentserver.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
peertablemodel.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
peertablemodel.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
platformstyle.cpp Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
platformstyle.h
qvalidatedlineedit.cpp Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
qvalidatedlineedit.h
qvaluecombobox.cpp Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
qvaluecombobox.h
README.md [doc] qt: fixes broken link on readme 2018-05-01 21:17:54 +01:00
receivecoinsdialog.cpp GUI: Allow generating Bech32 addresses with a legacy-address default 2018-05-17 09:40:50 +08:00
receivecoinsdialog.h Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
receiverequestdialog.cpp Qt: show wallet name in request dlg in case of multiwallet 2018-03-26 18:40:27 +07:00
receiverequestdialog.h Qt: show wallet name in request dlg in case of multiwallet 2018-03-26 18:40:27 +07:00
recentrequeststablemodel.cpp Remove direct bitcoin calls from qt transaction table files 2018-04-04 16:52:40 -04:00
recentrequeststablemodel.h Remove direct bitcoin calls from qt transaction table files 2018-04-04 16:52:40 -04:00
rpcconsole.cpp Add 'sethdseed' RPC to initialize or replace HD seed 2018-05-12 13:15:21 -04:00
rpcconsole.h Make sure initialization occurs in the constructor 2018-05-02 13:56:20 +02:00
sendcoinsdialog.cpp [qt]: changes sendcoinsdialog's box layout for improved readability. 2018-05-08 21:19:12 +01:00
sendcoinsdialog.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
sendcoinsentry.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
sendcoinsentry.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
signverifymessagedialog.cpp Remove most direct bitcoin calls from qt/walletmodel.cpp 2018-04-04 16:52:40 -04:00
signverifymessagedialog.h
splashscreen.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
splashscreen.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
trafficgraphwidget.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
trafficgraphwidget.h
transactiondesc.cpp Add purpose arg to Wallet::getAddress 2018-04-25 13:08:53 -04:00
transactiondesc.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
transactiondescdialog.cpp qt: Remove TransactionTableModel::TxIDRole 2018-03-07 13:08:20 +00:00
transactiondescdialog.h
transactionfilterproxy.cpp qt: Avoid querying unnecessary model data when filtering transactions 2018-03-11 22:21:51 +00:00
transactionfilterproxy.h Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
transactionrecord.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
transactionrecord.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
transactiontablemodel.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
transactiontablemodel.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
transactionview.cpp Remove most direct bitcoin calls from qt/walletmodel.cpp 2018-04-04 16:52:40 -04:00
transactionview.h [qt] navigate to transaction history page after send 2018-03-01 10:40:36 +01:00
utilitydialog.cpp Make gArgs aware of the arguments 2018-05-09 12:21:05 -04:00
utilitydialog.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
walletframe.cpp fixup! ui: Support wallets loaded dynamically 2018-05-18 00:46:44 +01:00
walletframe.h Qt: Get wallet name from WalletModel rather than passing it around 2018-03-26 18:40:26 +07:00
walletmodel.cpp Add purpose arg to Wallet::getAddress 2018-04-25 13:08:53 -04:00
walletmodel.h [tests] [qt] Add tests for address book manipulation via EditAddressDialog 2018-04-25 13:13:24 -04:00
walletmodeltransaction.cpp scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
walletmodeltransaction.h scripted-diff: Avoid interface keyword to fix windows gitian build 2018-04-07 03:42:02 -04:00
walletview.cpp Add cancel button to rescan progress dialog 2018-04-12 17:00:30 -04:00
walletview.h Qt: When multiple wallets are used, include in notifications the name 2018-03-26 18:40:26 +07:00
winshutdownmonitor.cpp Fix Windows build errors introduced in #10498 2018-02-12 15:48:37 +01:00
winshutdownmonitor.h

This directory contains the BitcoinQT graphical user interface (GUI). It uses the cross-platform framework Qt.

The current precise version for Qt 5 is specified in qt.mk. Qt 4 is also supported (see #8263).

Compile and run

See build instructions (OSX, Windows, Unix, etc).

To run:

./src/qt/bitcoin-qt

Files and directories

forms

Contains Designer UI files. They are created with Qt Creator, but can be edited using any text editor.

locale

Contains translations. They are periodically updated. The process is described here.

res

Resources such as the icon.

test

Tests.

bitcoingui.(h/cpp)

Represents the main window of the Bitcoin UI.

*model.(h/cpp)

The model. When it has a corresponding controller, it generally inherits from QAbstractTableModel. Models that are used by controllers as helpers inherit from other Qt classes like QValidator.

ClientModel is used by the main application bitcoingui and several models like peertablemodel.

*page.(h/cpp)

A controller. :NAMEpage.cpp generally includes :NAMEmodel.h and forms/:NAME.page.ui with a similar :NAME.

*dialog.(h/cpp)

Various dialogs, e.g. to open a URL. Inherit from QDialog.

paymentserver.(h/cpp)

Used to process BIP21 and BIP70 (see https://github.com/bitcoin/bitcoin/pull/11622) payment URI / requests. Also handles URI based application switching (e.g. when following a bitcoin:... link from a browser).

walletview.(h/cpp)

Represents the view to a single wallet.

Other .h/cpp files

  • UI elements like BitcoinAmountField, which inherit from QWidget.
  • bitcoinstrings.cpp: automatically generated
  • bitcoinunits.(h/cpp): BTC / mBTC / etc handling
  • callback.h
  • guiconstants.h: UI colors, app name, etc
  • guiutil.h: several helper functions
  • macdockiconhandler.(h/cpp)
  • macdockiconhandler.(h/cpp): display notifications in OSX

Contribute

See CONTRIBUTING.md for general guidelines. Specifically for Qt:

Using Qt Creator as IDE

You can use Qt Creator as an IDE. This is especially useful if you want to change the UI layout.

Download and install the community edition of Qt Creator. Uncheck everything except Qt Creator during the installation process.

Instructions for OSX:

  1. Make sure you installed everything through Homebrew mentioned in the OSX build instructions
  2. Use ./configure with the --enable-debug flag
  3. In Qt Creator do "New Project" -> Import Project -> Import Existing Project
  4. Enter "bitcoin-qt" as project name, enter src/qt as location
  5. Leave the file selection as it is
  6. Confirm the "summary page"
  7. In the "Projects" tab select "Manage Kits..."
  8. Select the default "Desktop" kit and select "Clang (x86 64bit in /usr/bin)" as compiler
  9. Select LLDB as debugger (you might need to set the path to your installation)
  10. Start debugging with Qt Creator (you might need to the executable to "bitcoin-qt" under "Run", which is where you can also add command line arguments)