set the default account upon successful /sync/get call #38

2019-05-10T16:55:24+02:00

akinwale commented

2019-05-10 16:55:24 +02:00

(Migrated from github.com)

No description provided.

eukreign (Migrated from github.com) reviewed 2019-05-10 16:55:24 +02:00

kauffj commented

2019-05-13 20:03:36 +02:00

(Migrated from github.com)

@seanyesmunt this looks good to me, can you review/merge?

neb-b (Migrated from github.com) approved these changes 2019-05-13 21:53:54 +02:00

neb-b (Migrated from github.com) left a comment

A couple questions but I think they can be handled after this is merged.

src/redux/actions/sync.js

					
				@ -34,0 +34,4 @@

				export function doSetDefaultAccount() {

				  return dispatch => {

				    dispatch({

				      type: ACTIONS.SET_DEFAULT_ACCOUNT,

neb-b (Migrated from github.com) commented

2019-05-13 21:51:51 +02:00

Nothing is listening for this? Do we need it?

src/redux/actions/sync.js

					
				@ -34,0 +54,4 @@

				      }

				      // Set the default account

				      if (defaultId) {

neb-b (Migrated from github.com) commented

2019-05-13 21:53:23 +02:00

If there is no defaultId, should we error to say that sync won't work for whatever reason?

If there is no `defaultId`, should we error to say that sync won't work for whatever reason?

akinwale (Migrated from github.com) reviewed 2019-05-14 16:56:18 +02:00

src/redux/actions/sync.js

					
				@ -34,0 +34,4 @@

				export function doSetDefaultAccount() {

				  return dispatch => {

				    dispatch({

				      type: ACTIONS.SET_DEFAULT_ACCOUNT,

akinwale (Migrated from github.com) commented

2019-05-14 16:56:17 +02:00

Just added this in case we may have to use it in the future.

akinwale (Migrated from github.com) reviewed 2019-05-14 16:57:09 +02:00

src/redux/actions/sync.js

					
				@ -34,0 +54,4 @@

				      }

				      // Set the default account

				      if (defaultId) {

akinwale (Migrated from github.com) commented

2019-05-14 16:57:08 +02:00

No need to throw an error here. If no default id is found, then the wallet will end up being set to the pre-existing default account when it was created.

Sign in to join this conversation.

No reviewers

eukreign

neb-b

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbryinc#38