LBRYCommunity/lbryinc
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity

unlock wallet if needed before syncing #70

Merged
neb-b merged 2 commits from sync-unlock into master 2019-10-21 18:16:18 +02:00
Conversation 0 Commits 2 Files changed 3 +208 -168
neb-b commented 2019-10-16 05:35:33 +02:00 (Migrated from github.com)
Copy link

Also attempted to make some of the promises easier to follow. I think ideally we would just try to call sync_apply, then if the wallet is locked, call wallet_unlock. However, this is not possible until https://github.com/lbryio/lbry-sdk/issues/1118 is implemented

Also attempted to make some of the promises easier to follow. I think ideally we would just try to call `sync_apply`, then if the wallet is locked, call `wallet_unlock`. However, this is not possible until https://github.com/lbryio/lbry-sdk/issues/1118 is implemented
akinwale (Migrated from github.com) reviewed 2019-10-21 17:51:11 +02:00
src/redux/actions/sync.js
akinwale (Migrated from github.com) commented 2019-10-21 17:51:10 +02:00
Copy link

Should this be dependent on sync_apply completing? If sync_apply fails here, the callback will never be called.

Should this be dependent on `sync_apply` completing? If `sync_apply` fails here, the callback will never be called.
akinwale (Migrated from github.com) reviewed 2019-10-21 17:52:15 +02:00
src/redux/actions/sync.js
@ -143,0 +135,4 @@
if (data.hasSyncedWallet) {
const error = 'Error getting synced wallet';
dispatch({
type: ACTIONS.GET_SYNC_FAILED,
akinwale (Migrated from github.com) commented 2019-10-21 17:52:15 +02:00
Copy link

I guess this is also the same concern as my other comment. Should the callback only be called after sync_apply is done? And what happens if sync_apply fails?

I guess this is also the same concern as my other comment. Should the callback only be called after `sync_apply` is done? And what happens if `sync_apply` fails?
neb-b (Migrated from github.com) reviewed 2019-10-21 17:53:58 +02:00
src/redux/actions/sync.js
neb-b (Migrated from github.com) commented 2019-10-21 17:53:58 +02:00
Copy link

Good point. I'll add another catch to this one

Good point. I'll add another catch to this one
neb-b (Migrated from github.com) reviewed 2019-10-21 17:55:10 +02:00
src/redux/actions/sync.js
@ -143,0 +135,4 @@
if (data.hasSyncedWallet) {
const error = 'Error getting synced wallet';
dispatch({
type: ACTIONS.GET_SYNC_FAILED,
neb-b (Migrated from github.com) commented 2019-10-21 17:55:10 +02:00
Copy link

If it fails here it will be caught down below

If it fails here it will be caught down below
akinwale (Migrated from github.com) approved these changes 2019-10-21 18:14:02 +02:00
akinwale (Migrated from github.com) left a comment
Copy link

Looks good!

Looks good!
Sign in to join this conversation.
Reviewers
No reviewers
akinwale
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbryinc#70
No description provided.
Delete branch "sync-unlock"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?