LBRYCommunity/lbryinc
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity

Transifex upload #76

Merged
akinwale merged 3 commits from transifex-upload into master 2019-12-05 13:13:10 +01:00
Conversation 0 Commits 3 Files changed 4 +2553 -230
akinwale commented 2019-11-20 03:28:48 +01:00 (Migrated from github.com)
Copy link
No description provided.
neb-b (Migrated from github.com) reviewed 2019-11-20 19:31:12 +01:00
src/util/transifex-upload.js
neb-b (Migrated from github.com) commented 2019-11-20 19:31:12 +01:00
Copy link

Should this be in some env?

Should this be in some env?
kauffj (Migrated from github.com) reviewed 2019-11-20 20:08:02 +01:00
src/util/transifex-upload.js
kauffj (Migrated from github.com) commented 2019-11-20 20:08:01 +01:00
Copy link

yes and now we're going to have to update it everywhere 😠

yes and now we're going to have to update it everywhere :angry:
kauffj (Migrated from github.com) reviewed 2019-11-20 20:09:30 +01:00
src/util/transifex-upload.js
kauffj (Migrated from github.com) commented 2019-11-20 20:09:30 +01:00
Copy link

it looks like this one may be just for this project, so possibly not as bad

it looks like this one may be just for this project, so possibly not as bad
kauffj (Migrated from github.com) reviewed 2019-11-20 20:40:14 +01:00
src/util/transifex-upload.js
@ -0,0 +1,78 @@
const apiBaseUrl = 'https://www.transifex.com/api/2/project';
kauffj (Migrated from github.com) commented 2019-11-20 20:39:42 +01:00
Copy link

all of this code should only be happening in trusted dev environments (i.e. those we have given a key too)

this is potentially an argument to keeping the model of PR'ing the translation file and having the push happen on build, because it would allow all developers to add translations without us needing to give keys out

all of this code should only be happening in trusted dev environments (i.e. those we have given a key too) this is potentially an argument to keeping the model of PR'ing the translation file and having the push happen on build, because it would allow all developers to add translations without us needing to give keys out
kauffj (Migrated from github.com) commented 2019-11-20 20:39:55 +01:00
Copy link

(and code should not ship in production bundle)

(and code should not ship in production bundle)
src/util/transifex-upload.js
@ -0,0 +22,4 @@
try {
// transifex api returns Python dicts for some reason.
// Any way to get the api to return valid JSON?
json = JSON.parse(text);
kauffj (Migrated from github.com) commented 2019-11-20 20:40:07 +01:00
Copy link

I'm confused, you can call JSON.parse but not .json()?

I'm confused, you can call JSON.parse but not .json()?
akinwale (Migrated from github.com) reviewed 2019-11-22 03:00:55 +01:00
src/util/transifex-upload.js
@ -0,0 +22,4 @@
try {
// transifex api returns Python dicts for some reason.
// Any way to get the api to return valid JSON?
json = JSON.parse(text);
akinwale (Migrated from github.com) commented 2019-11-22 03:00:55 +01:00
Copy link

Yes. The parse call is an attempt to see if the response returned is valid JSON. If it's not, I just call the success callback with the raw text response instead. This happens whether or not it was a successful operation, or if an error occurred.

Yes. The `parse` call is an attempt to see if the response returned is valid JSON. If it's not, I just call the success callback with the raw text response instead. This happens whether or not it was a successful operation, or if an error occurred.
akinwale (Migrated from github.com) reviewed 2019-11-22 03:03:02 +01:00
src/util/transifex-upload.js
@ -0,0 +1,78 @@
const apiBaseUrl = 'https://www.transifex.com/api/2/project';
akinwale (Migrated from github.com) commented 2019-11-22 03:03:02 +01:00
Copy link

I'm not aware of a way to exclude the code specifically, but I can look into a way of loading the key dynamically instead of hardcoding.

I'm not aware of a way to exclude the code specifically, but I can look into a way of loading the key dynamically instead of hardcoding.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbryinc#76
No description provided.
Delete branch "transifex-upload"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?