Strikethrough Formatting does not transfer to LBRY Post #32

New issue

Open

opened 2020-05-24 19:03:20 +02:00 by cahlenlee · 1 comment

cahlenlee commented

2020-05-24 19:03:20 +02:00

(Migrated from github.com)

DESCRIPTION:
Using Strikethrough formatting in a Wordpress post does not carry over to the LBRY version of the post.

REPRO STEPS:

Log into self-hosted Wordpress site w/ LBRYPress Plugin
Create a new Post
Create a Paragraph Block
Enter text and format with Strikethrough
Publish and review on LBRY

Results: Strikethrough formatting is missing

Expected: Strikethrough formatting is present

ENVIRONMENT:
Ubuntu 18.04.4
WordPress 5.3.3
PHP 7.2.24
LBRYPress 0.0.1
Lodestar Theme 1.0.8

IMAGES:

LBRY ADDRESS:
bZSqrVdpxt5KJdn2eGMUzT9Jn3gEiRet7b
mail@cahlen.org

**DESCRIPTION:** Using Strikethrough formatting in a Wordpress post does not carry over to the LBRY version of the post. ----- **REPRO STEPS:** 1) Log into self-hosted Wordpress site w/ LBRYPress Plugin 2) Create a new Post 3) Create a Paragraph Block 4) Enter text and format with Strikethrough 5) Publish and review on LBRY **Results:** Strikethrough formatting is missing **Expected:** Strikethrough formatting is present ----- **ENVIRONMENT:** Ubuntu 18.04.4 WordPress 5.3.3 PHP 7.2.24 LBRYPress 0.0.1 Lodestar Theme 1.0.8 ----- **IMAGES:** ![LBRYPress_0 1 1_TextColorLBRY](https://user-images.githubusercontent.com/30788194/82760002-0c08e000-9dae-11ea-9e86-176b5db53a9e.png) ![LBRYPress_0 1 1_TextColorWordpress](https://user-images.githubusercontent.com/30788194/82760004-0e6b3a00-9dae-11ea-8d04-64182e9ec78e.png) ----- **LBRY ADDRESS:** bZSqrVdpxt5KJdn2eGMUzT9Jn3gEiRet7b mail@cahlen.org

QuirkyRobots commented

2020-05-27 04:12:16 +02:00

(Migrated from github.com)

According to the "HTML To Markdown for PHP" documentation,

Markdown Extra, MultiMarkdown and other variants aren't supported – just Markdown.

Which as far as I'm aware doesn't include ~~strikethrough~~.

In the Elements file, I don't see it registered:

    public function isBlock()
    {
        switch ($this->getTagName()) {
            case 'blockquote':
            case 'body':
            case 'code':
            case 'div':
            case 'h1':
            case 'h2':
            case 'h3':
            case 'h4':
            case 'h5':
            case 'h6':
            case 'hr':
            case 'html':
            case 'li':
            case 'p':
            case 'ol':
            case 'ul':
                return true;
            default:
                return false;
        }
    }

I guess it would have to be added to the converter here?

According to the "HTML To Markdown for PHP" [documentation](https://github.com/lbryio/lbrypress/tree/master/vendor/league/html-to-markdown#limitations), > Markdown Extra, MultiMarkdown and other variants aren't supported – just Markdown. Which as far as I'm aware doesn't include ~~strikethrough~~. In the [Elements file](https://github.com/lbryio/lbrypress/blob/master/vendor/league/html-to-markdown/src/Element.php), I don't see it registered: ```php public function isBlock() { switch ($this->getTagName()) { case 'blockquote': case 'body': case 'code': case 'div': case 'h1': case 'h2': case 'h3': case 'h4': case 'h5': case 'h6': case 'hr': case 'html': case 'li': case 'p': case 'ol': case 'ul': return true; default: return false; } } ``` I guess it would have to be added to the converter [here](https://github.com/lbryio/lbrypress/tree/master/vendor/league/html-to-markdown/src/Converter)?