add lbc image, fix wallet balance #43

Merged

lemsmyth merged 3 commits from wallet-balance-fix into master

2022-01-31 15:12:43 +01:00

lemsmyth commented

2022-01-25 22:36:45 +01:00

(Migrated from github.com)

#42 gets available wallet balance adds LBC icon to available wallet amount

lyoshenka commented

2022-01-28 20:17:14 +01:00

(Migrated from github.com)

thanks for the PR @lemsmyth! @prkirby could you please take a look at this when you get a chance

would love to show you both some appreciation for your contributions :-)

thanks for the PR @lemsmyth! @prkirby could you please take a look at this when you get a chance would love to show you both some [appreciation](https://lbry.com/faq/appreciation) for your contributions :-)

prkirby (Migrated from github.com) requested changes 2022-01-28 22:33:36 +01:00

prkirby (Migrated from github.com) left a comment

Just one comment

classes/LBRY_Daemon.php

prkirby (Migrated from github.com) commented

2022-01-28 22:29:56 +01:00

This statement isn't reachable it looks like? should it be above the return statement?

prkirby (Migrated from github.com) commented

2022-01-28 22:31:56 +01:00

I'm assuming this is just updating the call? Where is $wallet_balance used?

lemsmyth (Migrated from github.com) reviewed 2022-01-29 00:25:44 +01:00

classes/LBRY_Daemon.php

lemsmyth (Migrated from github.com) commented

2022-01-29 00:25:44 +01:00

Yes you are correct not reachable and unneeded, have removed the $wallet_balance variable and also updated the try - catch to throw updated error message.
Using the $wallet_balance lines 3-4 and 11 on options-page to drill down and access result->available to output the available, unstaked amount in the wallet, prior was showing a much smaller amount (maybe the amount from one address?) than was actually available for use in the wallet.

Yes you are correct not reachable and unneeded, have removed the $wallet_balance variable and also updated the try - catch to throw updated error message. Using the $wallet_balance lines 3-4 and 11 on options-page to drill down and access result->available to output the available, unstaked amount in the wallet, prior was showing a much smaller amount (maybe the amount from one address?) than was actually available for use in the wallet.