poor search results on related content / related to weighing on claim bid and %20? #108
Labels
No labels
area: app c
area: app d
area: devops
area: discovery
area: docs
area: proposal
area: X-device Sync
Chainquery
consider soon
dependencies
Epic
Fix till next release
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Parked
priority: blocker
priority: high
priority: low
priority: medium
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lighthouse.js#108
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When going to lbry://cz-abl-rhodes#4eff956d91e02c9baae3f1f843a01cadf08b7556, the recommended results are pretty poor (based on the title). Search query: https://lighthouse.lbry.io/search?s=CryptoCandor%20%7C%20Live%20w%20Crypto%20Zombie,%20Sara%20-%20Altcoin%20Buzz%20Ladies,%20&%20Rhode%20Block!&size=20&from=0
I'm guessing this is related to https://github.com/lbryio/lighthouse/issues/32
here's another example on lbry://quick-lunduke-show-update-lunduke-show#4f995883cd68f4561d3b8b5e5744af0571eac384
Here's an even worse one...lots of the @Porn hits from the community top bids:
Just noticed: https://github.com/lbryio/lbry-desktop/issues/1911
so the query was: https://lighthouse.lbry.io/search?s=GameTales%20 - the %20 (space) is bringing in the porn results. Maybe this is what's causing it to happen on other queries too.
We should try to get this patched up ASAP since we are close to releasing an app with recommended content.
@seanyesmunt created another issue for this. He is now filtering out NSFW content appside. #110 check it out. If we can avoid the unintended side effects of effective amount is that preferable? I mean what we have is what we expected by implementing the issue, just not desired.
These results shouldn't be coming in at all - they are only coming back because of the %20/space in the search. How can we make sure that these characters are ignored? If we are passing search terms, it should only take the terms into account, not any special characters, including spaces.
there should be no leading or trailing spaces in a search. We can trim both sides of any query that comes in to enforce that.
I am also worried that we are doing something wrong app side to produce this. @seanyesmunt Any idea how a trailing space is getting passed to the search api?
It's not only an issue with the trailing space, it's an issue with any spaces. See first example: https://lighthouse.lbry.io/search?s=CryptoCandor%20%7C%20Live%20w%20Crypto%20Zombie,%20Sara%20-%20Altcoin%20Buzz%20Ladies,%20&%20Rhode%20Block!&size=20&from=0
If we don't understand how to handle this scenario, we should revert the effective amount changes for the time being.
Lighthouse IP was reverted to an earlier instance as a workaround.
Need to understand the root cause before proceeding
The root cause was due to the search query not being trimmed. We previously had an issue with internal server errors on specific characters. These characters needed to be escaped. They also needed the trim function called. When I added this the results even with the effective amount worked great.
@alyssaoc This needs coordination with @nikooo777 / @filipnyquist . They did something with the machine and reverted to an old vm? Not sure exactly what happened. The effective amount changes will cause internal server errors if the elasticsearch db is not rebuilt. The IP was changed, so I assume we can merge, pull, build, deploy on the REAL production instance, and then change the IPs back.
@nikooo777 Can you please confirm?
Solved with https://github.com/lbryio/lighthouse/pull/114
Correct!
@filipnyquist is this something you can handle in the following days? I can switch the IP whenever it's ready
This has been merged. Currently awaiting a deployment to production for testing. Then if all goes well the ip can be switched to the production instance.