LBRYCommunity/lighthouse.js
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Added NSFW filter to query #122

Merged
marcdeb1 merged 3 commits from nsfw_filter into master 2018-10-21 22:34:17 +02:00
Conversation 3 Commits 3 Files changed 1 +23 -3
marcdeb1 commented 2018-10-17 11:57:18 +02:00 (Migrated from github.com)
Copy link

Nsfw parameter added to input, for example :
http://127.0.0.1:50005/search?s=lbry&nsfw=true
returns only nsfw results (see issue #110).
Other filters can easily added to the getFilters function.

Nsfw parameter added to input, for example : http://127.0.0.1:50005/search?s=lbry&nsfw=true returns only nsfw results (see issue #110). Other filters can easily added to the getFilters function.
tiger5226 (Migrated from github.com) reviewed 2018-10-18 02:37:43 +02:00
server/controllers/lighthouse.js
@ -246,2 +220,4 @@
'value.stream.metadata.title',
'value.stream.metadata.description',
],
},
tiger5226 (Migrated from github.com) commented 2018-10-18 02:37:43 +02:00
Copy link

This worked? I need to double check but I thought it stores the value in elastic search in the same way it is grabbed from Chainquery [0,1]

This worked? I need to double check but I thought it stores the value in elastic search in the same way it is grabbed from Chainquery [[0,1]](https://chainquery.lbry.io/api/sql?query=SELECT%20name,is_nsfw%20FROM%20claim%20WHERE%20name%20=%22awakeningshortfilm%22)
marcdeb1 (Migrated from github.com) reviewed 2018-10-18 08:24:02 +02:00
server/controllers/lighthouse.js
@ -246,2 +220,4 @@
'value.stream.metadata.title',
'value.stream.metadata.description',
],
},
marcdeb1 (Migrated from github.com) commented 2018-10-18 08:24:02 +02:00
Copy link

Do you mean for value.stream.metadata.nsfw ? There is no nsfw field at the top level like for "channel", it's inside the value object.

Do you mean for value.stream.metadata.nsfw ? There is no nsfw field at the top level like for "channel", it's inside the value object.
tiger5226 (Migrated from github.com) reviewed 2018-10-19 03:22:31 +02:00
server/controllers/lighthouse.js
@ -246,2 +220,4 @@
'value.stream.metadata.title',
'value.stream.metadata.description',
],
},
tiger5226 (Migrated from github.com) commented 2018-10-19 03:22:31 +02:00
Copy link

yeah, you are comparing value.stream.metadata.nsfw to input.nsfw. I was just saying that I thought one is a number and one is string. I am not too great with javascript. Maybe [0,1] is mapped to true/false automatically. I just need to load up the branch locally to validate. I will do this soon. Thanks for the PR!

yeah, you are comparing `value.stream.metadata.nsfw` to `input.nsfw`. I was just saying that I thought one is a number and one is string. I am not too great with javascript. Maybe `[0,1]` is mapped to `true/false` automatically. I just need to load up the branch locally to validate. I will do this soon. Thanks for the PR!
marcdeb1 (Migrated from github.com) reviewed 2018-10-19 10:16:14 +02:00
server/controllers/lighthouse.js
@ -246,2 +220,4 @@
'value.stream.metadata.title',
'value.stream.metadata.description',
],
},
marcdeb1 (Migrated from github.com) commented 2018-10-19 10:16:14 +02:00
Copy link

It's stored as true/false in Elasticsearch https://www.elastic.co/guide/en/elasticsearch/reference/current/boolean.html#boolean

It's stored as true/false in Elasticsearch https://www.elastic.co/guide/en/elasticsearch/reference/current/boolean.html#boolean
tiger5226 (Migrated from github.com) approved these changes 2018-10-21 06:09:35 +02:00
tiger5226 (Migrated from github.com) left a comment
Copy link

Looks good now

Looks good now
tiger5226 commented 2018-10-21 06:10:27 +02:00 (Migrated from github.com)
Copy link

@filipnyquist I reviewed this and tested it locally. All is well. If you have any comments, please note them, otherwise I will merge and deploy this early in the week.

@filipnyquist I reviewed this and tested it locally. All is well. If you have any comments, please note them, otherwise I will merge and deploy this early in the week.
marcdeb1 commented 2018-10-22 07:46:28 +02:00 (Migrated from github.com)
Copy link

Thanks for adding the docs !

Thanks for adding the docs !
tzarebczan commented 2018-10-30 00:54:03 +01:00 (Migrated from github.com)
Copy link

@marcdeb1, please shoot us an email to hello@lbry.io with a time estimate for this one too :)

Thanks for the PR!

@marcdeb1, please shoot us an email to hello@lbry.io with a time estimate for this one too :) Thanks for the PR!
Sign in to join this conversation.
Reviewers
No reviewers
tiger5226
Labels
Clear labels   
area: app c

Work is part of App C

  
area: app d

Work is part of App D

  
area: devops

   
area: discovery

   
area: docs

   
area: proposal

Work is part of a proposal

  
area: X-device Sync

Cross Device experience

  
Chainquery

This feature or fix will be possible with chainquery.

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
Fix till next release

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
Parked

on hold for a dependency or to be planned

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: app c
area: app d
area: devops
area: discovery
area: docs
area: proposal
area: X-device Sync
Chainquery
consider soon
dependencies
Epic
Fix till next release
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Parked
priority: blocker
priority: high
priority: low
priority: medium
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lighthouse.js#122
No description provided.
Delete branch "nsfw_filter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?