LBRYCommunity/lighthouse.js
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

added channel effective amount to the claim weight. #141

Merged
tiger5226 merged 2 commits from add_channel_weight into master 2019-02-25 03:52:38 +01:00
Conversation 6 Commits 2 Files changed 2 +17 -6
tiger5226 commented 2019-01-10 03:40:52 +01:00 (Migrated from github.com)
Copy link
No description provided.
tzarebczan commented 2019-01-14 17:17:15 +01:00 (Migrated from github.com)
Copy link

@tiger5226 mentioned we need to re-sync the data to get this populated, but he was hesitant because of previous issues with lighthouse + chainquery sync.

@tiger5226 mentioned we need to re-sync the data to get this populated, but he was hesitant because of previous issues with lighthouse + chainquery sync.
tiger5226 commented 2019-01-15 01:21:12 +01:00 (Migrated from github.com)
Copy link

Yeah with so many claims now and the limits on node ( we should try to figure out how to increase this? ) I don't want it to fail and get in a restart loop. The solution here is to batch the sql query. Right now it is an http call which grabs all claims (when we do a full sync up). I would not expect that to be too many MB. We are already batching them up when inserting into elastic search. However, we never got to the root cause on dev.

Yeah with so many claims now and the limits on node ( we should try to figure out how to increase this? ) I don't want it to fail and get in a restart loop. The solution here is to batch the sql query. Right now it is an http call which grabs all claims (when we do a full sync up). I would not expect that to be too many MB. We are already batching them up when inserting into elastic search. However, we never got to the root cause on dev.
tiger5226 commented 2019-02-09 23:37:55 +01:00 (Migrated from github.com)
Copy link

I misspoke above. This does require a full sync but it is best we just recreate the production environment altogether.

@nikooo777 We just need to rebuild with this branch so all the claims get synced problem and we can test. All claims must have this field otherwise it will error for normal searches. Once we verify we can do the DSN switch.

I misspoke above. This does require a full sync but it is best we just recreate the production environment altogether. @nikooo777 We just need to rebuild with this branch so all the claims get synced problem and we can test. All claims must have this field otherwise it will error for normal searches. Once we verify we can do the DSN switch.
nikooo777 (Migrated from github.com) approved these changes 2019-02-13 13:38:22 +01:00
nikooo777 (Migrated from github.com) left a comment
Copy link

if it works then LGTM, but please check that last comment first

if it works then LGTM, but please check that last comment first
server/controllers/lighthouse.js
@ -72,0 +68,4 @@
'field_value_factor': {
'field' : 'effective_amount',
'factor' : effectiveFactor,
'missing': 1,
nikooo777 (Migrated from github.com) commented 2019-02-13 13:37:26 +01:00
Copy link

are you sure this works? I'd expect it to be

          'source': `${effectiveFactor * doc['certificate_amount'].value}`,

(and same above)

are you sure this works? I'd expect it to be ```suggestion 'source': `${effectiveFactor * doc['certificate_amount'].value}`, ``` (and same above)
server/controllers/lighthouse.js
nikooo777 (Migrated from github.com) commented 2019-02-13 13:35:13 +01:00
Copy link

I don't exactly know how it works in nodeJS but I bet interfaces would be suit well here to avoid this dry violation :p

I don't exactly know how it works in nodeJS but I bet interfaces would be suit well here to avoid this dry violation :p
nikooo777 (Migrated from github.com) commented 2019-02-13 13:35:50 +01:00
Copy link

NBD though, it's probably just a waste of time right now

NBD though, it's probably just a waste of time right now
tiger5226 commented 2019-02-13 17:07:14 +01:00 (Migrated from github.com)
Copy link

@nikooo777 It does not work at the moment. We need to rebuild ( see previous comment ) the elastic search database to test this change. So I committed your suggestion, I agree. We need to get an environment setup with these changes. Not sure it will work with that many claims so I have have to break the query up to get say 10K claims per query first.

@nikooo777 It does not work at the moment. We need to rebuild ( see previous comment ) the elastic search database to test this change. So I committed your suggestion, I agree. We need to get an environment setup with these changes. Not sure it will work with that many claims so I have have to break the query up to get say 10K claims per query first.
tiger5226 commented 2019-02-25 03:53:08 +01:00 (Migrated from github.com)
Copy link

I found a solution where we can set a default value if it is missing.

I found a solution where we can set a default value if it is missing.
tiger5226 commented 2019-02-25 06:15:04 +01:00 (Migrated from github.com)
Copy link

@nikooo777 ready for a rebuild now. Use the certificate_amount branch.

@nikooo777 ready for a rebuild now. Use the `certificate_amount` branch.
Sign in to join this conversation.
Reviewers
No reviewers
nikooo777
Labels
Clear labels   
area: app c

Work is part of App C

  
area: app d

Work is part of App D

  
area: devops

   
area: discovery

   
area: docs

   
area: proposal

Work is part of a proposal

  
area: X-device Sync

Cross Device experience

  
Chainquery

This feature or fix will be possible with chainquery.

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
Fix till next release

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
Parked

on hold for a dependency or to be planned

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: app c
area: app d
area: devops
area: discovery
area: docs
area: proposal
area: X-device Sync
Chainquery
consider soon
dependencies
Epic
Fix till next release
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Parked
priority: blocker
priority: high
priority: low
priority: medium
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lighthouse.js#141
No description provided.
Delete branch "add_channel_weight"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?