use DB connector instead of web API #158
No reviewers
Labels
No labels
area: app c
area: app d
area: devops
area: discovery
area: docs
area: proposal
area: X-device Sync
Chainquery
consider soon
dependencies
Epic
Fix till next release
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Parked
priority: blocker
priority: high
priority: low
priority: medium
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lighthouse.js#158
Loading…
Reference in a new issue
No description provided.
Delete branch "chainquery-db-connection"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
using the web API is not smart. this PR fixes that issue
We cannot remove that logging. It's important that we see that. Otherwise, I did not test this out with the app. I know you said it is pretty solid. Maybe @tzarebczan can take a look too in dev to make sure its good to go.
I put this here intentionally. I need to know when they fail so I can make sure I fix any data in chainquery. We should however, make sure its not hardcoded and only production reports.
I don't know if this is right brother. I needs to be pushed as a json string for it to work properly. I would need to test this. However, I think you think this is pretty solid.
Just some best practice suggestions in a file that doesn't look like it's adhering too closely to them in the first place 😛
@ -9,3 +9,3 @@
import slack from 'node-slack';
import Slack from 'node-slack';
require('winston-daily-rotate-file');
const
is technically more appropriate thanlet
here but it doesn't really matterthese lines should probably go at top of file
A slightly better pattern would be:
connection = getConnection()
Not strictly necessary but you can use
Array.map
for this:@nikooo777 what's the status of this PR? Sitting out here a while.
I have to find time to clean it up... I'll try to get that done asap.